Add add/sub methods that only panic with debug assertions to rustc#123175
Add add/sub methods that only panic with debug assertions to rustc#123175bors merged 1 commit intorust-lang:masterfrom
Conversation
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
|
@wesleywiser o/ |
wesleywiser
left a comment
There was a problem hiding this comment.
r=me
Could you fix the PR description as well? I don't think #724 is right 😄
|
@bors rollup=never Perf sensitive |
This mitigates the perf impact of enabling overflow checks on rustc. The change to use overflow checks will be done in a later PR.
21951cd to
5039160
Compare
|
I don't think this should be performance sensitive, but you never know what happens |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (af6a161): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 677.445s -> 676.973s (-0.07%) |
This mitigates the perf impact of enabling overflow checks on rustc. The change to use overflow checks will be done in a later PR.
For rust-lang/compiler-team#724, based on data gathered in #119440.