Merged
Conversation
rustbot
added
A-query-system
Collaborator
|
The Miri subtree was changed cc @rust-lang/miri |
reitermarkus
force-pushed
the
generic-nonzero-stable
branch
from
6349bfb to
fca5bab
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Noratrieb
reviewed
Apr 21, 2024
Noratrieb
reviewed
Apr 21, 2024
This comment has been minimized.
This comment has been minimized.
reitermarkus
force-pushed
the
generic-nonzero-stable
branch
from
386e822 to
09df014
Compare
This comment has been minimized.
This comment has been minimized.
reitermarkus
force-pushed
the
generic-nonzero-stable
branch
2 times, most recently
from
9e4a7c6 to
2265ecb
Compare
21 tasks
This comment has been minimized.
This comment has been minimized.
reitermarkus
force-pushed
the
generic-nonzero-stable
branch
from
2265ecb to
636f99c
Compare
reitermarkus
force-pushed
the
generic-nonzero-stable
branch
from
636f99c to
33e68aa
Compare
dtolnay
approved these changes
Apr 22, 2024
Member
dtolnay
left a comment
dtolnay
left a comment
There was a problem hiding this comment.
Nicely done. Thank you for all your work on this feature.
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 22, 2024
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#115913 (checked_ilog: improve performance) - rust-lang#124178 ([cleanup] [llvm backend] Prevent creating the same `Instance::mono` multiple times) - rust-lang#124183 (Stop taking `ParamTy`/`ParamConst`/`EarlyParamRegion`/`AliasTy` by ref) - rust-lang#124217 (coverage: Prepare for improved branch coverage) - rust-lang#124230 (Stabilize generic `NonZero`.) - rust-lang#124252 (Improve ICE message for forbidden dep-graph reads.) - rust-lang#124268 (Update books) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 23, 2024
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#115913 (checked_ilog: improve performance) - rust-lang#124178 ([cleanup] [llvm backend] Prevent creating the same `Instance::mono` multiple times) - rust-lang#124183 (Stop taking `ParamTy`/`ParamConst`/`EarlyParamRegion`/`AliasTy` by ref) - rust-lang#124217 (coverage: Prepare for improved branch coverage) - rust-lang#124230 (Stabilize generic `NonZero`.) - rust-lang#124252 (Improve ICE message for forbidden dep-graph reads.) - rust-lang#124268 (Update books) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 23, 2024
Rollup merge of rust-lang#124230 - reitermarkus:generic-nonzero-stable, r=dtolnay Stabilize generic `NonZero`. Tracking issue: rust-lang#120257 r? `@dtolnay`
Contributor
|
Just noticed this after a few month after stabilization by seeing them from rust-analyzer completions. It has quite a poor discoverability for us old users familiar with NonZero*. Do we want to deprecate the old NonZero* (which are now type aliases. Is it possible?) to improve discoverability, or, if that's too intrusive, could we add a clippy warning for that? There's some discussion on clippy side already: rust-lang/rust-clippy#13019 |
Contributor
Author
|
I already tried deprecating it, see #124587 (comment). Adding a clippy lint seems like a good start. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #120257
r? @dtolnay