switch to the default implementation of write_vectored#125333
Merged
bors merged 2 commits intorust-lang:masterfrom May 21, 2024
Merged
switch to the default implementation of write_vectored#125333bors merged 2 commits intorust-lang:masterfrom
write_vectored#125333bors merged 2 commits intorust-lang:masterfrom
Conversation
Collaborator
|
rustbot has assigned @workingjubilee. Use |
rustbot
added
O-hermit
| } | ||
|
|
||
| Ok(size.try_into().unwrap()) | ||
| crate::io::default_write_vectored(|b| self.write(b), bufs) |
Member
There was a problem hiding this comment.
huh, this appears to be the exact same implementation as what's on the left. weird.
Contributor
Author
There was a problem hiding this comment.
Yes, but is_write_vectored was wrong.
Contributor
There was a problem hiding this comment.
You could probably just delete the implementation altogether, it'll fall back to the default automatically.
Member
There was a problem hiding this comment.
This is the impl of Socket, tho, innit?
Or do you mean that the write_vectored calls will resolve to the trait and then dispatch to that one's default impl?
Contributor
There was a problem hiding this comment.
This is the impl of Socket, tho, innit?
Oh yeah. Nevermind my comment then, didn't notice.
Member
|
lgtm |
Collaborator
bors
added
S-waiting-on-bors
Member
|
@bors rollup |
Member
bors
added
S-waiting-on-author
Contributor
Author
Member
|
Nice, okay! |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 21, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#124050 (Remove libc from MSVC targets) - rust-lang#124283 (Note for E0599 if shadowed bindings has the method.) - rust-lang#125123 (Fix `read_exact` and `read_buf_exact` for `&[u8]` and `io:Cursor`) - rust-lang#125158 (hir pretty: fix block indent) - rust-lang#125308 (track cycle participants per root) - rust-lang#125332 (Update books) - rust-lang#125333 (switch to the default implementation of `write_vectored`) - rust-lang#125346 (Remove some `Path::to_str` from `rustc_codegen_llvm`) Failed merges: - rust-lang#125310 (Move ~100 tests from tests/ui to subdirs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 21, 2024
Rollup merge of rust-lang#125333 - hermit-os:fuse, r=workingjubilee switch to the default implementation of `write_vectored` HermitOS doesn't support write_vectored and switch to the default implementation of `write_vectored`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HermitOS doesn't support write_vectored and switch to the default implementation of
write_vectored.