Uplift {Closure,Coroutine,CoroutineClosure}Args and friends to rustc_type_ir#125775
Merged
bors merged 2 commits intorust-lang:masterfrom Jun 1, 2024
Merged
Uplift {Closure,Coroutine,CoroutineClosure}Args and friends to rustc_type_ir#125775bors merged 2 commits intorust-lang:masterfrom
{Closure,Coroutine,CoroutineClosure}Args and friends to rustc_type_ir#125775bors merged 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt changes to the core type system |
This comment has been minimized.
This comment has been minimized.
lcnr
reviewed
May 30, 2024
| } | ||
| } | ||
|
|
||
| struct FoldEscapingRegions<I: Interner> { |
Contributor
There was a problem hiding this comment.
existing: i feel like this folder should have a comment
compiler-errors
force-pushed
the
uplift-closure-args
branch
from
7c3ab75 to
fe42b73
Compare
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
uplift-closure-args
branch
from
fe42b73 to
822bfe8
Compare
Collaborator
|
Some changes occurred in compiler/rustc_codegen_gcc |
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
uplift-closure-args
branch
from
822bfe8 to
5afdda1
Compare
Contributor
Author
|
Sorry for the CI failures. Tried to be smart with an assertion, but it was misguided. @bors r=lcnr |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 1, 2024
…s, r=lcnr
Uplift `{Closure,Coroutine,CoroutineClosure}Args` and friends to `rustc_type_ir`
Part of converting the new solver's `structural_traits.rs` to be interner-agnostic.
I decided against aliasing `ClosureArgs<TyCtxt<'tcx>>` to `ClosureArgs<'tcx>` because it seemed so rare. I could do so if desired, though.
r? lcnr
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 1, 2024
…s, r=lcnr
Uplift `{Closure,Coroutine,CoroutineClosure}Args` and friends to `rustc_type_ir`
Part of converting the new solver's `structural_traits.rs` to be interner-agnostic.
I decided against aliasing `ClosureArgs<TyCtxt<'tcx>>` to `ClosureArgs<'tcx>` because it seemed so rare. I could do so if desired, though.
r? lcnr
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
intra doc links :( @bors r- |
bors
added
S-waiting-on-author
compiler-errors
force-pushed
the
uplift-closure-args
branch
from
5afdda1 to
333458c
Compare
Contributor
Author
|
@bors r=lcnr |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (0038c02): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 3.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 668.545s -> 667.702s (-0.13%) |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 13, 2024
… r=lcnr
Uplift `{Closure,Coroutine,CoroutineClosure}Args` and friends to `rustc_type_ir`
Part of converting the new solver's `structural_traits.rs` to be interner-agnostic.
I decided against aliasing `ClosureArgs<TyCtxt<'tcx>>` to `ClosureArgs<'tcx>` because it seemed so rare. I could do so if desired, though.
r? lcnr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of converting the new solver's
structural_traits.rsto be interner-agnostic.I decided against aliasing
ClosureArgs<TyCtxt<'tcx>>toClosureArgs<'tcx>because it seemed so rare. I could do so if desired, though.r? lcnr