Fix FormattingOptions instantiation with Default
#135977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
nyurik
force-pushed
the
fix-fmt-options
branch
from
0fc0807 to
497a28b
Compare
The `fill` value by default should be set to `' '` (space), but the current implementation uses `#[derive(Default)]` which sets it to `\0`
nyurik
force-pushed
the
fix-fmt-options
branch
from
497a28b to
c9ae0bb
Compare
Member
afaik we generally don't backport changes that only affect unstable APIs, since they're intended to only work on nightly, not beta or stable. If this fixes some stable API then that's a different story. |
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
Contributor
|
@nyurik Thanks, nice catch! |
12 tasks
Contributor
Author
|
"There is (now) a lint for that" (tm) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fillvalue by default should be set to' '(space), but the current implementation uses#[derive(Default)]which sets it to\0.Note that
FormattingOptionsis being released as part of 1.85 (unstable) - so this might warrant a backport to that branch.Tracking issue: #118117
Follow up from #118159
CC: @EliasHolzmann @programmerjake
r? @m-ou-se