use target compiler on llvm-bitcode-linker#138148
Conversation
The build compiler is already resolved inside the `ToolBuild` step, so we should pass only the target compilers for `Mode::ToolRustc` tools. Signed-off-by: onur-ozkan <work@onurozkan.dev>
|
Some changes occurred in src/tools/opt-dist cc @Kobzol |
|
@bors try |
…=<try> use target compiler on llvm-bitcode-linker The build compiler is already resolved inside the `ToolBuild` step, so we should pass only the target compilers for `Mode::ToolRustc` tools. Fixes rust-lang#138123 r? ghost try-job: dist-powerpc64le-linux
|
I don't know if you saw my message in the previous PR, but you don't have to modify opt-dist for this 😆 It's not even executed for the powerpc job. |
|
☀️ Try build successful - checks-actions |
f881d7d to
4227055
Compare
|
We are back to ~2h45m duration with this change. @rustbot ready r? bootstrap |
jieyouxu
left a comment
There was a problem hiding this comment.
Thanks, r=me after PR CI is green.
|
@bors r=jieyouxu p=1 |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (c53af1c): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -2.6%, secondary -5.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 2.8%, secondary 1.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 766.551s -> 765.734s (-0.11%) |

The build compiler is already resolved inside the
ToolBuildstep, so we should pass only the target compilers forMode::ToolRustctools.Fixes #138123
r? ghost
try-job: dist-powerpc64le-linux