Skip to content

Require generic params for const generic params#142449

Merged
bors merged 1 commit intorust-lang:masterfrom
oli-obk:missing-mgca-args
Jun 14, 2025
Merged

Require generic params for const generic params#142449
bors merged 1 commit intorust-lang:masterfrom
oli-obk:missing-mgca-args

Conversation

@oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jun 13, 2025 •
edited by rustbot
Loading

I think that was just an oversight when the support for them was added

r? @BoxyUwU or @camelid

fixes #137188
fixes #138166
fixes #138240
fixes #138266
fixes #138359

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 13, 2025

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@oli-obk oli-obk mentioned this pull request Jun 13, 2025
Merged
@BoxyUwU
Copy link
Member

BoxyUwU commented Jun 13, 2025

gamer+ rollup

@bors
Copy link
Collaborator

bors commented Jun 13, 2025

📌 Commit bb2b765 has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2025
@workingjubilee workingjubilee mentioned this pull request Jun 14, 2025
Merged
bors added a commit that referenced this pull request Jun 14, 2025
@bors
Auto merge of #142483 - workingjubilee:rollup-8qnhueh, r=workingjubilee
64033a4 
Rollup of 16 pull requests

Successful merges:

 - #140969 (Allow initializing logger with additional tracing Layer)
 - #141352 (builtin dyn impl no guide inference)
 - #142046 (add Vec::peek_mut)
 - #142273 (tests: Minicore `extern "gpu-kernel"` feature test)
 - #142302 (Rework how the disallowed qualifier in function type diagnostics are generated)
 - #142405 (Don't hardcode the intrinsic return types twice in the compiler)
 - #142434 ( Pre-install JS dependencies in tidy Dockerfile)
 - #142439 (doc: mention that intrinsics should not be called in user code)
 - #142441 (Delay replacing escaping bound vars in `FindParamInClause`)
 - #142449 (Require generic params for const generic params)
 - #142452 (Remove "intermittent" wording from `ReadDir`)
 - #142459 (Remove output helper bootstrap)
 - #142460 (cleanup search graph impl)
 - #142461 (compiletest: Clarify that `--no-capture` is needed with `--verbose`)
 - #142475 (Add platform support docs & maintainers for *-windows-msvc)
 - #142480 (tests: Convert two handwritten minicores to add-core-stubs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4d1ded8 into rust-lang:master Jun 14, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 14, 2025
rust-timer added a commit that referenced this pull request Jun 14, 2025
@rust-timer
Unrolled build for #142449
b6df966 
Rollup merge of #142449 - oli-obk:missing-mgca-args, r=BoxyUwU

Require generic params for const generic params

I think that was just an oversight when the support for them was added

r? `@BoxyUwU` or `@camelid`

fixes #137188
fixes #138166
fixes #138240
fixes #138266
fixes #138359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BoxyUwU BoxyUwU

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.89.0

4 participants

@oli-obk @rustbot @BoxyUwU @bors

Comments