Make config method invoke inside parse use dwn_ctx#145149
Merged
bors merged 9 commits intorust-lang:masterfrom Aug 11, 2025
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
This PR modifies If appropriate, please update This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. |
Shourya742
changed the title
Shourya742
changed the title
Kobzol
reviewed
Aug 9, 2025
Member
Kobzol
left a comment
Kobzol
left a comment
There was a problem hiding this comment.
download_ci_rustc_commit, parse_download_ci_llvm and ci_env methods on Config are unused, you can remove them for now.
Member
|
Thank you! @bors r+ rollup=iffy |
Collaborator
bors
added
S-waiting-on-bors
samueltardieu
added a commit
to samueltardieu/rust
that referenced
this pull request
Aug 10, 2025
…ig-method-invoke-inside-parse-functions, r=Kobzol Make config method invoke inside parse use dwn_ctx This PR is part of a series of config refactorings. It removes calls from config methods to solid functions defined in `config.rs`. After this, we will remove the default dependencies in the config. r? `@Kobzol`
bors
added a commit
that referenced
this pull request
Aug 10, 2025
Rollup of 3 pull requests Successful merges: - #135846 (Detect struct construction with private field in field with default) - #144558 (Point at the `Fn()` or `FnMut()` bound that coerced a closure, which caused a move error) - #145149 (Make config method invoke inside parse use dwn_ctx) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Aug 11, 2025
Rollup of 7 pull requests Successful merges: - #143949 (Constify remaining traits/impls for `const_ops`) - #144330 (document assumptions about `Clone` and `Eq` traits) - #144350 (std: sys: io: io_slice: Add UEFI types) - #144558 (Point at the `Fn()` or `FnMut()` bound that coerced a closure, which caused a move error) - #145149 (Make config method invoke inside parse use dwn_ctx) - #145227 (Tweak spans providing type context on errors when involving macros) - #145228 (Remove unnecessary parentheses in `assert!`s) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Aug 11, 2025
Rollup merge of #145149 - Shourya742:2025-07-08-convert-config-method-invoke-inside-parse-functions, r=Kobzol Make config method invoke inside parse use dwn_ctx This PR is part of a series of config refactorings. It removes calls from config methods to solid functions defined in `config.rs`. After this, we will remove the default dependencies in the config. r? ```@Kobzol```
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 12, 2025
bootstrap: Only warn about `rust.debug-assertions` if downloading rustc The changes in rust-lang#145149 had the unwanted side-effect of causing bootstrap to *always* warn about `rust.debug-assertions = true`, even if rustc isn't going to be downloaded anyway. cc `@Shourya742` `@Kobzol`
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 12, 2025
bootstrap: Only warn about `rust.debug-assertions` if downloading rustc The changes in rust-lang#145149 had the unwanted side-effect of causing bootstrap to *always* warn about `rust.debug-assertions = true`, even if rustc isn't going to be downloaded anyway. cc ``@Shourya742`` ``@Kobzol``
rust-timer
added a commit
that referenced
this pull request
Aug 12, 2025
Rollup merge of #145291 - Zalathar:no-warning, r=Kobzol bootstrap: Only warn about `rust.debug-assertions` if downloading rustc The changes in #145149 had the unwanted side-effect of causing bootstrap to *always* warn about `rust.debug-assertions = true`, even if rustc isn't going to be downloaded anyway. cc ``@Shourya742`` ``@Kobzol``
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Aug 13, 2025
bootstrap: Only warn about `rust.debug-assertions` if downloading rustc The changes in rust-lang/rust#145149 had the unwanted side-effect of causing bootstrap to *always* warn about `rust.debug-assertions = true`, even if rustc isn't going to be downloaded anyway. cc ``@Shourya742`` ``@Kobzol``
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Aug 18, 2025
bootstrap: Only warn about `rust.debug-assertions` if downloading rustc The changes in rust-lang/rust#145149 had the unwanted side-effect of causing bootstrap to *always* warn about `rust.debug-assertions = true`, even if rustc isn't going to be downloaded anyway. cc ``@Shourya742`` ``@Kobzol``
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a series of config refactorings. It removes calls from config methods to solid functions defined in
config.rs. After this, we will remove the default dependencies in the config.r? @Kobzol