Allow cross-compiling the Cranelift dist component#145320
Merged
bors merged 1 commit intorust-lang:masterfrom Aug 13, 2025
Merged
Allow cross-compiling the Cranelift dist component#145320bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
rustbot has assigned @albertlarsan68. Use |
rustbot
added
S-waiting-on-review
Member
Author
|
r? @jieyouxu |
Collaborator
|
|
shepmaster
approved these changes
Aug 12, 2025
Member
shepmaster
left a comment
shepmaster
left a comment
There was a problem hiding this comment.
The changes make sense to me (as a bootstrap rookie), but more importantly using this patch locally appears to allow me to cross-compile the dist artifacts.
Member
|
It is surprising that rustfmt didn't complain about missing commas on the new fields though. |
Member
Author
|
I think it's because it's in a macro. |
shepmaster
added
the
beta-nominated
Member
|
Preemptively beta-nominating this as #145252 is also for beta. |
Member
Author
|
@bors r=shepmaster rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 13, 2025
Rollup of 11 pull requests Successful merges: - #143467 (Add ASCII-related methods from `u8` and `MIN`/`MAX` to `core::ascii::Char`) - #144519 (Constify `SystemTime` methods) - #144642 (editorconfig: don't trim trailing whitespace in tests) - #144870 (Stabilize `path_file_prefix` feature) - #145269 (Deprecate RUST_TEST_* env variables) - #145274 (Remove unused `#[must_use]`) - #145289 (chore(ci): upgrade checkout to v5) - #145303 (Docs: Link to payload_as_str() from payload().) - #145308 (Adjust documentation of `dangling`) - #145320 (Allow cross-compiling the Cranelift dist component) - #145325 (Add `cast_init` and `cast_uninit` methods for pointers) r? `@ghost` `@rustbot` modify labels: rollup
Member
cg_clif shouldn't be built for beta at all. |
rust-timer
added a commit
that referenced
this pull request
Aug 13, 2025
Rollup merge of #145320 - Kobzol:fix-cranelift-codegen-dist, r=shepmaster Allow cross-compiling the Cranelift dist component Should help unblock #145252 (https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/macos-13.20shutting.20down/with/534032174).
jieyouxu
removed
the
beta-nominated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should help unblock #145252 (https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/macos-13.20shutting.20down/with/534032174).