Stop calling unwrap when format foreign has trailing dollar#145905
Merged
bors merged 2 commits intorust-lang:masterfrom Aug 27, 2025
Merged
Stop calling unwrap when format foreign has trailing dollar#145905bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
Collaborator
|
r? @nnethercote rustbot has assigned @nnethercote. Use |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
nnethercote
reviewed
Aug 26, 2025
| @@ -0,0 +1,4 @@ | |||
| fn main() { | |||
Contributor
There was a problem hiding this comment.
Add a comment here saying that this was issue #137580, then remove the old crashtest, and then r=me.
Collaborator
|
This PR changes a file inside |
Member
Author
|
@bors r=nnethercote |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 27, 2025
Rollup of 6 pull requests Successful merges: - #144274 (add Option::reduce) - #145562 (Simplify macro generating ToString implementations for `&…&str`) - #145625 (improve float to_degrees/to_radians rounding comments and impl) - #145740 (Introduce a `[workspace.dependencies`] section in the top-level `Cargo.toml`) - #145885 (Inherit TCC in debuginfo tests on macOS) - #145905 (Stop calling unwrap when format foreign has trailing dollar) r? `@ghost` `@rustbot` modify labels: rollup
rust-cloud-vms bot
pushed a commit
to makai410/rustc_public
that referenced
this pull request
Oct 12, 2025
Rollup of 6 pull requests Successful merges: - rust-lang/rust#144274 (add Option::reduce) - rust-lang/rust#145562 (Simplify macro generating ToString implementations for `&…&str`) - rust-lang/rust#145625 (improve float to_degrees/to_radians rounding comments and impl) - rust-lang/rust#145740 (Introduce a `[workspace.dependencies`] section in the top-level `Cargo.toml`) - rust-lang/rust#145885 (Inherit TCC in debuginfo tests on macOS) - rust-lang/rust#145905 (Stop calling unwrap when format foreign has trailing dollar) r? `@ghost` `@rustbot` modify labels: rollup
makai410
pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
Stop calling unwrap when format foreign has trailing dollar Fixes rust-lang#137580
makai410
pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#144274 (add Option::reduce) - rust-lang#145562 (Simplify macro generating ToString implementations for `&…&str`) - rust-lang#145625 (improve float to_degrees/to_radians rounding comments and impl) - rust-lang#145740 (Introduce a `[workspace.dependencies`] section in the top-level `Cargo.toml`) - rust-lang#145885 (Inherit TCC in debuginfo tests on macOS) - rust-lang#145905 (Stop calling unwrap when format foreign has trailing dollar) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #137580