Optimize Cargo with LTO

[Kobzol]

This optimization was "lost" when Cargo was switched away from a ToolRustcPrivate to a ToolTarget tool.

r? @jieyouxu

[weihanglo]

how did you notice the optimization is gone?

[jieyouxu]

Thanks

View changes since this review

[jieyouxu]

@bors r+ rollup=never

[bors]

📌 Commit edb92a3 has been approved by jieyouxu

It is now in the queue for this repository.

[Kobzol]

how did you notice the optimization is gone?

By revisiting the Cargo issue and remembering that I changed the Mode of Cargo recently 😅

[bors]

⌛ Testing commit edb92a3 with merge 0d0f4ea...

[bors]

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 0d0f4ea to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 397f933 (parent) -> 0d0f4ea (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 0d0f4eac8b98133e5da6d3604d86a8f3b5a67844 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. dist-aarch64-linux: 6098.5s -> 8298.5s (36.1%)
2. dist-aarch64-apple: 10944.8s -> 8201.1s (-25.1%)
3. aarch64-gnu: 6291.7s -> 6956.8s (10.6%)
4. dist-x86_64-solaris: 5469.5s -> 5042.1s (-7.8%)
5. dist-apple-various: 3863.6s -> 4152.6s (7.5%)
6. dist-various-1: 4146.6s -> 3868.5s (-6.7%)
7. test-various: 4316.9s -> 4595.2s (6.4%)
8. dist-aarch64-msvc: 6090.9s -> 5716.3s (-6.1%)
9. dist-various-2: 2243.8s -> 2105.9s (-6.1%)
10. dist-s390x-linux: 5246.1s -> 4953.4s (-5.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (0d0f4ea): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 7.0%, secondary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	7.0%	[7.0%, 7.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-2.5%, -2.5%]	1
All ❌✅ (primary)	7.0%	[7.0%, 7.0%]	1

Cycles

Results (primary 1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.9%, 2.0%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.9%	[1.9%, 2.0%]	2

Binary size

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 467.607s -> 469.522s (0.41%)
Artifact size: 390.55 MiB -> 390.39 MiB (-0.04%)