Skip to content

add SliceIndex wrapper types Last and Clamp<Idx>#146260

Merged
bors merged 1 commit intorust-lang:masterfrom
Qelxiros:146179-sliceindex-wrappers
Nov 3, 2025
Merged

add SliceIndex wrapper types Last and Clamp<Idx>#146260
bors merged 1 commit intorust-lang:masterfrom
Qelxiros:146179-sliceindex-wrappers

Conversation

@Qelxiros
Copy link
Contributor

@Qelxiros Qelxiros commented Sep 6, 2025 •
edited by rustbot
Loading

Tracking issue: #146179

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 6, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Qelxiros Qelxiros force-pushed the 146179-sliceindex-wrappers branch 3 times, most recently from 17736fe to dda0188 Compare September 10, 2025 18:52
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Qelxiros Qelxiros force-pushed the 146179-sliceindex-wrappers branch from dda0188 to f847205 Compare September 10, 2025 19:41
@Qelxiros Qelxiros marked this pull request as ready for review September 10, 2025 21:35
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 10, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 10, 2025

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Qelxiros Qelxiros mentioned this pull request Sep 11, 2025
Open
3 tasks
jhpratt
jhpratt reviewed Sep 13, 2025
View reviewed changes
@jhpratt
Copy link
Member

jhpratt commented Sep 13, 2025

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 13, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@Qelxiros Qelxiros force-pushed the 146179-sliceindex-wrappers branch from f847205 to 42bf2f8 Compare September 14, 2025 16:50
@Qelxiros
Copy link
Contributor Author

Qelxiros commented Sep 14, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 14, 2025
jhpratt
jhpratt reviewed Sep 15, 2025
View reviewed changes
Copy link
Member

@jhpratt jhpratt left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Would you mind adding a couple tests (beyond the doctests) that ensure the behavior works as expected? It should afaict, but tests are always nice :)

View changes since this review

library/core/src/slice/index.rs Outdated
Copy link
Member

@jhpratt jhpratt Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
impl<T> Sealed for crate::index::Clamp<T> {}
impl<T> Sealed for crate::index::Clamp<T> where T: Sealed {}

to avoid potentially leaking an implementation detail down the road

@Qelxiros Qelxiros force-pushed the 146179-sliceindex-wrappers branch 3 times, most recently from 5127f26 to 5381f1e Compare September 15, 2025 18:47
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Qelxiros
Copy link
Contributor Author

Qelxiros commented Sep 15, 2025

looks like https://auth.docker.io/token is 500ing, causing the CI to fail

@Qelxiros Qelxiros force-pushed the 146179-sliceindex-wrappers branch from 5381f1e to 214e7b0 Compare September 15, 2025 19:10
@rustbot
Copy link
Collaborator

rustbot commented Sep 15, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Qelxiros Qelxiros force-pushed the 146179-sliceindex-wrappers branch from 214e7b0 to 78d8ce7 Compare September 15, 2025 19:25
@Qelxiros
Copy link
Contributor Author

Qelxiros commented Nov 3, 2025

@jhpratt have you had a chance to review this?

@jhpratt
Copy link
Member

jhpratt commented Nov 3, 2025

Completely forgot about it as I was quite busy at that point in time. I'll take a look right now.

@jhpratt
Copy link
Member

jhpratt commented Nov 3, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 3, 2025

📌 Commit 78d8ce7 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 3, 2025
Merged
bors added a commit that referenced this pull request Nov 3, 2025
@bors
Auto merge of #148425 - matthiaskrgr:rollup-pwibmxt, r=matthiaskrgr
f2bae99 
Rollup of 3 pull requests

Successful merges:

 - #146260 (add SliceIndex wrapper types Last and Clamp<Idx>)
 - #148394 (Make explicit that `TypeId`'s layout and size are unstable)
 - #148402 (stdarch subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 01ab3e3 into rust-lang:master Nov 3, 2025
10 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 3, 2025
rust-timer added a commit that referenced this pull request Nov 3, 2025
@rust-timer
Unrolled build for #146260
0bf670d 
Rollup merge of #146260 - Qelxiros:146179-sliceindex-wrappers, r=jhpratt

add SliceIndex wrapper types Last and Clamp<Idx>

Tracking issue: #146179
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Nov 4, 2025
@bors
Auto merge of #148425 - matthiaskrgr:rollup-pwibmxt, r=matthiaskrgr
3056bf7 
Rollup of 3 pull requests

Successful merges:

 - rust-lang/rust#146260 (add SliceIndex wrapper types Last and Clamp<Idx>)
 - rust-lang/rust#148394 (Make explicit that `TypeId`'s layout and size are unstable)
 - rust-lang/rust#148402 (stdarch subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/stdarch that referenced this pull request Nov 10, 2025
@bors
Auto merge of #148425 - matthiaskrgr:rollup-pwibmxt, r=matthiaskrgr
2796343 
Rollup of 3 pull requests

Successful merges:

 - rust-lang/rust#146260 (add SliceIndex wrapper types Last and Clamp<Idx>)
 - rust-lang/rust#148394 (Make explicit that `TypeId`'s layout and size are unstable)
 - rust-lang/rust#148402 (stdarch subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
@matthiaskrgr
Rollup merge of rust-lang#146260 - Qelxiros:146179-sliceindex-wrapper…
776d7a3 
…s, r=jhpratt

add SliceIndex wrapper types Last and Clamp<Idx>

Tracking issue: rust-lang#146179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhpratt jhpratt jhpratt left review comments

Assignees

@jhpratt jhpratt

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Qelxiros @rust-log-analyzer @rustbot @jhpratt @bors

Comments