Skip to content

Don't strip shebang in expr-ctxt include!(…)#146377

Merged
bors merged 1 commit intorust-lang:mainfrom
fmease:no-incl-shebang-expr
Dec 22, 2025
Merged

Don't strip shebang in expr-ctxt include!(…)#146377
bors merged 1 commit intorust-lang:mainfrom
fmease:no-incl-shebang-expr

Conversation

@fmease
Copy link
Member

@fmease fmease commented Sep 9, 2025 •
edited
Loading

No longer strip shebang interpreter directives in files that were included in expression (statement) contexts.

@fmease fmease added T-lang Relevant to the language team S-waiting-on-team S-blocked Status: Blocked on something else such as an RFC or other implementation work. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. labels Sep 9, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. labels Sep 9, 2025
@fmease fmease changed the title [STACKED] Don't strip shebang in expr-ctxt include!(…)s [STACKED] Don't strip shebang in expr-ctxt include!(…) Sep 9, 2025
@fmease fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 9, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@fmease fmease force-pushed the no-incl-shebang-expr branch from c611f6f to 3685183 Compare September 9, 2025 18:10
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@fmease fmease force-pushed the no-incl-shebang-expr branch from 3685183 to 77cd6d1 Compare September 9, 2025 18:27
@fmease fmease mentioned this pull request Oct 23, 2025
Open
10 tasks
@traviscross traviscross added the I-lang-radar Items that are on lang's radar and will need eventual work or consideration. label Oct 23, 2025
@fmease fmease force-pushed the no-incl-shebang-expr branch from 77cd6d1 to e8ef799 Compare November 25, 2025 23:59
@fmease fmease changed the title [STACKED] Don't strip shebang in expr-ctxt include!(…) Don't strip shebang in expr-ctxt include!(…) Nov 25, 2025
@fmease fmease added needs-crater This change needs a crater run to check for possible breakage in the ecosystem. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Nov 26, 2025
@fmease fmease force-pushed the no-incl-shebang-expr branch from e8ef799 to e477732 Compare November 26, 2025 03:58
@fmease fmease added I-lang-nominated Nominated for discussion during a lang team meeting. S-waiting-on-t-lang Status: Awaiting decision from T-lang and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 26, 2025
@fmease fmease marked this pull request as ready for review November 26, 2025 03:58
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 26, 2025
@fmease fmease removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 26, 2025
@rustbot rustbot mentioned this pull request Dec 20, 2025
Open
Urgau
Urgau approved these changes Dec 20, 2025
View reviewed changes
Copy link
Member

@Urgau Urgau left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good to me.

View changes since this review

@Urgau
Copy link
Member

Urgau commented Dec 20, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 20, 2025

📌 Commit e477732 has been approved by Urgau

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Dec 21, 2025
@Zalathar
Rollup merge of rust-lang#146377 - fmease:no-incl-shebang-expr, r=Urgau
d2f9640 
Don't strip shebang in expr-ctxt `include!(…)`

No longer strip shebang interpreter directives in files that were `include`d in expression (statement) contexts.
@Zalathar Zalathar mentioned this pull request Dec 21, 2025
Closed
bors added a commit that referenced this pull request Dec 21, 2025
@bors
Auto merge of #150219 - Zalathar:rollup-xn9ja2x, r=Zalathar
e7511a7 
Rollup of 13 pull requests

Successful merges:

 - #146377 (Don't strip shebang in expr-ctxt `include!(…)`)
 - #149437 (Fix trailing newline in JUnit formatter)
 - #149658 (tests/assembly-llvm/some-non-zero-from-atomic-optimization.rs: New test)
 - #149812 (Add const default for OnceCell and OnceLock)
 - #149882 (miri: add -Zbinary-dep-depinfo to dependency builds)
 - #150009 (Enable llvm-libunwind by default for Hexagon targets)
 - #150035 (fix docustring on fetch_or)
 - #150082 (tests/ui/traits/fmt-pointer-trait.rs: Add HRTB fn pointer case)
 - #150160 (Fix ICE (#149980) for invalid EII in statement position)
 - #150184 (mir_build: Use the same length type for `TestableCase::Slice` and `TestKind::Len`)
 - #150191 (change non-canonical clone impl to {*self}, fix some doc comments)
 - #150203 (Drop the From derive macro from the v1 prelude)
 - #150208 (Update books)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 21, 2025
@matthiaskrgr
Rollup merge of rust-lang#146377 - fmease:no-incl-shebang-expr, r=Urgau
277362e 
Don't strip shebang in expr-ctxt `include!(…)`

No longer strip shebang interpreter directives in files that were `include`d in expression (statement) contexts.
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 21, 2025
Closed
bors added a commit that referenced this pull request Dec 21, 2025
@bors
Auto merge of #150220 - matthiaskrgr:rollup-2mxj7j6, r=matthiaskrgr
89c3a84 
Rollup of 11 pull requests

Successful merges:

 - #146377 (Don't strip shebang in expr-ctxt `include!(…)`)
 - #149658 (tests/assembly-llvm/some-non-zero-from-atomic-optimization.rs: New test)
 - #149812 (Add const default for OnceCell and OnceLock)
 - #149882 (miri: add -Zbinary-dep-depinfo to dependency builds)
 - #150009 (Enable llvm-libunwind by default for Hexagon targets)
 - #150035 (fix docustring on fetch_or)
 - #150082 (tests/ui/traits/fmt-pointer-trait.rs: Add HRTB fn pointer case)
 - #150160 (Fix ICE (#149980) for invalid EII in statement position)
 - #150184 (mir_build: Use the same length type for `TestableCase::Slice` and `TestKind::Len`)
 - #150191 (change non-canonical clone impl to {*self}, fix some doc comments)
 - #150203 (Drop the From derive macro from the v1 prelude)

r? `@ghost`
`@rustbot` modify labels: rollup
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Dec 21, 2025
@JonathanBrouwer
Rollup merge of rust-lang#146377 - fmease:no-incl-shebang-expr, r=Urgau
9345c26 
Don't strip shebang in expr-ctxt `include!(…)`

No longer strip shebang interpreter directives in files that were `include`d in expression (statement) contexts.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 21, 2025
Closed
bors added a commit that referenced this pull request Dec 21, 2025
@bors
Auto merge of #150224 - JonathanBrouwer:rollup-rt56ux6, r=JonathanBro…
800bb47 
…uwer

Rollup of 13 pull requests

Successful merges:

 - #146377 (Don't strip shebang in expr-ctxt `include!(…)`)
 - #149812 (Add const default for OnceCell and OnceLock)
 - #149882 (miri: add -Zbinary-dep-depinfo to dependency builds)
 - #150009 (Enable llvm-libunwind by default for Hexagon targets)
 - #150035 (fix docustring on fetch_or)
 - #150082 (tests/ui/traits/fmt-pointer-trait.rs: Add HRTB fn pointer case)
 - #150160 (Fix ICE (#149980) for invalid EII in statement position)
 - #150184 (mir_build: Use the same length type for `TestableCase::Slice` and `TestKind::Len`)
 - #150185 ([rustdoc] Add missing close tags in extern crate reexports)
 - #150191 (change non-canonical clone impl to {*self}, fix some doc comments)
 - #150203 (Drop the From derive macro from the v1 prelude)
 - #150208 (Update books)
 - #150210 (tests/debuginfo/function-arg-initialization.rs: Stop disabling SingleUseConsts MIR pass)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 21, 2025
Merged
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Dec 21, 2025
@JonathanBrouwer
Rollup merge of rust-lang#146377 - fmease:no-incl-shebang-expr, r=Urgau
e5b8188 
Don't strip shebang in expr-ctxt `include!(…)`

No longer strip shebang interpreter directives in files that were `include`d in expression (statement) contexts.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 21, 2025
Closed
bors added a commit that referenced this pull request Dec 21, 2025
@bors
Auto merge of #150228 - matthiaskrgr:rollup-ymp54q0, r=matthiaskrgr
542c040 
Rollup of 11 pull requests

Successful merges:

 - #146377 (Don't strip shebang in expr-ctxt `include!(…)`)
 - #149812 (Add const default for OnceCell and OnceLock)
 - #149882 (miri: add -Zbinary-dep-depinfo to dependency builds)
 - #150009 (Enable llvm-libunwind by default for Hexagon targets)
 - #150035 (fix docustring on fetch_or)
 - #150082 (tests/ui/traits/fmt-pointer-trait.rs: Add HRTB fn pointer case)
 - #150160 (Fix ICE (#149980) for invalid EII in statement position)
 - #150184 (mir_build: Use the same length type for `TestableCase::Slice` and `TestKind::Len`)
 - #150185 ([rustdoc] Add missing close tags in extern crate reexports)
 - #150191 (change non-canonical clone impl to {*self}, fix some doc comments)
 - #150203 (Drop the From derive macro from the v1 prelude)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Dec 22, 2025
@bors
Auto merge of #150228 - matthiaskrgr:rollup-ymp54q0, r=matthiaskrgr
acfd264 
Rollup of 11 pull requests

Successful merges:

 - #146377 (Don't strip shebang in expr-ctxt `include!(…)`)
 - #149812 (Add const default for OnceCell and OnceLock)
 - #149882 (miri: add -Zbinary-dep-depinfo to dependency builds)
 - #150009 (Enable llvm-libunwind by default for Hexagon targets)
 - #150035 (fix docustring on fetch_or)
 - #150082 (tests/ui/traits/fmt-pointer-trait.rs: Add HRTB fn pointer case)
 - #150160 (Fix ICE (#149980) for invalid EII in statement position)
 - #150184 (mir_build: Use the same length type for `TestableCase::Slice` and `TestKind::Len`)
 - #150185 ([rustdoc] Add missing close tags in extern crate reexports)
 - #150191 (change non-canonical clone impl to {*self}, fix some doc comments)
 - #150203 (Drop the From derive macro from the v1 prelude)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d1cf7f8 into rust-lang:main Dec 22, 2025
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 22, 2025
rust-timer added a commit that referenced this pull request Dec 22, 2025
@rust-timer
Unrolled build for #146377
e4a2539 
Rollup merge of #146377 - fmease:no-incl-shebang-expr, r=Urgau

Don't strip shebang in expr-ctxt `include!(…)`

No longer strip shebang interpreter directives in files that were `include`d in expression (statement) contexts.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Dec 23, 2025
@bors
Auto merge of #150228 - matthiaskrgr:rollup-ymp54q0, r=matthiaskrgr
ee8382a 
Rollup of 11 pull requests

Successful merges:

 - rust-lang/rust#146377 (Don't strip shebang in expr-ctxt `include!(…)`)
 - rust-lang/rust#149812 (Add const default for OnceCell and OnceLock)
 - rust-lang/rust#149882 (miri: add -Zbinary-dep-depinfo to dependency builds)
 - rust-lang/rust#150009 (Enable llvm-libunwind by default for Hexagon targets)
 - rust-lang/rust#150035 (fix docustring on fetch_or)
 - rust-lang/rust#150082 (tests/ui/traits/fmt-pointer-trait.rs: Add HRTB fn pointer case)
 - rust-lang/rust#150160 (Fix ICE (rust-lang/rust#149980) for invalid EII in statement position)
 - rust-lang/rust#150184 (mir_build: Use the same length type for `TestableCase::Slice` and `TestKind::Len`)
 - rust-lang/rust#150185 ([rustdoc] Add missing close tags in extern crate reexports)
 - rust-lang/rust#150191 (change non-canonical clone impl to {*self}, fix some doc comments)
 - rust-lang/rust#150203 (Drop the From derive macro from the v1 prelude)

r? `@ghost`
`@rustbot` modify labels: rollup
@github-actions github-actions bot mentioned this pull request Dec 23, 2025
Open
@fmease fmease deleted the no-incl-shebang-expr branch December 28, 2025 16:36
@fmease fmease mentioned this pull request Dec 28, 2025
Merged
ehuss added a commit to ehuss/reference that referenced this pull request Jan 3, 2026
@ehuss
Update include! macro behavior with item/expression context
5f25430 
This updates the note about the include! macro to cover the changes in
rust-lang/rust#146377 where it no longer does
shebang removal in expression/statement contexts.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jan 25, 2026
Open
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Urgau Urgau Urgau approved these changes

Assignees

@Urgau Urgau

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. I-lang-radar Items that are on lang's radar and will need eventual work or consideration. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-lang Relevant to the language team T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.