Skip to content

constify {float}::total_cmp()#146818

Merged
bors merged 1 commit intorust-lang:masterfrom
npmccallum:total_cmp
Sep 24, 2025
Merged

constify {float}::total_cmp()#146818
bors merged 1 commit intorust-lang:masterfrom
npmccallum:total_cmp

Conversation

@npmccallum
Copy link
Contributor

@npmccallum npmccallum commented Sep 20, 2025

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 20, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 20, 2025
joshtriplett
joshtriplett reviewed Sep 21, 2025
View reviewed changes
@npmccallum npmccallum mentioned this pull request Sep 21, 2025
Open
fee1-dead
fee1-dead requested changes Sep 22, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@fee1-dead
Copy link
Member

fee1-dead commented Sep 23, 2025

Thanks!
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 23, 2025

📌 Commit 5dde557 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 23, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 23, 2025
@matthiaskrgr
Rollup merge of rust-lang#146818 - npmccallum:total_cmp, r=fee1-dead
48a4393 
constify {float}::total_cmp()
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 23, 2025
Closed
bors added a commit that referenced this pull request Sep 23, 2025
@bors
Auto merge of #146943 - matthiaskrgr:rollup-oh3k78y, r=matthiaskrgr
357d59f 
Rollup of 8 pull requests

Successful merges:

 - #146818 (constify {float}::total_cmp())
 - #146896 (rustc-dev-guide subtree update)
 - #146898 (Update books)
 - #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered)
 - #146904 (#140368 Mutex/RwLock/ReentrantLock::data_ptr to be const fn)
 - #146907 (add regression test for issue 146537)
 - #146927 (Make it possible to `x install` Cranelift and LLVM bitcode linker)
 - #146931 (miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 23, 2025
Merged
bors added a commit that referenced this pull request Sep 24, 2025
@bors
Auto merge of #146946 - matthiaskrgr:rollup-fsmrqez, r=matthiaskrgr
2b403c4 
Rollup of 6 pull requests

Successful merges:

 - #146818 (constify {float}::total_cmp())
 - #146896 (rustc-dev-guide subtree update)
 - #146898 (Update books)
 - #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered)
 - #146904 (#140368 Mutex/RwLock/ReentrantLock::data_ptr to be const fn)
 - #146907 (add regression test for issue 146537)

r? `@ghost`
`@rustbot` modify labels: rollup
@Zalathar Zalathar mentioned this pull request Sep 24, 2025
Closed
bors added a commit that referenced this pull request Sep 24, 2025
@bors
Auto merge of #146946 - matthiaskrgr:rollup-fsmrqez, r=matthiaskrgr
4b9e564 
Rollup of 6 pull requests

Successful merges:

 - #146818 (constify {float}::total_cmp())
 - #146896 (rustc-dev-guide subtree update)
 - #146898 (Update books)
 - #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered)
 - #146904 (#140368 Mutex/RwLock/ReentrantLock::data_ptr to be const fn)
 - #146907 (add regression test for issue 146537)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Sep 24, 2025
@bors
Auto merge of #146946 - matthiaskrgr:rollup-fsmrqez, r=matthiaskrgr
e9385f9 
Rollup of 6 pull requests

Successful merges:

 - #146818 (constify {float}::total_cmp())
 - #146896 (rustc-dev-guide subtree update)
 - #146898 (Update books)
 - #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered)
 - #146904 (#140368 Mutex/RwLock/ReentrantLock::data_ptr to be const fn)
 - #146907 (add regression test for issue 146537)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c2e11d7 into rust-lang:master Sep 24, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 24, 2025
rust-timer added a commit that referenced this pull request Sep 24, 2025
@rust-timer
Unrolled build for #146818
9b77832 
Rollup merge of #146818 - npmccallum:total_cmp, r=fee1-dead

constify {float}::total_cmp()
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Sep 24, 2025
@matthiaskrgr @Muscraft
Rollup merge of rust-lang#146818 - npmccallum:total_cmp, r=fee1-dead
38304b8 
constify {float}::total_cmp()
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Sep 24, 2025
@bors @Muscraft
Auto merge of rust-lang#146946 - matthiaskrgr:rollup-fsmrqez, r=matth…
de893e2 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#146818 (constify {float}::total_cmp())
 - rust-lang#146896 (rustc-dev-guide subtree update)
 - rust-lang#146898 (Update books)
 - rust-lang#146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered)
 - rust-lang#146904 (rust-lang#140368 Mutex/RwLock/ReentrantLock::data_ptr to be const fn)
 - rust-lang#146907 (add regression test for issue 146537)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Sep 26, 2025
@bors
Auto merge of #146946 - matthiaskrgr:rollup-fsmrqez, r=matthiaskrgr
8059048 
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#146818 (constify {float}::total_cmp())
 - rust-lang/rust#146896 (rustc-dev-guide subtree update)
 - rust-lang/rust#146898 (Update books)
 - rust-lang/rust#146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered)
 - rust-lang/rust#146904 (rust-lang/rust#140368 Mutex/RwLock/ReentrantLock::data_ptr to be const fn)
 - rust-lang/rust#146907 (add regression test for issue 146537)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Oct 6, 2025
@bors
Auto merge of #146946 - matthiaskrgr:rollup-fsmrqez, r=matthiaskrgr
8ad9291 
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#146818 (constify {float}::total_cmp())
 - rust-lang/rust#146896 (rustc-dev-guide subtree update)
 - rust-lang/rust#146898 (Update books)
 - rust-lang/rust#146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered)
 - rust-lang/rust#146904 (rust-lang/rust#140368 Mutex/RwLock/ReentrantLock::data_ptr to be const fn)
 - rust-lang/rust#146907 (add regression test for issue 146537)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
@matthiaskrgr
Rollup merge of rust-lang#146818 - npmccallum:total_cmp, r=fee1-dead
37cca33 
constify {float}::total_cmp()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshtriplett joshtriplett joshtriplett left review comments

@fee1-dead fee1-dead fee1-dead requested changes

Assignees

@fee1-dead fee1-dead

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

5 participants

@npmccallum @rustbot @fee1-dead @bors @joshtriplett

Comments