Skip to content

std: sys::net cleanups#147190

Merged
bors merged 4 commits intorust-lang:masterfrom
joboet:sys-net-cleanup
Oct 4, 2025
Merged

std: sys::net cleanups#147190
bors merged 4 commits intorust-lang:masterfrom
joboet:sys-net-cleanup

Conversation

@joboet
Copy link
Member

@joboet joboet commented Sep 30, 2025

This PR contains three improvements to the socket-based networking implementation (aa1263e is just to add the now missing unsafe). Best reviewed commit-by-commit.

@rustbot rustbot added O-unix Operating system: Unix-like O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 30, 2025

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@joboet
Copy link
Member Author

joboet commented Sep 30, 2025

r? libs
You've been assigned so many of my PRs already...

@rustbot rustbot assigned tgross35 and unassigned ibraheemdev Sep 30, 2025
hkBst
hkBst reviewed Oct 1, 2025
View reviewed changes
library/std/src/sys/net/connection/socket/mod.rs
let mut len = size_of_val(&storage) as c::socklen_t;
let mut storage = MaybeUninit::<c::sockaddr_storage>::uninit();
let mut len = size_of::<c::sockaddr_storage>() as c::socklen_t;
let sock = self.inner.accept(storage.as_mut_ptr() as *mut _, &mut len)?;
Copy link
Member

@hkBst hkBst Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps add let storage = storage.assume_init() here?

hkBst
hkBst reviewed Oct 1, 2025
View reviewed changes
@tgross35
Copy link
Contributor

tgross35 commented Oct 3, 2025

@bors r=hkBst,tgross35

@bors
Copy link
Collaborator

bors commented Oct 3, 2025

📌 Commit 3534594 has been approved by hkBst,tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 4, 2025
@Zalathar
Rollup merge of rust-lang#147190 - joboet:sys-net-cleanup, r=hkBst,tg…
e273126 
…ross35

std: `sys::net` cleanups

This PR contains three improvements to the socket-based networking implementation (aa1263e is just to add the now missing `unsafe`). Best reviewed commit-by-commit.
@Zalathar Zalathar mentioned this pull request Oct 4, 2025
Closed
bors added a commit that referenced this pull request Oct 4, 2025
@bors
Auto merge of #147316 - Zalathar:rollup-ehwa64f, r=Zalathar
f29921f 
Rollup of 14 pull requests

Successful merges:

 - #142670 (Document fully-qualified syntax in `as`' keyword doc)
 - #144908 (Fix doctest output json)
 - #145685 (add CloneFromCell and Cell::get_cloned)
 - #146330 (Bump unicode_data and printables to version 17.0.0)
 - #146451 (Fix atan2 inaccuracy in documentation)
 - #146479 (add mem::conjure_zst)
 - #147190 (std: `sys::net` cleanups)
 - #147245 (only replace the intended comma in pattern suggestions)
 - #147251 (Do not assert that a change in global cache only happens when concurrent)
 - #147269 (Add regression test for 123953)
 - #147277 (Extract common logic for iterating over features)
 - #147280 (Return to needs-llvm-components being info-only)
 - #147292 (Respect `-Z` unstable options in `rustdoc --test`)
 - #147300 (Add xtensa arch to object file creation)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 4, 2025
@Zalathar
Rollup merge of rust-lang#147190 - joboet:sys-net-cleanup, r=hkBst,tg…
9de7576 
…ross35

std: `sys::net` cleanups

This PR contains three improvements to the socket-based networking implementation (aa1263e is just to add the now missing `unsafe`). Best reviewed commit-by-commit.
@Zalathar Zalathar mentioned this pull request Oct 4, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 4, 2025
@Zalathar
Rollup merge of rust-lang#147190 - joboet:sys-net-cleanup, r=hkBst,tg…
ac179e3 
…ross35

std: `sys::net` cleanups

This PR contains three improvements to the socket-based networking implementation (aa1263e is just to add the now missing `unsafe`). Best reviewed commit-by-commit.
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 4, 2025
@Zalathar
Rollup merge of rust-lang#147190 - joboet:sys-net-cleanup, r=hkBst,tg…
c29e8cf 
…ross35

std: `sys::net` cleanups

This PR contains three improvements to the socket-based networking implementation (aa1263e is just to add the now missing `unsafe`). Best reviewed commit-by-commit.
@Zalathar Zalathar mentioned this pull request Oct 4, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 4, 2025
@Zalathar
Rollup merge of rust-lang#147190 - joboet:sys-net-cleanup, r=hkBst,tg…
63080e4 
…ross35

std: `sys::net` cleanups

This PR contains three improvements to the socket-based networking implementation (aa1263e is just to add the now missing `unsafe`). Best reviewed commit-by-commit.
@Zalathar Zalathar mentioned this pull request Oct 4, 2025
Closed
bors added a commit that referenced this pull request Oct 4, 2025
@bors
Auto merge of #147326 - Zalathar:rollup-w696bpq, r=Zalathar
8572e48 
Rollup of 14 pull requests

Successful merges:

 - #142670 (Document fully-qualified syntax in `as`' keyword doc)
 - #145685 (add CloneFromCell and Cell::get_cloned)
 - #146330 (Bump unicode_data and printables to version 17.0.0)
 - #146451 (Fix atan2 inaccuracy in documentation)
 - #146479 (add mem::conjure_zst)
 - #146874 (compiler: Hint at multiple crate versions if trait impl is for wrong ADT )
 - #147117 (interpret `#[used]` as `#[used(compiler)]` on illumos)
 - #147190 (std: `sys::net` cleanups)
 - #147251 (Do not assert that a change in global cache only happens when concurrent)
 - #147280 (Return to needs-llvm-components being info-only)
 - #147288 (compiletest: Make `DirectiveLine` responsible for name/value splitting)
 - #147309 (Add documentation about unwinding to wasm targets)
 - #147315 (bless autodiff batching test)
 - #147323 (Fix top level ui tests check in tidy)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 4, 2025
@matthiaskrgr
Rollup merge of rust-lang#147190 - joboet:sys-net-cleanup, r=hkBst,tg…
9755466 
…ross35

std: `sys::net` cleanups

This PR contains three improvements to the socket-based networking implementation (aa1263e is just to add the now missing `unsafe`). Best reviewed commit-by-commit.
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 4, 2025
Closed
bors added a commit that referenced this pull request Oct 4, 2025
@bors
Auto merge of #147330 - matthiaskrgr:rollup-h4jyzmv, r=matthiaskrgr
1bd98ac 
Rollup of 11 pull requests

Successful merges:

 - #142670 (Document fully-qualified syntax in `as`' keyword doc)
 - #145685 (add CloneFromCell and Cell::get_cloned)
 - #146330 (Bump unicode_data and printables to version 17.0.0)
 - #146451 (Fix atan2 inaccuracy in documentation)
 - #146479 (add mem::conjure_zst)
 - #147117 (interpret `#[used]` as `#[used(compiler)]` on illumos)
 - #147190 (std: `sys::net` cleanups)
 - #147251 (Do not assert that a change in global cache only happens when concurrent)
 - #147280 (Return to needs-llvm-components being info-only)
 - #147288 (compiletest: Make `DirectiveLine` responsible for name/value splitting)
 - #147315 (bless autodiff batching test)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 4, 2025
Merged
bors added a commit that referenced this pull request Oct 4, 2025
@bors
Auto merge of #147340 - matthiaskrgr:rollup-icymmsc, r=matthiaskrgr
2cb4e7d 
Rollup of 10 pull requests

Successful merges:

 - #142670 (Document fully-qualified syntax in `as`' keyword doc)
 - #145685 (add CloneFromCell and Cell::get_cloned)
 - #146330 (Bump unicode_data and printables to version 17.0.0)
 - #146451 (Fix atan2 inaccuracy in documentation)
 - #146479 (add mem::conjure_zst)
 - #147117 (interpret `#[used]` as `#[used(compiler)]` on illumos)
 - #147190 (std: `sys::net` cleanups)
 - #147251 (Do not assert that a change in global cache only happens when concurrent)
 - #147280 (Return to needs-llvm-components being info-only)
 - #147315 (bless autodiff batching test)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c389e2e into rust-lang:master Oct 4, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 4, 2025
rust-timer added a commit that referenced this pull request Oct 4, 2025
@rust-timer
Unrolled build for #147190
65c132b 
Rollup merge of #147190 - joboet:sys-net-cleanup, r=hkBst,tgross35

std: `sys::net` cleanups

This PR contains three improvements to the socket-based networking implementation (aa1263e is just to add the now missing `unsafe`). Best reviewed commit-by-commit.
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
@matthiaskrgr
Rollup merge of rust-lang#147190 - joboet:sys-net-cleanup, r=hkBst,tg…
c9014fc 
…ross35

std: `sys::net` cleanups

This PR contains three improvements to the socket-based networking implementation (aa1263e is just to add the now missing `unsafe`). Best reviewed commit-by-commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 approved these changes

+1 more reviewer

@hkBst hkBst hkBst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tgross35 tgross35

Labels

O-unix Operating system: Unix-like O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

6 participants

@joboet @rustbot @tgross35 @bors @hkBst @ibraheemdev

Comments