reduce calls to attr.span() in old doc attr parsing#147615
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 13, 2025
Merged
reduce calls to attr.span() in old doc attr parsing#147615bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
A-attributes
Collaborator
|
|
9 tasks
JonathanBrouwer
approved these changes
Oct 13, 2025
GuillaumeGomez
approved these changes
Oct 13, 2025
Member
|
Thanks! @bors r=JonathanBrouwer,GuillaumeGomez rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 13, 2025
Rollup of 7 pull requests Successful merges: - #144266 (Supress swapping lhs and rhs in equality suggestion in extern macro ) - #147471 (Assert that non-extended temporaries and `super let` bindings have scopes) - #147533 (Renumber return local after state transform) - #147566 (rewrite outlives placeholder constraints to outlives static when handling opaque types) - #147613 (Make logging filters work again by moving EnvFilter into its own layer) - #147615 (reduce calls to attr.span() in old doc attr parsing) - #147636 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 13, 2025
Rollup merge of #147615 - jdonszelmann:span-calls-doc-attr, r=JonathanBrouwer,GuillaumeGomez reduce calls to attr.span() in old doc attr parsing r? `@oli-obk` should be trivial, can also delegate to `@GuillaumeGomez` or `@JonathanBrouwer.` As part of making span() return an option I want to reduce the number of places we call span in without it being known what specific attr it's for. This makes that more obvious for doc. Part of a chain of PRs that's coming. #131229 (comment)
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Oct 15, 2025
Rollup of 7 pull requests Successful merges: - rust-lang/rust#144266 (Supress swapping lhs and rhs in equality suggestion in extern macro ) - rust-lang/rust#147471 (Assert that non-extended temporaries and `super let` bindings have scopes) - rust-lang/rust#147533 (Renumber return local after state transform) - rust-lang/rust#147566 (rewrite outlives placeholder constraints to outlives static when handling opaque types) - rust-lang/rust#147613 (Make logging filters work again by moving EnvFilter into its own layer) - rust-lang/rust#147615 (reduce calls to attr.span() in old doc attr parsing) - rust-lang/rust#147636 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#144266 (Supress swapping lhs and rhs in equality suggestion in extern macro ) - rust-lang#147471 (Assert that non-extended temporaries and `super let` bindings have scopes) - rust-lang#147533 (Renumber return local after state transform) - rust-lang#147566 (rewrite outlives placeholder constraints to outlives static when handling opaque types) - rust-lang#147613 (Make logging filters work again by moving EnvFilter into its own layer) - rust-lang#147615 (reduce calls to attr.span() in old doc attr parsing) - rust-lang#147636 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @oli-obk
should be trivial, can also delegate to @GuillaumeGomez or @JonathanBrouwer.
As part of making span() return an option I want to reduce the number of places we call span in without it being known what specific attr it's for. This makes that more obvious for doc. Part of a chain of PRs that's coming.
#131229 (comment)