Deduplicate deprecation warning when using unit or tuple structs#147994

jdonszelmann · 2025-10-22T16:07:02Z

First commit adds a test that's broken currently, 2nd commit fixes it.

rustbot · 2025-10-22T16:07:05Z

HIR ty lowering was modified

rustbot · 2025-10-22T16:07:08Z

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs

jdonszelmann · 2025-10-23T09:14:16Z

yup, you're right @jieyouxu, ty :3

tests/ui/deprecation/unit_and_tuple_struct.rs

petrochenkov · 2025-10-23T14:51:11Z

This looks like an overkill, and probably a perf regression.
I'd rather override fn visit_use specifically in the stability visitor, and throw away one of the 3 paths if its resolution points to a constructor of one of the other two paths.

rustbot · 2025-10-28T16:11:22Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jdonszelmann · 2025-10-28T16:11:30Z

@rustbot review

jdonszelmann · 2025-10-28T16:14:07Z

@petrochenkov this is indeed much cleaner, thanks for the suggestion!

compiler/rustc_passes/src/stability.rs

jdonszelmann · 2025-10-30T09:39:03Z

ok, made it slightly nicer still I think, where we don't need an explicit loop or separate storage at all

jdonszelmann · 2025-10-30T12:34:34Z

@rustbot review

Co-authored-by: Waffle Lapkin <waffle.lapkin@gmail.com>

jdonszelmann · 2025-11-03T09:43:27Z

@rusbot review

jdonszelmann · 2025-11-03T14:08:37Z

@rustbot review

petrochenkov · 2025-11-05T18:21:16Z

Thanks!
@bors r+

bors · 2025-11-05T18:21:19Z

📌 Commit 1b00911 has been approved by petrochenkov

It is now in the queue for this repository.

Rollup of 8 pull requests Successful merges: - #147994 (Deduplicate deprecation warning when using unit or tuple structs) - #148440 ([rustdoc search] Simplify itemTypes and filter "dependencies") - #148501 (triagebot: Create Zulip topics for libs backports) - #148517 (Remove no longer necessary lint allow) - #148518 (Unify the configuration of the compiler docs) - #148523 (miri subtree update) - #148525 (Fix ICE from lit_to_mir_constant caused by type error) - #148534 (Merge `Vec::push{,_mut}_within_capacity`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #147994 - jdonszelmann:duplicate-warning-struct, r=petrochenkov Deduplicate deprecation warning when using unit or tuple structs First commit adds a test that's broken currently, 2nd commit fixes it. Created with `@WaffleLapkin`

Rollup of 8 pull requests Successful merges: - rust-lang/rust#147994 (Deduplicate deprecation warning when using unit or tuple structs) - rust-lang/rust#148440 ([rustdoc search] Simplify itemTypes and filter "dependencies") - rust-lang/rust#148501 (triagebot: Create Zulip topics for libs backports) - rust-lang/rust#148517 (Remove no longer necessary lint allow) - rust-lang/rust#148518 (Unify the configuration of the compiler docs) - rust-lang/rust#148523 (miri subtree update) - rust-lang/rust#148525 (Fix ICE from lit_to_mir_constant caused by type error) - rust-lang/rust#148534 (Merge `Vec::push{,_mut}_within_capacity`) r? `@ghost` `@rustbot` modify labels: rollup

…uct, r=petrochenkov Deduplicate deprecation warning when using unit or tuple structs First commit adds a test that's broken currently, 2nd commit fixes it. Created with `@WaffleLapkin`

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#147994 (Deduplicate deprecation warning when using unit or tuple structs) - rust-lang#148440 ([rustdoc search] Simplify itemTypes and filter "dependencies") - rust-lang#148501 (triagebot: Create Zulip topics for libs backports) - rust-lang#148517 (Remove no longer necessary lint allow) - rust-lang#148518 (Unify the configuration of the compiler docs) - rust-lang#148523 (miri subtree update) - rust-lang#148525 (Fix ICE from lit_to_mir_constant caused by type error) - rust-lang#148534 (Merge `Vec::push{,_mut}_within_capacity`) r? `@ghost` `@rustbot` modify labels: rollup

…uct, r=petrochenkov Deduplicate deprecation warning when using unit or tuple structs First commit adds a test that's broken currently, 2nd commit fixes it. Created with `@WaffleLapkin`

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#147994 (Deduplicate deprecation warning when using unit or tuple structs) - rust-lang#148440 ([rustdoc search] Simplify itemTypes and filter "dependencies") - rust-lang#148501 (triagebot: Create Zulip topics for libs backports) - rust-lang#148517 (Remove no longer necessary lint allow) - rust-lang#148518 (Unify the configuration of the compiler docs) - rust-lang#148523 (miri subtree update) - rust-lang#148525 (Fix ICE from lit_to_mir_constant caused by type error) - rust-lang#148534 (Merge `Vec::push{,_mut}_within_capacity`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 8 pull requests Successful merges: - rust-lang/rust#147994 (Deduplicate deprecation warning when using unit or tuple structs) - rust-lang/rust#148440 ([rustdoc search] Simplify itemTypes and filter "dependencies") - rust-lang/rust#148501 (triagebot: Create Zulip topics for libs backports) - rust-lang/rust#148517 (Remove no longer necessary lint allow) - rust-lang/rust#148518 (Unify the configuration of the compiler docs) - rust-lang/rust#148523 (miri subtree update) - rust-lang/rust#148525 (Fix ICE from lit_to_mir_constant caused by type error) - rust-lang/rust#148534 (Merge `Vec::push{,_mut}_within_capacity`) r? `@ghost` `@rustbot` modify labels: rollup

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 22, 2025

rustbot assigned petrochenkov Oct 22, 2025

jieyouxu reviewed Oct 22, 2025

View reviewed changes

compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs Show resolved Hide resolved

This comment has been minimized.

Sign in to view

jdonszelmann changed the title ~~Duplicate deprecation warning when using unit or tuple structs~~ Deduplicate deprecation warning when using unit or tuple structs Oct 22, 2025

jdonszelmann force-pushed the duplicate-warning-struct branch from 3cac327 to 47ab7a8 Compare October 23, 2025 09:13

petrochenkov reviewed Oct 23, 2025

View reviewed changes

tests/ui/deprecation/unit_and_tuple_struct.rs Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2025

jdonszelmann force-pushed the duplicate-warning-struct branch from 47ab7a8 to 8e7ccf3 Compare October 28, 2025 16:11

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 28, 2025

petrochenkov reviewed Oct 29, 2025

View reviewed changes

compiler/rustc_passes/src/stability.rs Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2025

jdonszelmann force-pushed the duplicate-warning-struct branch 3 times, most recently from 0fae4ea to 769d54e Compare October 30, 2025 09:36

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 30, 2025

add test for duplicate warning on used deprecated unit structs

c6a8c46

Co-authored-by: Waffle Lapkin <waffle.lapkin@gmail.com>

jdonszelmann force-pushed the duplicate-warning-struct branch from 769d54e to a7484b1 Compare November 3, 2025 09:43

deduplicate warnings (attempt 2)

1b00911

jdonszelmann force-pushed the duplicate-warning-struct branch from a7484b1 to 1b00911 Compare November 3, 2025 09:45

WaffleLapkin approved these changes Nov 3, 2025

View reviewed changes

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 3, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2025

matthiaskrgr mentioned this pull request Nov 5, 2025

Rollup of 8 pull requests #148544

Merged

bors merged commit a508f61 into rust-lang:master Nov 6, 2025
11 checks passed

rustbot added this to the 1.93.0 milestone Nov 6, 2025

Uh oh!

Conversation

jdonszelmann commented Oct 22, 2025

Uh oh!

rustbot commented Oct 22, 2025

Uh oh!

rustbot commented Oct 22, 2025

Uh oh!

Uh oh!

This comment has been minimized.

jdonszelmann commented Oct 23, 2025

Uh oh!

Uh oh!

petrochenkov commented Oct 23, 2025

Uh oh!

rustbot commented Oct 28, 2025

Uh oh!

jdonszelmann commented Oct 28, 2025

Uh oh!

jdonszelmann commented Oct 28, 2025

Uh oh!

Uh oh!

jdonszelmann commented Oct 30, 2025

Uh oh!

jdonszelmann commented Oct 30, 2025

Uh oh!

jdonszelmann commented Nov 3, 2025

Uh oh!

jdonszelmann commented Nov 3, 2025

Uh oh!

petrochenkov commented Nov 5, 2025

Uh oh!

bors commented Nov 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants