Fix some issues around `rustc_public`#148358

makai410 · 2025-11-01T08:31:54Z

cc #148266 .
follow-up of #148341 .

This fixes the issues that can be reproduced by x test compiler/rustc_public:

error: function `run` is never used
   --> compiler/rustc_public/src/compiler_interface.rs:838:15
    |
838 | pub(crate) fn run<'tcx, F, T>(interface: &CompilerInterface<'tcx>, f: F) -> Result<T, Error>
    |               ^^^
    |
    = note: `-D dead-code` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(dead_code)]`

error: unreachable `pub` item
  --> compiler/rustc_public/src/unstable/mod.rs:25:1
   |
25 | pub trait InternalCx<'tcx>: Copy + Clone {
   | ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   | |
   | help: consider restricting its visibility: `pub(crate)`
   |
   = help: or consider exporting it for use by other crates
   = note: `-D unreachable-pub` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unreachable_pub)]`

error: unreachable `pub` item
  --> compiler/rustc_public/src/unstable/mod.rs:62:1
   |
62 | pub trait Stable<'tcx>: PointeeSized {
   | ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   | |
   | help: consider restricting its visibility: `pub(crate)`
   |
   = help: or consider exporting it for use by other crates

error: unreachable `pub` item
  --> compiler/rustc_public/src/unstable/mod.rs:81:1
   |
81 | pub trait RustcInternal {
   | ---^^^^^^^^^^^^^^^^^^^^
   | |
   | help: consider restricting its visibility: `pub(crate)`
   |
   = help: or consider exporting it for use by other crates

error: could not compile `rustc_public` (lib) due to 4 previous errors

rustbot · 2025-11-01T08:31:57Z

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a

rustbot · 2025-11-01T08:31:59Z

r? @celinval

rustbot has assigned @celinval.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

celinval

Thanks for proactively looking at this

View changes since this review

celinval · 2025-11-05T06:53:07Z

compiler/rustc_public/src/lib.rs

 pub mod abi;
 mod alloc;
-pub(crate) mod unstable;
+pub mod unstable;


I don't think we should make this module public. Instead, we should add an attribute to the trait declarations:

/// This is used by the public `rustc_internal::stable` function when feature `rustc_internal` is enabled. #[cfg_attr(not(feature = "rustc_internal"), allow(unreachable_pub))] pub trait Stable<'tcx>: PointeeSized { // ... }

celinval · 2025-11-05T06:57:22Z

compiler/rustc_public/src/compiler_interface.rs

 // A thread local variable that stores a pointer to [`CompilerInterface`].
 scoped_tls::scoped_thread_local!(static TLV: Cell<*const ()>);

+// FIXME(makai410): remove this cfg when we have a stable driver.


I don't think we need this FIXME... Maybe just a comment. We could also move this function to be inside rustc_internal.

celinval · 2025-11-18T01:34:59Z

@bors r+ rollup

bors · 2025-11-18T01:35:02Z

📌 Commit 1f7a342 has been approved by celinval

It is now in the queue for this repository.

Fix some issues around `rustc_public` cc #148266 . follow-up of #148341 . This fixes the issues that can be reproduced by `x test compiler/rustc_public`: ``` error: function `run` is never used --> compiler/rustc_public/src/compiler_interface.rs:838:15 | 838 | pub(crate) fn run<'tcx, F, T>(interface: &CompilerInterface<'tcx>, f: F) -> Result<T, Error> | ^^^ | = note: `-D dead-code` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(dead_code)]` error: unreachable `pub` item --> compiler/rustc_public/src/unstable/mod.rs:25:1 | 25 | pub trait InternalCx<'tcx>: Copy + Clone { | ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates = note: `-D unreachable-pub` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unreachable_pub)]` error: unreachable `pub` item --> compiler/rustc_public/src/unstable/mod.rs:62:1 | 62 | pub trait Stable<'tcx>: PointeeSized { | ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates error: unreachable `pub` item --> compiler/rustc_public/src/unstable/mod.rs:81:1 | 81 | pub trait RustcInternal { | ---^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates error: could not compile `rustc_public` (lib) due to 4 previous errors ```

bors · 2025-11-18T04:03:33Z

⌛ Testing commit 1f7a342 with merge e8ff20b...

rust-log-analyzer · 2025-11-18T04:28:48Z

The job dist-apple-various failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[1628/3789] Building M68kGenRegisterBank.inc...
[1629/3789] Building M68kGenSDNodeInfo.inc...
[1630/3789] Building M68kGenSubtargetInfo.inc...
[1631/3789] Linking CXX static library lib/libLLVMSelectionDAG.a
FAILED: [code=1] lib/libLLVMSelectionDAG.a 
: && "/Applications/Xcode_15.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool" -static -no_warning_for_no_symbols -o lib/libLLVMSelectionDAG.a  lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/DAGCombiner.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/FastISel.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/FunctionLoweringInfo.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/InstrEmitter.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/LegalizeDAG.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/LegalizeFloatTypes.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/LegalizeIntegerTypes.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/LegalizeTypes.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/LegalizeTypesGeneric.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/LegalizeVectorOps.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/LegalizeVectorTypes.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/ResourcePriorityQueue.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/SDNodeInfo.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/ScheduleDAGFast.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/ScheduleDAGRRList.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/ScheduleDAGSDNodes.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/ScheduleDAGVLIW.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/SelectionDAGBuilder.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/SelectionDAG.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/SelectionDAGAddressAnalysis.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/SelectionDAGDumper.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/SelectionDAGISel.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/SelectionDAGPrinter.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/SelectionDAGTargetInfo.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/StatepointLowering.cpp.o lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/TargetLowering.cpp.o && cd /Users/runner/work/rust/rust/build/aarch64-apple-darwin/llvm/build/lib/CodeGen/SelectionDAG && touch /Users/runner/work/rust/rust/build/aarch64-apple-darwin/llvm/build/./lib/libLLVMSelectionDAG.a
fatal error: /Applications/Xcode_15.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: can't write to output file (Input/output error)
[1632/3789] Building CXX object lib/CodeGen/GlobalISel/CMakeFiles/LLVMGlobalISel.dir/CSEInfo.cpp.o
[1633/3789] Building CXX object lib/IRPrinter/CMakeFiles/LLVMIRPrinter.dir/IRPrintingPasses.cpp.o
ninja: build stopped: subcommand failed.

thread 'main' (45658) panicked at /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/cmake-0.1.54/src/lib.rs:1119:5:

bors · 2025-11-18T04:29:37Z

💔 Test failed - checks-actions

Fix some issues around `rustc_public` cc rust-lang#148266 . follow-up of rust-lang#148341 . This fixes the issues that can be reproduced by `x test compiler/rustc_public`: ``` error: function `run` is never used --> compiler/rustc_public/src/compiler_interface.rs:838:15 | 838 | pub(crate) fn run<'tcx, F, T>(interface: &CompilerInterface<'tcx>, f: F) -> Result<T, Error> | ^^^ | = note: `-D dead-code` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(dead_code)]` error: unreachable `pub` item --> compiler/rustc_public/src/unstable/mod.rs:25:1 | 25 | pub trait InternalCx<'tcx>: Copy + Clone { | ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates = note: `-D unreachable-pub` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unreachable_pub)]` error: unreachable `pub` item --> compiler/rustc_public/src/unstable/mod.rs:62:1 | 62 | pub trait Stable<'tcx>: PointeeSized { | ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates error: unreachable `pub` item --> compiler/rustc_public/src/unstable/mod.rs:81:1 | 81 | pub trait RustcInternal { | ---^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates error: could not compile `rustc_public` (lib) due to 4 previous errors ```

jyn514 · 2025-11-25T20:17:40Z

fyi bors thinks that this PR has not been approved, probably because of the spurious apple failure. you should be able to reapprove with @bors retry.

celinval · 2025-11-26T06:35:10Z

Let's try again!

@bors retry

Fix some issues around `rustc_public` cc rust-lang#148266 . follow-up of rust-lang#148341 . This fixes the issues that can be reproduced by `x test compiler/rustc_public`: ``` error: function `run` is never used --> compiler/rustc_public/src/compiler_interface.rs:838:15 | 838 | pub(crate) fn run<'tcx, F, T>(interface: &CompilerInterface<'tcx>, f: F) -> Result<T, Error> | ^^^ | = note: `-D dead-code` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(dead_code)]` error: unreachable `pub` item --> compiler/rustc_public/src/unstable/mod.rs:25:1 | 25 | pub trait InternalCx<'tcx>: Copy + Clone { | ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates = note: `-D unreachable-pub` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unreachable_pub)]` error: unreachable `pub` item --> compiler/rustc_public/src/unstable/mod.rs:62:1 | 62 | pub trait Stable<'tcx>: PointeeSized { | ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates error: unreachable `pub` item --> compiler/rustc_public/src/unstable/mod.rs:81:1 | 81 | pub trait RustcInternal { | ---^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates error: could not compile `rustc_public` (lib) due to 4 previous errors ```

Rollup of 9 pull requests Successful merges: - #147936 (Offload intrinsic) - #148358 (Fix some issues around `rustc_public`) - #148452 (Mangle symbols with a mangled name close to PDB limits with v0 instead of legacy mangling to avoid linker errors) - #148751 (Build gnullvm toolchains on Windows natively) - #148951 (rustc_target: aarch64: Remove deprecated FEAT_TME) - #149173 (Use rust rather than LLVM target features in the target spec) - #149307 (Deny const auto traits) - #149312 (Mark riscv64gc-unknown-linux-musl as tier 2 target) - #149341 (Add `Copy` to some AST enums.) r? `@ghost` `@rustbot` modify labels: rollup

Fix some issues around `rustc_public` cc rust-lang#148266 . follow-up of rust-lang#148341 . This fixes the issues that can be reproduced by `x test compiler/rustc_public`: ``` error: function `run` is never used --> compiler/rustc_public/src/compiler_interface.rs:838:15 | 838 | pub(crate) fn run<'tcx, F, T>(interface: &CompilerInterface<'tcx>, f: F) -> Result<T, Error> | ^^^ | = note: `-D dead-code` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(dead_code)]` error: unreachable `pub` item --> compiler/rustc_public/src/unstable/mod.rs:25:1 | 25 | pub trait InternalCx<'tcx>: Copy + Clone { | ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates = note: `-D unreachable-pub` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unreachable_pub)]` error: unreachable `pub` item --> compiler/rustc_public/src/unstable/mod.rs:62:1 | 62 | pub trait Stable<'tcx>: PointeeSized { | ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates error: unreachable `pub` item --> compiler/rustc_public/src/unstable/mod.rs:81:1 | 81 | pub trait RustcInternal { | ---^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates error: could not compile `rustc_public` (lib) due to 4 previous errors ```

Rollup of 12 pull requests Successful merges: - #147936 (Offload intrinsic) - #148358 (Fix some issues around `rustc_public`) - #148452 (Mangle symbols with a mangled name close to PDB limits with v0 instead of legacy mangling to avoid linker errors) - #148751 (Build gnullvm toolchains on Windows natively) - #148951 (rustc_target: aarch64: Remove deprecated FEAT_TME) - #149149 ([rustdoc] misc search index cleanups) - #149173 (Use rust rather than LLVM target features in the target spec) - #149307 (Deny const auto traits) - #149312 (Mark riscv64gc-unknown-linux-musl as tier 2 target) - #149317 (Handle inline asm in has_ffi_unwind_calls) - #149326 (Remove unused `Clone` derive on `DelayedLint`) - #149341 (Add `Copy` to some AST enums.) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #148358 - makai410:rpub-test-fix, r=celinval Fix some issues around `rustc_public` cc #148266 . follow-up of #148341 . This fixes the issues that can be reproduced by `x test compiler/rustc_public`: ``` error: function `run` is never used --> compiler/rustc_public/src/compiler_interface.rs:838:15 | 838 | pub(crate) fn run<'tcx, F, T>(interface: &CompilerInterface<'tcx>, f: F) -> Result<T, Error> | ^^^ | = note: `-D dead-code` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(dead_code)]` error: unreachable `pub` item --> compiler/rustc_public/src/unstable/mod.rs:25:1 | 25 | pub trait InternalCx<'tcx>: Copy + Clone { | ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates = note: `-D unreachable-pub` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unreachable_pub)]` error: unreachable `pub` item --> compiler/rustc_public/src/unstable/mod.rs:62:1 | 62 | pub trait Stable<'tcx>: PointeeSized { | ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates error: unreachable `pub` item --> compiler/rustc_public/src/unstable/mod.rs:81:1 | 81 | pub trait RustcInternal { | ---^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates error: could not compile `rustc_public` (lib) due to 4 previous errors ```

Rollup of 12 pull requests Successful merges: - rust-lang/rust#147936 (Offload intrinsic) - rust-lang/rust#148358 (Fix some issues around `rustc_public`) - rust-lang/rust#148452 (Mangle symbols with a mangled name close to PDB limits with v0 instead of legacy mangling to avoid linker errors) - rust-lang/rust#148751 (Build gnullvm toolchains on Windows natively) - rust-lang/rust#148951 (rustc_target: aarch64: Remove deprecated FEAT_TME) - rust-lang/rust#149149 ([rustdoc] misc search index cleanups) - rust-lang/rust#149173 (Use rust rather than LLVM target features in the target spec) - rust-lang/rust#149307 (Deny const auto traits) - rust-lang/rust#149312 (Mark riscv64gc-unknown-linux-musl as tier 2 target) - rust-lang/rust#149317 (Handle inline asm in has_ffi_unwind_calls) - rust-lang/rust#149326 (Remove unused `Clone` derive on `DelayedLint`) - rust-lang/rust#149341 (Add `Copy` to some AST enums.) r? `@ghost` `@rustbot` modify labels: rollup

Fix some issues around `rustc_public` cc rust-lang#148266 . follow-up of rust-lang#148341 . This fixes the issues that can be reproduced by `x test compiler/rustc_public`: ``` error: function `run` is never used --> compiler/rustc_public/src/compiler_interface.rs:838:15 | 838 | pub(crate) fn run<'tcx, F, T>(interface: &CompilerInterface<'tcx>, f: F) -> Result<T, Error> | ^^^ | = note: `-D dead-code` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(dead_code)]` error: unreachable `pub` item --> compiler/rustc_public/src/unstable/mod.rs:25:1 | 25 | pub trait InternalCx<'tcx>: Copy + Clone { | ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates = note: `-D unreachable-pub` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unreachable_pub)]` error: unreachable `pub` item --> compiler/rustc_public/src/unstable/mod.rs:62:1 | 62 | pub trait Stable<'tcx>: PointeeSized { | ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates error: unreachable `pub` item --> compiler/rustc_public/src/unstable/mod.rs:81:1 | 81 | pub trait RustcInternal { | ---^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates error: could not compile `rustc_public` (lib) due to 4 previous errors ```

Rollup of 12 pull requests Successful merges: - rust-lang#147936 (Offload intrinsic) - rust-lang#148358 (Fix some issues around `rustc_public`) - rust-lang#148452 (Mangle symbols with a mangled name close to PDB limits with v0 instead of legacy mangling to avoid linker errors) - rust-lang#148751 (Build gnullvm toolchains on Windows natively) - rust-lang#148951 (rustc_target: aarch64: Remove deprecated FEAT_TME) - rust-lang#149149 ([rustdoc] misc search index cleanups) - rust-lang#149173 (Use rust rather than LLVM target features in the target spec) - rust-lang#149307 (Deny const auto traits) - rust-lang#149312 (Mark riscv64gc-unknown-linux-musl as tier 2 target) - rust-lang#149317 (Handle inline asm in has_ffi_unwind_calls) - rust-lang#149326 (Remove unused `Clone` derive on `DelayedLint`) - rust-lang#149341 (Add `Copy` to some AST enums.) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 12 pull requests Successful merges: - rust-lang/rust#147936 (Offload intrinsic) - rust-lang/rust#148358 (Fix some issues around `rustc_public`) - rust-lang/rust#148452 (Mangle symbols with a mangled name close to PDB limits with v0 instead of legacy mangling to avoid linker errors) - rust-lang/rust#148751 (Build gnullvm toolchains on Windows natively) - rust-lang/rust#148951 (rustc_target: aarch64: Remove deprecated FEAT_TME) - rust-lang/rust#149149 ([rustdoc] misc search index cleanups) - rust-lang/rust#149173 (Use rust rather than LLVM target features in the target spec) - rust-lang/rust#149307 (Deny const auto traits) - rust-lang/rust#149312 (Mark riscv64gc-unknown-linux-musl as tier 2 target) - rust-lang/rust#149317 (Handle inline asm in has_ffi_unwind_calls) - rust-lang/rust#149326 (Remove unused `Clone` derive on `DelayedLint`) - rust-lang/rust#149341 (Add `Copy` to some AST enums.) r? `@ghost` `@rustbot` modify labels: rollup

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 1, 2025

rustbot assigned celinval Nov 1, 2025

makai410 mentioned this pull request Nov 1, 2025

compiler: Fix a couple issues around cargo feature unification #148341

Merged

celinval reviewed Nov 5, 2025

View reviewed changes

rustc_public: fix some issues

1f7a342

makai410 force-pushed the rpub-test-fix branch from fc3057b to 1f7a342 Compare November 17, 2025 08:44

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 18, 2025

jyn514 mentioned this pull request Nov 18, 2025

Switch back to resolver = "2" ferrocene/ferrocene#1877

Open

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2025

jhpratt mentioned this pull request Nov 26, 2025

Rollup of 9 pull requests #149342

Closed

Zalathar mentioned this pull request Nov 26, 2025

Rollup of 12 pull requests #149351

Merged

bors merged commit 2ddaf42 into rust-lang:main Nov 26, 2025
11 of 12 checks passed

rustbot added this to the 1.93.0 milestone Nov 26, 2025

Uh oh!

Conversation

makai410 commented Nov 1, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Nov 1, 2025

Uh oh!

rustbot commented Nov 1, 2025

Uh oh!

celinval left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

celinval Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

celinval Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

celinval commented Nov 18, 2025

Uh oh!

bors commented Nov 18, 2025

Uh oh!

bors commented Nov 18, 2025

Uh oh!

rust-log-analyzer commented Nov 18, 2025

Uh oh!

bors commented Nov 18, 2025

Uh oh!

jyn514 commented Nov 25, 2025

Uh oh!

celinval commented Nov 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

makai410 commented Nov 1, 2025 •

edited by rustbot

Loading

celinval left a comment •

edited by rustbot

Loading