Implement the alternative try block desugaring#148725
Merged
bors merged 3 commits intorust-lang:mainfrom Nov 14, 2025
Merged
Conversation
Collaborator
|
rustbot has assigned @petrochenkov. Use |
This comment has been minimized.
This comment has been minimized.
74cc941 to
88085e3
Compare
This comment has been minimized.
This comment has been minimized.
88085e3 to
cfbecaf
Compare
cfbecaf to
86c3ba7
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
8b90701 to
cc7f844
Compare
scottmcm
commented
Nov 13, 2025
tests/mir-opt/pre-codegen/option_bubble_debug.option_traits.PreCodegen.after.panic-abort.mir
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Contributor
|
This comment has been minimized.
This comment has been minimized.
ae3a70e to
1e2fe0d
Compare
This comment has been minimized.
This comment has been minimized.
1e2fe0d to
e5803fc
Compare
Contributor
|
@bors r+ |
Collaborator
bors
added a commit
that referenced
this pull request
Nov 14, 2025
Rollup of 4 pull requests Successful merges: - #148638 (Fix ICE for repr simd on non struct) - #148725 (Implement the alternative `try` block desugaring) - #148777 (Lock shards while emitting depth limit error.) - #148933 (Add note for option llvm.download-ci-llvm) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 14, 2025
Rollup merge of #148725 - scottmcm:experiment-new-try-block-v3, r=petrochenkov Implement the alternative `try` block desugaring As discussed in rust-lang/rfcs#3721 (comment), update the `try` in nightly to match the RFC as a way to experiment. This addresses the following unresolved issue from #31436 > Address issues with type inference (`try { expr? }?` currently requires an explicit type annotation somewhere).
Open
16 tasks
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 21, 2025
…pe, r=scottmcm Constify `residual_into_try_type` Feature: `const_try_residual` (related to `try_trait_v2_residual`) Tracking issue: rust-lang#91285 Constify `residual_into_try_type` introduced in rust-lang#148725. r? `@scottmcm`
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 21, 2025
…pe, r=scottmcm Constify `residual_into_try_type` Feature: `const_try_residual` (related to `try_trait_v2_residual`) Tracking issue: rust-lang#91285 Constify `residual_into_try_type` introduced in rust-lang#148725. r? ``@scottmcm``
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
…v3, r=petrochenkov Implement the alternative `try` block desugaring As discussed in rust-lang/rfcs#3721 (comment), update the `try` in nightly to match the RFC as a way to experiment. This addresses the following unresolved issue from rust-lang#31436 > Address issues with type inference (`try { expr? }?` currently requires an explicit type annotation somewhere).
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 10, 2025
Experimentally add *heterogeneous* `try` blocks rust-lang#148725 moved the default to being homogeneous; this adds heterogeneous ones back under an obvious-bikeshed syntax so people can experiment with that as well. Essentially resolves rust-lang#149025 by letting them move to this syntax instead. New tracking issue: rust-lang#149488 Related RFC: rust-lang/rfcs#3721 (comment) (specifically about experimenting)
rust-timer
added a commit
that referenced
this pull request
Dec 10, 2025
Rollup merge of #149489 - scottmcm:try-bikeshed, r=nnethercote Experimentally add *heterogeneous* `try` blocks #148725 moved the default to being homogeneous; this adds heterogeneous ones back under an obvious-bikeshed syntax so people can experiment with that as well. Essentially resolves #149025 by letting them move to this syntax instead. New tracking issue: #149488 Related RFC: rust-lang/rfcs#3721 (comment) (specifically about experimenting)
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Dec 11, 2025
Experimentally add *heterogeneous* `try` blocks rust-lang/rust#148725 moved the default to being homogeneous; this adds heterogeneous ones back under an obvious-bikeshed syntax so people can experiment with that as well. Essentially resolves rust-lang/rust#149025 by letting them move to this syntax instead. New tracking issue: rust-lang/rust#149488 Related RFC: rust-lang/rfcs#3721 (comment) (specifically about experimenting)
Kobzol
pushed a commit
to Kobzol/rustc_codegen_cranelift
that referenced
this pull request
Dec 29, 2025
Experimentally add *heterogeneous* `try` blocks rust-lang/rust#148725 moved the default to being homogeneous; this adds heterogeneous ones back under an obvious-bikeshed syntax so people can experiment with that as well. Essentially resolves rust-lang/rust#149025 by letting them move to this syntax instead. New tracking issue: rust-lang/rust#149488 Related RFC: rust-lang/rfcs#3721 (comment) (specifically about experimenting)
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Jan 17, 2026
…pe, r=scottmcm Constify `residual_into_try_type` Feature: `const_try_residual` (related to `try_trait_v2_residual`) Tracking issue: rust-lang#91285 Constify `residual_into_try_type` introduced in rust-lang#148725. r? ``@scottmcm``
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in rust-lang/rfcs#3721 (comment), update the
tryin nightly to match the RFC as a way to experiment.This addresses the following unresolved issue from #31436