sgx: avoid unnecessarily creating a slice#149113
Merged
bors merged 1 commit intorust-lang:mainfrom Nov 21, 2025
Merged
Conversation
rustbot
added
O-SGX
Collaborator
|
r? @ChrisDenton rustbot has assigned @ChrisDenton. Use |
Contributor
Contributor
So the Safety documentation section of the trait method seems to imply that the following invariant must be upheld
However, I think that may be incorrect. I think a similar invariant is upheld by the |
RalfJung
force-pushed
the
sgx-less-unsafe
branch
from
dfdc989 to
7ad3c5c
Compare
Member
Author
|
It is also generally odd to have a safety comment on a trait impl that's not the same as the one in the trait itself -- callers that use a generic Anyway I won't be conducting a refactor of that trait here, I just noticed this little improvement inside the slice impl. I will leave follow-up cleanup to people that understand the surrounding context better :) |
Member
|
Potential followups aside, this is strictly an improvement so... @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 20, 2025
…enton sgx: avoid unnecessarily creating a slice Cc `@jethrogb` -- no idea why this created a slice only to directly convert it back to a raw pointer, but we can avoid this and in fact make the entire function safe. I didn't change the function signature (it's still an `unsafe fn`) as I know nothing about the surrounding code.
bors
added a commit
that referenced
this pull request
Nov 20, 2025
Rollup of 9 pull requests Successful merges: - #149033 (autodiff rlib handling) - #149088 (Add missing trailing period to RustDoc for fn create_dir().) - #149111 (fs: Run file lock tests on all platforms that support it) - #149113 (sgx: avoid unnecessarily creating a slice) - #149123 (std: sys: fs: uefi: Fix FileAttr size) - #149125 (In `BTreeMap::eq`, do not compare the elements if the sizes are different.) - #149133 (Remove an unused variable) - #149134 (std: sys: net: uefi: Implement read_vectored) - #149139 (Enable host tools for aarch64-unknown-linux-ohos) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Nov 20, 2025
Rollup of 9 pull requests Successful merges: - #149033 (autodiff rlib handling) - #149088 (Add missing trailing period to RustDoc for fn create_dir().) - #149111 (fs: Run file lock tests on all platforms that support it) - #149113 (sgx: avoid unnecessarily creating a slice) - #149123 (std: sys: fs: uefi: Fix FileAttr size) - #149133 (Remove an unused variable) - #149139 (Enable host tools for aarch64-unknown-linux-ohos) - #149144 (Reject `async fn` in `const impl` during AST validation) - #149154 (Fix platform supports docs tiny typo) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 21, 2025
Rollup merge of #149113 - RalfJung:sgx-less-unsafe, r=ChrisDenton sgx: avoid unnecessarily creating a slice Cc ``@jethrogb`` -- no idea why this created a slice only to directly convert it back to a raw pointer, but we can avoid this and in fact make the entire function safe. I didn't change the function signature (it's still an `unsafe fn`) as I know nothing about the surrounding code.
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Jan 17, 2026
…enton sgx: avoid unnecessarily creating a slice Cc ``@jethrogb`` -- no idea why this created a slice only to directly convert it back to a raw pointer, but we can avoid this and in fact make the entire function safe. I didn't change the function signature (it's still an `unsafe fn`) as I know nothing about the surrounding code.
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Jan 17, 2026
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#149033 (autodiff rlib handling) - rust-lang#149088 (Add missing trailing period to RustDoc for fn create_dir().) - rust-lang#149111 (fs: Run file lock tests on all platforms that support it) - rust-lang#149113 (sgx: avoid unnecessarily creating a slice) - rust-lang#149123 (std: sys: fs: uefi: Fix FileAttr size) - rust-lang#149133 (Remove an unused variable) - rust-lang#149139 (Enable host tools for aarch64-unknown-linux-ohos) - rust-lang#149144 (Reject `async fn` in `const impl` during AST validation) - rust-lang#149154 (Fix platform supports docs tiny typo) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cc @jethrogb -- no idea why this created a slice only to directly convert it back to a raw pointer, but we can avoid this and in fact make the entire function safe. I didn't change the function signature (it's still an
unsafe fn) as I know nothing about the surrounding code.