Tidying up UI tests [5/N]

[reddevilmidzy]

Note

Intermediate commits are intended to help review, but will be squashed prior to merge.

part of #133895

merge directory

• macro_backtrace -> macros
• missing_non_modrs_mod -> modules
• modules_and_files_visibility -> modules
• qualified -> typeck
• while -> for-loop-whlie

r? Kivooeo

[reddevilmidzy]

There was a typo in the commit message, I'll fix it when I squash!

Relocate modules_ans_files_visibity/mod_file_correct_spans.rs to modules/mod_file_correct_spans.rs

View changes since this review

[reddevilmidzy]

original

mod mod_file_disambig_aux; //~ ERROR file for module `mod_file_disambig_aux` found at both

fn main() {
    assert_eq!(mod_file_aux::bar(), 10);
    //~^ ERROR failed to resolve: use of unresolved module or unlinked crate `mod_file_aux`
}

a74d92e

The assert_eq statement here seems unnecessary, so I removed it.

[Kivooeo]

For context, we had a discussion earlier this year about test squashing. We decided against squashing and instead to split moves and changes into separate commits to preserve the git history of test files

Here's the process: First, you create a commit with just the file moves (no changes of it's content). Then, you make separate commits for the changes to each file. After the review, you squash all the commits that modified files (i.e., all commits except the first one with the plain moves)

This approach also improves the review experience

That said, for this particular PR, feel free to squash all the commits into one

[reddevilmidzy]

Ah, I agree. then I won't squah this PR either. and in the next PR, I'll commit the move and change separately !

[Kivooeo]

@bors r+ rollup

[bors]

📌 Commit ace4aeb has been approved by Kivooeo

It is now in the queue for this repository.