Conversation
rustbot
added
S-waiting-on-review
|
|
|
@rustbot ping relnotes-interest-group |
|
Hi relnotes-interest-group, this issue/PR could use some help in reviewing / cc @alex-semenyuk @jieyouxu @joshtriplett @Kobzol @lcnr @traviscross |
|
Hi, sorry for being late with this I wanted to ask about Release Notes for this change (#146810). We discussed this briefly on #t-compiler > Determining if a change needs release notes, but I’m still not completely sure whether they are required in my case. If they are needed, do I still have time to add them? |
|
@Kivooeo that change is already included, but you can still suggest edits here, even removing that line if you don't think it deserves mention. |
|
I meant a release blog section like here #147383 Because I still unsure about what changes require them
This line is not clear enough to me, how can I understand if change is "notable enough" |
|
Ah, the blog is much more subjective -- there's no real requirement, but it's essentially a judgement call about how many people may care about the change. @BoxyUwU is handling that in rust-lang/blog.rust-lang.org#1757. |
|
this is now in the stable PR. if the commits could be squashed then this can be r+'d |
cuviper
force-pushed
the
relnotes-1.92.0
branch
from
dc15294 to
90d2477
Compare
|
@bors r=BoxyUwU rollup |
bors
added
S-waiting-on-bors
Add release notes for 1.92.0 cc `@rust-lang/release` r? `@BoxyUwU`
Rollup of 12 pull requests Successful merges: - #147572 (std: Use more `unix.rs` code on WASI targets) - #148491 ( Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type) - #149215 (Emit `check-cfg` lints during attribute parsing rather than evaluation) - #149652 (Add release notes for 1.92.0) - #149720 (rustdoc book: mention inner doc attribute) - #149730 (lint: emit proper diagnostic for unsafe binders in improper_ctypes instead of ICE) - #149754 (Retire `opt_str2` from compiletest cli parsing) - #149755 (bootstrap: Use a `CompiletestMode` enum instead of bare strings) - #149763 (Add inline attribute to generated delegation function if needed) - #149772 (test: Add a test for 146133) - #149779 (Fix typo "an" → "and") - #149782 (Remove `[no-mentions]` handler in the triagebot config) r? `@ghost` `@rustbot` modify labels: rollup
Rollup of 11 pull requests Successful merges: - #147585 (Suppress the error for private fields with non_exhaustive attribute) - #149215 (Emit `check-cfg` lints during attribute parsing rather than evaluation) - #149652 (Add release notes for 1.92.0) - #149720 (rustdoc book: mention inner doc attribute) - #149730 (lint: emit proper diagnostic for unsafe binders in improper_ctypes instead of ICE) - #149754 (Retire `opt_str2` from compiletest cli parsing) - #149755 (bootstrap: Use a `CompiletestMode` enum instead of bare strings) - #149763 (Add inline attribute to generated delegation function if needed) - #149772 (test: Add a test for 146133) - #149779 (Fix typo "an" → "and") - #149782 (Remove `[no-mentions]` handler in the triagebot config) Failed merges: - #148491 ( Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #149652 - cuviper:relnotes-1.92.0, r=BoxyUwU Add release notes for 1.92.0 cc ``@rust-lang/release`` r? ``@BoxyUwU``
8 participants
cc @rust-lang/release
r? @BoxyUwU