Skip to content

Make --print=backend-has-zstd work by default on any backend#149764

Merged
bors merged 1 commit intorust-lang:mainfrom
Zalathar:has-zstd
Dec 10, 2025
Merged

Make --print=backend-has-zstd work by default on any backend#149764
bors merged 1 commit intorust-lang:mainfrom
Zalathar:has-zstd

Conversation

@Zalathar
Copy link
Member

@Zalathar Zalathar commented Dec 8, 2025

Using a defaulted CodegenBackend method that querying for zstd support should automatically print a safe value of false on any backend that doesn't specifically indicate the presence or absence of zstd.

This should fix the compiletest failures reported in #149666 (comment), which can occur when LLVM is not the default codegen backend.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 8, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Zalathar
Copy link
Member Author

Zalathar commented Dec 8, 2025

cc @bjorn3

@Zalathar Zalathar mentioned this pull request Dec 8, 2025
Merged
@bjorn3
Copy link
Member

bjorn3 commented Dec 8, 2025

Would you mind removing https://github.com/rust-lang/rust/pull/149776/files#diff-b5a09d09fd21f3236a6ae904132f826f38c29be9347281fc97de6792fe081df4R163-R172 in this PR once the subtree sync lands?

@rustbot
Copy link
Collaborator

rustbot commented Dec 9, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Zalathar
Make --print=backend-has-zstd work by default on any backend
5c91f2c 
Using a defaulted `CodegenBackend` method that querying for zstd support should
automatically print a safe value of `false` on any backend that doesn't
specifically indicate the presence or absence of zstd.
@rustbot
Copy link
Collaborator

rustbot commented Dec 9, 2025

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

compiletest directives have been modified. Please add or update docs for the
new or modified directive in src/doc/rustc-dev-guide/.

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 9, 2025
@Zalathar
Copy link
Member Author

Zalathar commented Dec 9, 2025

Removed the now-dead implementation of PrintKind::BackendHasZstd from cg_clif, and added a FIXME comment to llvm_has_zstd in compiletest (diff).

@fee1-dead
Copy link
Member

fee1-dead commented Dec 10, 2025

r? bjorn3

@rustbot rustbot assigned bjorn3 and unassigned fee1-dead Dec 10, 2025
@bjorn3
Copy link
Member

bjorn3 commented Dec 10, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 10, 2025

📌 Commit 5c91f2c has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 10, 2025
Merged
bors added a commit that referenced this pull request Dec 10, 2025
@bors
Auto merge of #149853 - matthiaskrgr:rollup-m2rkwqr, r=matthiaskrgr
bfd0918 
Rollup of 7 pull requests

Successful merges:

 - #148052 (Stabilize `const_mul_add`)
 - #149386 (Display funding link in the github overview)
 - #149489 (Experimentally add *heterogeneous* `try` blocks)
 - #149764 (Make `--print=backend-has-zstd` work by default on any backend)
 - #149838 (Build auxiliary in pretty tests)
 - #149839 (Use `PointeeSized` bound for `TrivialClone` impls)
 - #149846 (Statically require links to an issue or the edition guide for all FCWs)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Dec 10, 2025
@bors
Auto merge of #149853 - matthiaskrgr:rollup-m2rkwqr, r=matthiaskrgr
f520900 
Rollup of 7 pull requests

Successful merges:

 - #148052 (Stabilize `const_mul_add`)
 - #149386 (Display funding link in the github overview)
 - #149489 (Experimentally add *heterogeneous* `try` blocks)
 - #149764 (Make `--print=backend-has-zstd` work by default on any backend)
 - #149838 (Build auxiliary in pretty tests)
 - #149839 (Use `PointeeSized` bound for `TrivialClone` impls)
 - #149846 (Statically require links to an issue or the edition guide for all FCWs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d1e921e into rust-lang:main Dec 10, 2025
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 10, 2025
rust-timer added a commit that referenced this pull request Dec 10, 2025
@rust-timer
Unrolled build for #149764
968821e 
Rollup merge of #149764 - Zalathar:has-zstd, r=bjorn3

Make `--print=backend-has-zstd` work by default on any backend

Using a defaulted `CodegenBackend` method that querying for zstd support should automatically print a safe value of `false` on any backend that doesn't specifically indicate the presence or absence of zstd.

This should fix the compiletest failures reported in #149666 (comment), which can occur when LLVM is not the default codegen backend.
@Zalathar Zalathar deleted the has-zstd branch December 11, 2025 02:12
@github-actions github-actions bot mentioned this pull request Dec 12, 2025
Open
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Dec 13, 2025
@bors
Auto merge of #149853 - matthiaskrgr:rollup-m2rkwqr, r=matthiaskrgr
db96736 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#148052 (Stabilize `const_mul_add`)
 - rust-lang/rust#149386 (Display funding link in the github overview)
 - rust-lang/rust#149489 (Experimentally add *heterogeneous* `try` blocks)
 - rust-lang/rust#149764 (Make `--print=backend-has-zstd` work by default on any backend)
 - rust-lang/rust#149838 (Build auxiliary in pretty tests)
 - rust-lang/rust#149839 (Use `PointeeSized` bound for `TrivialClone` impls)
 - rust-lang/rust#149846 (Statically require links to an issue or the edition guide for all FCWs)

r? `@ghost`
`@rustbot` modify labels: rollup
bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Dec 18, 2025
@matthiaskrgr
Rollup merge of rust-lang#149764 - Zalathar:has-zstd, r=bjorn3
51e8b6e 
Make `--print=backend-has-zstd` work by default on any backend

Using a defaulted `CodegenBackend` method that querying for zstd support should automatically print a safe value of `false` on any backend that doesn't specifically indicate the presence or absence of zstd.

This should fix the compiletest failures reported in rust-lang#149666 (comment), which can occur when LLVM is not the default codegen backend.
@rust-timer rust-timer mentioned this pull request Dec 18, 2025
Merged
Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request Dec 29, 2025
@bors
Auto merge of #149853 - matthiaskrgr:rollup-m2rkwqr, r=matthiaskrgr
5f09964 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#148052 (Stabilize `const_mul_add`)
 - rust-lang/rust#149386 (Display funding link in the github overview)
 - rust-lang/rust#149489 (Experimentally add *heterogeneous* `try` blocks)
 - rust-lang/rust#149764 (Make `--print=backend-has-zstd` work by default on any backend)
 - rust-lang/rust#149838 (Build auxiliary in pretty tests)
 - rust-lang/rust#149839 (Use `PointeeSized` bound for `TrivialClone` impls)
 - rust-lang/rust#149846 (Statically require links to an issue or the edition guide for all FCWs)

r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #149853 - matthiaskrgr:rollup-m2rkwqr, r=matthiaskrgr
46a6f5f 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#148052 (Stabilize `const_mul_add`)
 - rust-lang/rust#149386 (Display funding link in the github overview)
 - rust-lang/rust#149489 (Experimentally add *heterogeneous* `try` blocks)
 - rust-lang/rust#149764 (Make `--print=backend-has-zstd` work by default on any backend)
 - rust-lang/rust#149838 (Build auxiliary in pretty tests)
 - rust-lang/rust#149839 (Use `PointeeSized` bound for `TrivialClone` impls)
 - rust-lang/rust#149846 (Statically require links to an issue or the edition guide for all FCWs)

r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #149853 - matthiaskrgr:rollup-m2rkwqr, r=matthiaskrgr
f53740b 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#148052 (Stabilize `const_mul_add`)
 - rust-lang/rust#149386 (Display funding link in the github overview)
 - rust-lang/rust#149489 (Experimentally add *heterogeneous* `try` blocks)
 - rust-lang/rust#149764 (Make `--print=backend-has-zstd` work by default on any backend)
 - rust-lang/rust#149838 (Build auxiliary in pretty tests)
 - rust-lang/rust#149839 (Use `PointeeSized` bound for `TrivialClone` impls)
 - rust-lang/rust#149846 (Statically require links to an issue or the edition guide for all FCWs)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bjorn3 bjorn3

Labels

A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Zalathar @rustbot @bjorn3 @fee1-dead @bors