Tidying up tests/ui/issues 33 tests [4/N]#149767

reddevilmidzy · 2025-12-08T12:21:21Z

Note

Intermediate commits are intended to help review, but will be squashed add comment commit prior to merge.

tests/ui/compile-flags split it into tests/ui/compile-flags/invalid/ and tests/ui/compile-flags/run-pass/

r? Kivooeo

rustbot · 2025-12-08T12:21:25Z

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

reddevilmidzy

thanks for the review and I wanted to ask: how many tests per PR would be most convenient for you to review?

View changes since this review

tests/ui/extern/extern-rust-trait-method.rs

tests/ui/resolve/module-used-as-struct-constructor.rs

Kivooeo · 2025-12-08T18:24:06Z

tests/ui/compile-flags/run-pass/repeated-debug-opt-flags.rs

I'm not sure if there a directory for tests that test a CLI options passed to compiler like in this case

There was an invalid-compile-flags directory, but no directory like run-pass compile flags

let's do tests/ui/compile-flags and split it into ui/compile-flags/invalid/ and ui/compile-flags/run-pass/

Kivooeo · 2025-12-08T18:27:02Z

tests/ui/typeck/osstring-str-equality.rs

It seems like type check something

moved to tests/ui/typeck/osstring-str-equality.rs

Kivooeo · 2025-12-08T18:29:21Z

tests/ui/resolve/module-used-as-struct-constructor.rs

anything else resolve related

Yep moved to tests/ui/resolve/module-used-as-struct-constructor.rs

Kivooeo · 2025-12-08T18:33:11Z

tests/ui/pattern/match-at-pattern-shadows-name.rs

I feel like it more pattern directory, or even shadowing

Yes, I moved it to the pattern directory. and the test below moved it to the shadowing directory

Kivooeo · 2025-12-08T18:34:11Z

tests/ui/shadowed/match-binding-shadows-const.rs

the same as above but it looks like more shadowing

this test wasn't moved?

Oh, I missed it sorry

Kivooeo · 2025-12-08T18:47:02Z

Everything else is fine

For the tests amount I would say that 15+- is very comfortable to review

If you want to do more that's fine as well, just might take more time but I have nothing against it

reddevilmidzy · 2025-12-10T01:36:15Z

Can you please replace issue numbers with links, so it will be easier anytime in future to follow them by just copy paste

I saw the comment left on another PR. I will change # to link!

regex is awesome..

Kivooeo · 2025-12-11T21:17:06Z

I'll take a last look before merge tomorrow, sorry for delay

Kivooeo

Squash commits except first

View changes since this review

Split invalid-compile-flags into run-pass & invalid Update tests/ui/README.md

Kivooeo · 2025-12-16T13:05:14Z

@bors r+ rollup

bors · 2025-12-16T13:05:17Z

📌 Commit 1bd997a has been approved by Kivooeo

It is now in the queue for this repository.

…uwer Rollup of 11 pull requests Successful merges: - #147939 (Make `const BorrowMut` require `const Borrow` and make `const Fn` require `const FnMut`) - #149734 (Mirror GCC 9.5.0) - #149767 (Tidying up tests/ui/issues 33 tests [4/N]) - #149804 (chore: fix some minor issues in the comments) - #149967 (custom `VaList` layout for Hexagon) - #150025 (dont create unnecessary `DefId`s under mgca) - #150032 (Use annotate-snippet as default emitter on stable) - #150033 (Add try_as_dyn and try_as_dyn_mut) - #150042 (rustc-dev-guide subtree update) - #150063 (Remove deny of manual-let-else) - #150064 (std: io: error: Add comment for UEFI unpacked repr use) Failed merges: - #150044 (Avoid unhelpful suggestion when crate name is invalid) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #149767 - reddevilmidzy:t11, r=Kivooeo Tidying up tests/ui/issues 33 tests [4/N] > [!NOTE] > Intermediate commits are intended to help review, but will be squashed add comment commit prior to merge. part of #133895 `tests/ui/compile-flags` split it into `tests/ui/compile-flags/invalid/` and `tests/ui/compile-flags/run-pass/` r? Kivooeo

…uwer Rollup of 11 pull requests Successful merges: - rust-lang/rust#147939 (Make `const BorrowMut` require `const Borrow` and make `const Fn` require `const FnMut`) - rust-lang/rust#149734 (Mirror GCC 9.5.0) - rust-lang/rust#149767 (Tidying up tests/ui/issues 33 tests [4/N]) - rust-lang/rust#149804 (chore: fix some minor issues in the comments) - rust-lang/rust#149967 (custom `VaList` layout for Hexagon) - rust-lang/rust#150025 (dont create unnecessary `DefId`s under mgca) - rust-lang/rust#150032 (Use annotate-snippet as default emitter on stable) - rust-lang/rust#150033 (Add try_as_dyn and try_as_dyn_mut) - rust-lang/rust#150042 (rustc-dev-guide subtree update) - rust-lang/rust#150063 (Remove deny of manual-let-else) - rust-lang/rust#150064 (std: io: error: Add comment for UEFI unpacked repr use) Failed merges: - rust-lang/rust#150044 (Avoid unhelpful suggestion when crate name is invalid) r? `@ghost` `@rustbot` modify labels: rollup

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 8, 2025

rustbot assigned Kivooeo Dec 8, 2025

reddevilmidzy changed the title ~~Tidying up tests/ui/issues tests [4/N]~~ Tidying up tests/ui/issues 33 tests [4/N] Dec 8, 2025

reddevilmidzy commented Dec 8, 2025

View reviewed changes

tests/ui/extern/extern-rust-trait-method.rs Show resolved Hide resolved

tests/ui/resolve/module-used-as-struct-constructor.rs Outdated Show resolved Hide resolved

Kivooeo reviewed Dec 8, 2025

View reviewed changes

reddevilmidzy force-pushed the t11 branch from d0c7443 to 94fd14c Compare December 9, 2025 05:57

moved tests

92f21a8

reddevilmidzy force-pushed the t11 branch from 94fd14c to 66337ca Compare December 10, 2025 01:22

reddevilmidzy force-pushed the t11 branch from 66337ca to 0606801 Compare December 10, 2025 02:08

Kivooeo approved these changes Dec 13, 2025

View reviewed changes

Cleaned up some tests

1bd997a

Split invalid-compile-flags into run-pass & invalid Update tests/ui/README.md

reddevilmidzy force-pushed the t11 branch from 0606801 to 1bd997a Compare December 15, 2025 17:10

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2025

JonathanBrouwer mentioned this pull request Dec 16, 2025

Rollup of 11 pull requests #150068

Merged

bors merged commit f108cd7 into rust-lang:main Dec 17, 2025
11 checks passed

rustbot added this to the 1.94.0 milestone Dec 17, 2025

reddevilmidzy deleted the t11 branch December 17, 2025 02:42

reddevilmidzy mentioned this pull request Dec 26, 2025

Add comment when new directory is added to tests/ui #150399

Closed

Uh oh!

Conversation

reddevilmidzy commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Dec 8, 2025

Uh oh!

reddevilmidzy left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kivooeo Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kivooeo Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kivooeo commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reddevilmidzy commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kivooeo commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kivooeo left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kivooeo commented Dec 16, 2025

Uh oh!

bors commented Dec 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

reddevilmidzy commented Dec 8, 2025 •

edited

Loading

reddevilmidzy left a comment •

edited by rustbot

Loading

Kivooeo Dec 8, 2025 •

edited

Loading

Kivooeo Dec 8, 2025 •

edited

Loading

Kivooeo commented Dec 8, 2025 •

edited

Loading

reddevilmidzy commented Dec 10, 2025 •

edited

Loading

Kivooeo commented Dec 11, 2025 •

edited

Loading

Kivooeo left a comment •

edited by rustbot

Loading