Skip to content

Port #[rustc_lint_untracked_query_information] and #[rustc_lint_diagnostics] to using attribute parsers#150127

Merged
bors merged 2 commits intorust-lang:mainfrom
Bryntet:parse_rustc_lint_untracked_query_information
Dec 19, 2025
Merged

Port #[rustc_lint_untracked_query_information] and #[rustc_lint_diagnostics] to using attribute parsers#150127
bors merged 2 commits intorust-lang:mainfrom
Bryntet:parse_rustc_lint_untracked_query_information

Conversation

@Bryntet
Copy link
Contributor

@Bryntet Bryntet commented Dec 18, 2025

@rustbot
Copy link
Collaborator

rustbot commented Dec 18, 2025

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 18, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Bryntet Bryntet force-pushed the parse_rustc_lint_untracked_query_information branch 3 times, most recently from fbaf07c to 853216a Compare December 18, 2025 13:25
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Dec 18, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 18, 2025

📌 Commit 853216a has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Dec 18, 2025

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 18, 2025
Closed
bors added a commit that referenced this pull request Dec 18, 2025
@bors
Auto merge of #150132 - JonathanBrouwer:rollup-8ijhb7l, r=JonathanBro…
567c266 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #145933 (Expand `str_as_str` to more types)
 - #148849 (Set -Cpanic=abort in windows-msvc stack protector tests)
 - #149925 (`cfg_select!`: parse unused branches)
 - #150022 (Generate macro expansion for rust compiler crates docs)
 - #150024 (Support recursive delegation)
 - #150048 (std_detect: AArch64 Darwin: expose SME F16F16 and B16B16 features)
 - #150083 (tests/run-make-cargo/same-crate-name-and-macro-name: New regression test)
 - #150102 (Fixed ICE for EII with multiple defaults due to duplicate definition in nameres)
 - #150124 (unstable.rs: fix typos in comments (implementatble -> implementable))
 - #150125 (Port `#[rustc_lint_opt_deny_field_access]` to attribute parser)
 - #150126 (Subtree sync for rustc_codegen_cranelift)

Failed merges:

 - #150127 (Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers)

r? `@ghost`
`@rustbot` modify labels: rollup
@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 18, 2025
Merged
bors added a commit that referenced this pull request Dec 18, 2025
@bors
Auto merge of #150135 - JonathanBrouwer:rollup-pn911bj, r=JonathanBro…
fcf67da 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #145933 (Expand `str_as_str` to more types)
 - #148849 (Set -Cpanic=abort in windows-msvc stack protector tests)
 - #149925 (`cfg_select!`: parse unused branches)
 - #149952 (Suggest struct pattern when destructuring Range with .. syntax)
 - #150022 (Generate macro expansion for rust compiler crates docs)
 - #150024 (Support recursive delegation)
 - #150048 (std_detect: AArch64 Darwin: expose SME F16F16 and B16B16 features)
 - #150083 (tests/run-make-cargo/same-crate-name-and-macro-name: New regression test)
 - #150102 (Fixed ICE for EII with multiple defaults due to duplicate definition in nameres)
 - #150124 (unstable.rs: fix typos in comments (implementatble -> implementable))
 - #150125 (Port `#[rustc_lint_opt_deny_field_access]` to attribute parser)
 - #150126 (Subtree sync for rustc_codegen_cranelift)

Failed merges:

 - #150127 (Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers)

r? `@ghost`
`@rustbot` modify labels: rollup
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Dec 18, 2025

@bors r-
has conflicts

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 18, 2025
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Dec 18, 2025 •
edited
Loading

@bors delegate+
r=me after rebasing

@bors
Copy link
Collaborator

bors commented Dec 18, 2025

✌️ @Bryntet, you can now approve this pull request!

If @JonathanBrouwer told you to "r=me" after making some further change, please make that change, then do @bors r=@JonathanBrouwer

@Bryntet Bryntet force-pushed the parse_rustc_lint_untracked_query_information branch from 853216a to 44cfed7 Compare December 18, 2025 22:36
@rustbot
Copy link
Collaborator

rustbot commented Dec 18, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Bryntet
Copy link
Contributor Author

Bryntet commented Dec 18, 2025

@bors r=@JonathanBrouwer

@bors
Copy link
Collaborator

bors commented Dec 18, 2025

📌 Commit 44cfed7 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 18, 2025
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Dec 19, 2025
@JonathanBrouwer
Rollup merge of rust-lang#150127 - Bryntet:parse_rustc_lint_untracked…
d5adb7b 
…_query_information, r=JonathanBrouwer

Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers

r? `@JonathanBrouwer`
@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 19, 2025
Closed
bors added a commit that referenced this pull request Dec 19, 2025
@bors
Auto merge of #150146 - JonathanBrouwer:rollup-s1jdwck, r=JonathanBro…
1af0b65 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #147430 (cg_llvm: More preparation for moving FFI bindings to `rustc_llvm`)
 - #149815 (Add regression test for #120189)
 - #149947 (add several older crashtests)
 - #150127 (Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 19, 2025
Merged
bors added a commit that referenced this pull request Dec 19, 2025
@bors
Auto merge of #150147 - matthiaskrgr:rollup-8zp68z1, r=matthiaskrgr
d7b1d36 
Rollup of 3 pull requests

Successful merges:

 - #147430 (cg_llvm: More preparation for moving FFI bindings to `rustc_llvm`)
 - #149815 (Add regression test for #120189)
 - #150127 (Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Dec 19, 2025
@bors
Auto merge of #150147 - matthiaskrgr:rollup-8zp68z1, r=matthiaskrgr
0f0d850 
Rollup of 3 pull requests

Successful merges:

 - #147430 (cg_llvm: More preparation for moving FFI bindings to `rustc_llvm`)
 - #149815 (Add regression test for #120189)
 - #150127 (Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers)

r? `@ghost`
`@rustbot` modify labels: rollup
@jdonszelmann jdonszelmann mentioned this pull request Dec 19, 2025
Open
9 tasks
@bors bors merged commit 0e623bb into rust-lang:main Dec 19, 2025
11 checks passed
rust-timer added a commit that referenced this pull request Dec 19, 2025
@rust-timer
Unrolled build for #150127
0590728 
Rollup merge of #150127 - Bryntet:parse_rustc_lint_untracked_query_information, r=JonathanBrouwer

Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers

r? ``@JonathanBrouwer``
@rustbot rustbot added this to the 1.94.0 milestone Dec 19, 2025
@github-actions github-actions bot mentioned this pull request Dec 23, 2025
Open
Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request Dec 29, 2025
@bors
Auto merge of #150135 - JonathanBrouwer:rollup-pn911bj, r=JonathanBro…
b84ff1f 
…uwer

Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#145933 (Expand `str_as_str` to more types)
 - rust-lang/rust#148849 (Set -Cpanic=abort in windows-msvc stack protector tests)
 - rust-lang/rust#149925 (`cfg_select!`: parse unused branches)
 - rust-lang/rust#149952 (Suggest struct pattern when destructuring Range with .. syntax)
 - rust-lang/rust#150022 (Generate macro expansion for rust compiler crates docs)
 - rust-lang/rust#150024 (Support recursive delegation)
 - rust-lang/rust#150048 (std_detect: AArch64 Darwin: expose SME F16F16 and B16B16 features)
 - rust-lang/rust#150083 (tests/run-make-cargo/same-crate-name-and-macro-name: New regression test)
 - rust-lang/rust#150102 (Fixed ICE for EII with multiple defaults due to duplicate definition in nameres)
 - rust-lang/rust#150124 (unstable.rs: fix typos in comments (implementatble -> implementable))
 - rust-lang/rust#150125 (Port `#[rustc_lint_opt_deny_field_access]` to attribute parser)
 - rust-lang/rust#150126 (Subtree sync for rustc_codegen_cranelift)

Failed merges:

 - rust-lang/rust#150127 (Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers)

r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #150135 - JonathanBrouwer:rollup-pn911bj, r=JonathanBro…
c1edabb 
…uwer

Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#145933 (Expand `str_as_str` to more types)
 - rust-lang/rust#148849 (Set -Cpanic=abort in windows-msvc stack protector tests)
 - rust-lang/rust#149925 (`cfg_select!`: parse unused branches)
 - rust-lang/rust#149952 (Suggest struct pattern when destructuring Range with .. syntax)
 - rust-lang/rust#150022 (Generate macro expansion for rust compiler crates docs)
 - rust-lang/rust#150024 (Support recursive delegation)
 - rust-lang/rust#150048 (std_detect: AArch64 Darwin: expose SME F16F16 and B16B16 features)
 - rust-lang/rust#150083 (tests/run-make-cargo/same-crate-name-and-macro-name: New regression test)
 - rust-lang/rust#150102 (Fixed ICE for EII with multiple defaults due to duplicate definition in nameres)
 - rust-lang/rust#150124 (unstable.rs: fix typos in comments (implementatble -> implementable))
 - rust-lang/rust#150125 (Port `#[rustc_lint_opt_deny_field_access]` to attribute parser)
 - rust-lang/rust#150126 (Subtree sync for rustc_codegen_cranelift)

Failed merges:

 - rust-lang/rust#150127 (Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers)

r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #150135 - JonathanBrouwer:rollup-pn911bj, r=JonathanBro…
e54f30b 
…uwer

Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#145933 (Expand `str_as_str` to more types)
 - rust-lang/rust#148849 (Set -Cpanic=abort in windows-msvc stack protector tests)
 - rust-lang/rust#149925 (`cfg_select!`: parse unused branches)
 - rust-lang/rust#149952 (Suggest struct pattern when destructuring Range with .. syntax)
 - rust-lang/rust#150022 (Generate macro expansion for rust compiler crates docs)
 - rust-lang/rust#150024 (Support recursive delegation)
 - rust-lang/rust#150048 (std_detect: AArch64 Darwin: expose SME F16F16 and B16B16 features)
 - rust-lang/rust#150083 (tests/run-make-cargo/same-crate-name-and-macro-name: New regression test)
 - rust-lang/rust#150102 (Fixed ICE for EII with multiple defaults due to duplicate definition in nameres)
 - rust-lang/rust#150124 (unstable.rs: fix typos in comments (implementatble -> implementable))
 - rust-lang/rust#150125 (Port `#[rustc_lint_opt_deny_field_access]` to attribute parser)
 - rust-lang/rust#150126 (Subtree sync for rustc_codegen_cranelift)

Failed merges:

 - rust-lang/rust#150127 (Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Bryntet @rustbot @rust-log-analyzer @JonathanBrouwer @bors