Skip to content

Constify fmt::from_fn#150300

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
EFanZh:patch-1
Feb 1, 2026
Merged

Constify fmt::from_fn#150300
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
EFanZh:patch-1

Conversation

@EFanZh
Copy link
Contributor

@EFanZh EFanZh commented Dec 23, 2025

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 23, 2025

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GKFX
Copy link
Contributor

GKFX commented Dec 23, 2025

Is this going to be on its own feature flag (which I think will require its own tracking issue)? Although it's a minor change, I would expect it's too late to include it in fmt_from_fn as that would need to be backported into the currrent beta (1.93).

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@tgross35
Copy link
Contributor

tgross35 commented Dec 28, 2025

@rustbot label +I-libs-api-nominated +needs-fcp

Nominating for @rust-lang/libs-api since this is insta-stable as written. I don't think there would be much benefit to going through a const-unstable period here.

@rustbot rustbot added I-libs-api-nominated Nominated for discussion during a libs-api team meeting. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. labels Dec 28, 2025
@tgross35 tgross35 added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 28, 2025
@dtolnay
Copy link
Member

dtolnay commented Dec 28, 2025

@rfcbot fcp merge libs-api

@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Dec 28, 2025 •
edited by Amanieu
Loading

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rust-rfcbot rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Dec 28, 2025
@dtolnay dtolnay removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Dec 28, 2025
@scottmcm scottmcm assigned dtolnay and unassigned scottmcm Jan 9, 2026
@rust-rfcbot rust-rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jan 21, 2026
@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Jan 21, 2026

🔔 This is now entering its final comment period, as per the review above. 🔔

@rust-rfcbot rust-rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jan 31, 2026
@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Jan 31, 2026

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

@rustbot rustbot mentioned this pull request Jan 31, 2026
Open
tgross35
tgross35 approved these changes Jan 31, 2026
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r=dtolnay,tgross35 rollup

View changes since this review

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 31, 2026

📌 Commit df25df1 has been approved by dtolnay,tgross35

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 31, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 31, 2026
@bors
Auto merge of #151924 - JonathanBrouwer:rollup-Pqp8PIn, r=JonathanBro…
a1db344 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #151886 (Skip unused_allocation lint when method takes &Box<Self>)
 - #150300 (Constify `fmt::from_fn`)
 - #151102 (Feature-gate `mut ref` patterns in struct pattern field shorthand)
 - #151866 (Reorganizing `tests/ui/issues` 10 tests [4/N] )
 - #151890 (Re-export `hashbrown::hash_table` from `rustc_data_structures`)
@rust-bors rust-bors bot merged commit f580ca8 into rust-lang:main Feb 1, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 1, 2026
rust-timer added a commit that referenced this pull request Feb 1, 2026
@rust-timer
Unrolled build for #150300
06baec6 
Rollup merge of #150300 - EFanZh:patch-1, r=dtolnay,tgross35

Constify `fmt::from_fn`

See <#117729 (comment)>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnay dtolnay dtolnay approved these changes

@tgross35 tgross35 tgross35 approved these changes

Assignees

@dtolnay dtolnay

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

8 participants

@EFanZh @rustbot @rust-log-analyzer @GKFX @tgross35 @dtolnay @rust-rfcbot @scottmcm