Check `ConstArgHasType` goals even when not wfchecking#150322

BoxyUwU · 2025-12-23T22:48:33Z

r? types

rustbot · 2025-12-23T22:48:36Z

changes to the core type system

BoxyUwU · 2025-12-23T22:50:28Z

compiler/rustc_hir_analysis/src/check/wfcheck.rs

+    enter_wf_checking_ctxt_inner(tcx, body_def_id, !tcx.features().trivial_bounds(), f)
+}
+
+pub(super) fn enter_wf_checking_ctxt_without_checking_global_bounds<'tcx, F>(


it seems suboptimal to me that we implicitly check things about the where clauses of an item just from creating a wfcx. ideally this would happen as part of actually checking the where clauses or something?

BoxyUwU · 2025-12-23T22:50:54Z

@bors try

Check `ConstArgHasType` goals even when not wfchecking

BoxyUwU · 2025-12-23T22:51:04Z

needs a crater run + fcp

rust-bors · 2025-12-23T23:27:31Z

💔 Test for d15b493 failed: CI. Failed jobs:

try - dist-x86_64-linux (web logs, enhanced plaintext logs)

BoxyUwU · 2025-12-24T00:49:11Z

crazy, completely flipped one of the like two conditions in this PR by accident

@bors try

Check `ConstArgHasType` goals even when not wfchecking

rust-bors · 2025-12-24T03:01:22Z

☀️ Try build successful (CI)
Build commit: e983148 (e983148bd5f0f0db270bfb72149f5e892e68b67f, parent: 2ca7bcd03b87b52f7055a59b817443b0ac4a530d)

BoxyUwU · 2025-12-24T03:37:20Z

compiler/rustc_trait_selection/src/traits/wf.rs

        debug!(?self.out);
    }

-    #[instrument(level = "debug", skip(self))]


dont yeet this

BoxyUwU · 2025-12-24T03:37:48Z

@craterbot check

craterbot · 2025-12-24T03:38:10Z

👌 Experiment pr-150322 created and queued.
🤖 Automatically detected try build e983148
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2026-01-01T06:34:24Z

🚧 Experiment pr-150322 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2026-01-02T21:52:07Z

🎉 Experiment pr-150322 is completed!
📊 8 regressed and 5 fixed (766471 total)
📊 2036 spurious results on the retry-regressed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-150322/retry-regressed-list.txt ↩

BoxyUwU · 2026-01-02T22:12:01Z

@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-150322/retry-regressed-list.txt

craterbot · 2026-01-02T22:12:09Z

👌 Experiment pr-150322-1 created and queued.
🤖 Automatically detected try build e983148
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

BoxyUwU · 2026-01-02T22:12:42Z

damn people are actually relying on this :(

lcnr · 2026-01-05T15:28:55Z

"relying on this" 😅 people actually have incorrect unused type aliases in their code xd

BoxyUwU · 2026-01-05T15:35:01Z

technically they can be used because you can do sth like type Foo<const N: u8> = [(); N]; fn foo<const N: usize>() -> Foo<N> {} and I think it'll work

craterbot · 2026-01-06T00:16:01Z

🚧 Experiment pr-150322-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2026-01-06T03:39:15Z

🎉 Experiment pr-150322-1 is completed!
📊 5 regressed and 0 fixed (1937 total)
📊 150 spurious results on the retry-regressed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-150322-1/retry-regressed-list.txt ↩

BoxyUwU · 2026-01-23T12:15:32Z

compiler/rustc_trait_selection/src/traits/wf.rs

    }

-    fn add_wf_preds_for_dyn_ty(
+    fn nominal_obligations_not_referencing_self(


instantiate_identity the preds then walk for Self#0 then wrap in an early binder and instantiate a second time?

or why am i even filtering to stuff not involving Self i dont remember, should just be able to use the object type to instantiate Self ...

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 23, 2025

rustbot assigned lcnr Dec 23, 2025

BoxyUwU commented Dec 23, 2025

View reviewed changes

rust-bors bot added a commit that referenced this pull request Dec 23, 2025

Auto merge of #150322 - BoxyUwU:check_const_types_without_wfck, r=<try>

d15b493

Check `ConstArgHasType` goals even when not wfchecking

This comment has been minimized.

Sign in to view

Check ConstArgHasType goals even when not wfchecking

1b22adb

BoxyUwU force-pushed the check_const_types_without_wfck branch from ef323a1 to 1b22adb Compare December 24, 2025 00:48

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Dec 24, 2025

Auto merge of #150322 - BoxyUwU:check_const_types_without_wfck, r=<try>

e983148

Check `ConstArgHasType` goals even when not wfchecking

BoxyUwU commented Dec 24, 2025

View reviewed changes

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2025

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 2, 2026

craterbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 2, 2026

craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jan 2, 2026

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 6, 2026

BoxyUwU commented Jan 23, 2026

View reviewed changes

BoxyUwU added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2026

Uh oh!

Conversation

BoxyUwU commented Dec 23, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Dec 23, 2025

Uh oh!

BoxyUwU Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

BoxyUwU commented Dec 23, 2025

Uh oh!

This comment has been minimized.

BoxyUwU commented Dec 23, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Dec 23, 2025

Uh oh!

BoxyUwU commented Dec 24, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Dec 24, 2025

Uh oh!

BoxyUwU Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

BoxyUwU commented Dec 24, 2025

Uh oh!

craterbot commented Dec 24, 2025

Uh oh!

craterbot commented Jan 1, 2026

Uh oh!

craterbot commented Jan 2, 2026

Footnotes

Uh oh!

BoxyUwU commented Jan 2, 2026

Uh oh!

craterbot commented Jan 2, 2026

Uh oh!

BoxyUwU commented Jan 2, 2026

Uh oh!

lcnr commented Jan 5, 2026

Uh oh!

BoxyUwU commented Jan 5, 2026

Uh oh!

craterbot commented Jan 6, 2026

Uh oh!

craterbot commented Jan 6, 2026

Footnotes

Uh oh!

BoxyUwU Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

BoxyUwU Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

BoxyUwU commented Dec 23, 2025 •

edited by rustbot

Loading