Skip to content

xous: fix build due to function and feature name changes#150363

Merged
bors merged 2 commits intorust-lang:mainfrom
betrusted-io:xous-misc-fixes
Dec 29, 2025
Merged

xous: fix build due to function and feature name changes#150363
bors merged 2 commits intorust-lang:mainfrom
betrusted-io:xous-misc-fixes

Conversation

@xobs
Copy link
Contributor

@xobs xobs commented Dec 25, 2025

This tracks a rename of panic_unwind to panic-unwind, as well as the removal of abort_internal as a function.

This also fixes an incorrect function name from when rust_main_thread_not_inlined was added.

xobs added 2 commits December 25, 2025 13:46
The unwinding feature is called `panic-unwind` and not `panic_unwind`.
Adjust the feature gate to look for these values.

Additionally, the `abort_internal()` call is no longer used.

Signed-off-by: Sean Cross <sean@xobs.io>
This function was incorrectly called run_main_thread_not_inlined when
invoked.

Signed-off-by: Sean Cross <sean@xobs.io>
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 25, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 25, 2025

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@xobs xobs changed the title Xous misc fixes xous: fix build and add path support Dec 25, 2025
@xobs xobs changed the title xous: fix build and add path support xous: fix build due to function and package name changes Dec 25, 2025
@xobs
Copy link
Contributor Author

xobs commented Dec 25, 2025

This is a version of #149506 but without the Path changes, which will be sent as part of a separate PR.

@xobs xobs changed the title xous: fix build due to function and package name changes xous: fix build due to function and feature name changes Dec 25, 2025
@jhpratt
Copy link
Member

jhpratt commented Dec 29, 2025

As you're the target maintainer, I'm assuming the change is correct as nothing is obviously incorrect.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 29, 2025

📌 Commit 41fe03a has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2025
bors added a commit that referenced this pull request Dec 29, 2025
Rollup of 2 pull requests

Successful merges:

 - #150178 (std: Motor OS: switch to moto-rt v0.16.0)
 - #150363 (xous: fix build due to function and feature name changes)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3fc0f58 into rust-lang:main Dec 29, 2025
11 checks passed
rust-timer added a commit that referenced this pull request Dec 29, 2025
Rollup merge of #150363 - betrusted-io:xous-misc-fixes, r=jhpratt

xous: fix build due to function and feature name changes

This tracks a rename of `panic_unwind` to `panic-unwind`, as well as the removal of `abort_internal` as a function.

This also fixes an incorrect function name from when `rust_main_thread_not_inlined` was added.
@rustbot rustbot added this to the 1.94.0 milestone Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments