Skip to content

cleanup: move c-variadic arguments handling into compute_inputs_and_output #150454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Jan 1, 2026
Merged

cleanup: move c-variadic arguments handling into compute_inputs_and_output #150454

bors merged 1 commit into from
Jan 1, 2026
+39 −35

Conversation

@tiif
Copy link
Member

@tiif tiif commented Dec 28, 2025

Previously, unnormalized_input_tys needs to be mutable because the c_variadic arguments are added to unnormalized_input_tys outside of compute_inputs_and_output. This could have been done together in compute_inputs_and_output.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 28, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

oli-obk
oli-obk requested changes Dec 28, 2025
View reviewed changes
Copy link
Contributor

@oli-obk oli-obk left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, then r=me

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Dec 28, 2025

r? oli-obk

@rustbot rustbot assigned oli-obk and unassigned petrochenkov Dec 28, 2025
@tiif tiif added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 30, 2025
@tiif
Copy link
Member Author

tiif commented Jan 1, 2026

@bors r=oli-obk rollup

@bors
Copy link
Collaborator

bors commented Jan 1, 2026

📌 Commit 791fa37 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 1, 2026
Merged
bors added a commit that referenced this pull request Jan 1, 2026
@bors
Auto merge of #150563 - JonathanBrouwer:rollup-9ncjbou, r=JonathanBro…
cc08b55 
…uwer

Rollup of 2 pull requests

Successful merges:

 - #150454 (cleanup: move c-variadic arguments handling into compute_inputs_and_output)
 - #150529 (Update books)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 36457ce into rust-lang:main Jan 1, 2026
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 1, 2026
rust-timer added a commit that referenced this pull request Jan 1, 2026
@rust-timer
Unrolled build for #150454
3c87aab 
Rollup merge of #150454 - tiif:move_variadic, r=oli-obk

cleanup: move c-variadic arguments handling into compute_inputs_and_output

Previously, ``unnormalized_input_tys`` needs to be mutable because the c_variadic arguments are added to ``unnormalized_input_tys`` outside of ``compute_inputs_and_output``. This could have been done together in ``compute_inputs_and_output``.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obk oli-obk oli-obk requested changes

Assignees

@oli-obk oli-obk

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

5 participants

@tiif @rustbot @oli-obk @bors @petrochenkov