fix running stdlib doctests in Miri in CI#150458
Conversation
| $(BOOTSTRAP) miri --stage 2 \ | ||
| library/coretests \ | ||
| library/alloctests \ | ||
| library/core \ |
There was a problem hiding this comment.
This is wired up to run the tests from the separate crates, right?
There was a problem hiding this comment.
I don't think that is implemented for ./x.py miri. ./x.py test has this code:
rust/src/bootstrap/src/core/build_steps/test.rs
Lines 3111 to 3120 in 9f54abe
./x.py miri doesn't.
There was a problem hiding this comment.
That code also runs for ./x miri though?
There was a problem hiding this comment.
I tried ./x miri library/core -- mem and it said
Running tests/lib.rs (build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/debug/deps/coretests-d8eae4d2db388c62)
running 71 tests
.......................................................................
test result: ok. 71 passed; 0 failed; 0 ignored; 0 measured; 2201 filtered out; finished in 24.46s
Running benches/lib.rs (build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/debug/deps/corebenches-41b71a0680fbdcd6)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 29.49ms
Doc-tests core
running 113 tests
........................................................................................ 88/113
.........................
test result: ok. 113 passed; 0 failed; 0 ignored; 0 measured; 5467 filtered out; finished in 2.43s
all doctests ran in 2.50s; merged doctests compilation took 0.04s
Doc-tests coretests
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 12.47µs
finished in 55.808 seconds
That looks good to me?
There was a problem hiding this comment.
Indeed. I was looking at build_steps::test::Miri, which is for ./x.py test src/tools/miri, not ./x.py miri.
|
@bors try jobs=miri |
This comment has been minimized.
This comment has been minimized.
fix running doctests in Miri try-job: *miri*
|
That is very strange, I expected the try build to fail since there's a broken doctest... |
a4b4cd5 to
391c819
Compare
|
Oh wait, that was the wrong job. @bors try jobs=aux |
This comment has been minimized.
This comment has been minimized.
fix running doctests in Miri try-job: *aux*
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test for 8c1f4ee failed: CI. Failed jobs:
|
|
Nice. And now it should be fixed. @bors try jobs=aux |
This comment has been minimized.
This comment has been minimized.
fix running doctests in Miri try-job: *aux*
|
@bors r+ |
fix running stdlib doctests in Miri in CI r? ``@bjorn3``
Rollup of 6 pull requests Successful merges: - #150108 (Offload: Build offload as a single Step) - #150262 (slice iter cleanup: replace checked_sub with saturating_sub) - #150427 (add has_offload/needs-offload to the test infra) - #150458 (fix running stdlib doctests in Miri in CI) - #150477 (Fix enum variant suggestion consuming trailing parenthesis) - #150478 (Fix new bors config) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #150458 - RalfJung:miri-doctests, r=bjorn3 fix running stdlib doctests in Miri in CI r? `@bjorn3`
Rollup of 6 pull requests Successful merges: - rust-lang/rust#150108 (Offload: Build offload as a single Step) - rust-lang/rust#150262 (slice iter cleanup: replace checked_sub with saturating_sub) - rust-lang/rust#150427 (add has_offload/needs-offload to the test infra) - rust-lang/rust#150458 (fix running stdlib doctests in Miri in CI) - rust-lang/rust#150477 (Fix enum variant suggestion consuming trailing parenthesis) - rust-lang/rust#150478 (Fix new bors config) r? `@ghost` `@rustbot` modify labels: rollup
r? @bjorn3