Document panic! in Iterator::last for #149707
#150580
Merged
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a `# Panics` section to `Iterator::last` to match `Iterator::count`, after the change made in Rust 1.92.0 where now `std::iter::Repeat` panics in these methods instead of doing an infinite `loop`. Cites rust-lang#149707
rustbot
added
S-waiting-on-review
Collaborator
jhpratt
reviewed
Jan 2, 2026
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
rust-timer
added a commit
that referenced
this pull request
Jan 2, 2026
Rollup merge of #150580 - CieriA:patch-3, r=jhpratt Document `panic!` in `Iterator::last` for #149707 This PR adds a section `# Panics` to the method `Iterator::last` equal to the section `# Panics` of the method `Iterator::count`, because now, after the changes made in Rust 1.92.0, both methods in `std::iter::Repeat` panics instead of doing an infinite loop. `Iterator::count` already has documentation for this behavior ("This function might panic if the iterator has more than `usize::MAX` elements."), but `Iterator::last` does not. This PR adds documentation for this panic in the same way as `Iterator::count` does. Issue: #149707
ollie27
reviewed
Jan 2, 2026
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jan 4, 2026
Clarify panic conditions in `Iterator::last` Follow-up PR to rust-lang#150580. Now `Iterator::last`'s docs specify that it might panic only if the iterator is infinite, rather than if it has more than `usize::MAX` elements. # Motivation This is because `Iterator::last`, unlike `count`, also works on iterators with more than `usize::MAX` elements, but could panic on infinite iterators (as in `Repeat`), as discussed in rust-lang#150580. r? `@jhpratt`
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Jan 4, 2026
Clarify panic conditions in `Iterator::last` Follow-up PR to rust-lang#150580. Now `Iterator::last`'s docs specify that it might panic only if the iterator is infinite, rather than if it has more than `usize::MAX` elements. # Motivation This is because `Iterator::last`, unlike `count`, also works on iterators with more than `usize::MAX` elements, but could panic on infinite iterators (as in `Repeat`), as discussed in rust-lang#150580. r? ``@jhpratt``
rust-timer
added a commit
that referenced
this pull request
Jan 4, 2026
Rollup merge of #150658 - CieriA:patch-5, r=jhpratt Clarify panic conditions in `Iterator::last` Follow-up PR to #150580. Now `Iterator::last`'s docs specify that it might panic only if the iterator is infinite, rather than if it has more than `usize::MAX` elements. # Motivation This is because `Iterator::last`, unlike `count`, also works on iterators with more than `usize::MAX` elements, but could panic on infinite iterators (as in `Repeat`), as discussed in #150580. r? ``@jhpratt``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a section
# Panicsto the methodIterator::lastequal to the section# Panicsof the methodIterator::count, because now, after the changes made in Rust 1.92.0, both methods instd::iter::Repeatpanics instead of doing an infinite loop.Iterator::countalready has documentation for this behavior ("This function might panic if the iterator has more thanusize::MAXelements."), butIterator::lastdoes not. This PR adds documentation for this panic in the same way asIterator::countdoes.Issue: #149707