Skip to content

triagebot: add A-rustdoc-js autolabel #150587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Jan 14, 2026
Merged

triagebot: add A-rustdoc-js autolabel #150587

rust-bors merged 1 commit into from
Jan 14, 2026

Conversation

@AaryanAgrawal96
Copy link
Contributor

@AaryanAgrawal96 AaryanAgrawal96 commented Jan 2, 2026 •
edited by rustbot
Loading

Adds an autolabel rule for rustdoc JavaScript/TypeScript files so PRs touching
rustdoc frontend assets and related tests are automatically labeled A-rustdoc-js.

Fixes #137983

@rustbot
Copy link
Collaborator

rustbot commented Jan 2, 2026

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 2, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

fmease
fmease reviewed Jan 2, 2026
View reviewed changes
@AaryanAgrawal96
Copy link
Contributor Author

AaryanAgrawal96 commented Jan 2, 2026

Done, thanks!

@fmease
Copy link
Member

fmease commented Jan 2, 2026

Thanks, I'll approve after a squash.

@AaryanAgrawal96
Copy link
Contributor Author

AaryanAgrawal96 commented Jan 8, 2026

Friendly ping in case this slipped through, happy to squash or make any changes if needed. Thanks!

@fmease
Copy link
Member

fmease commented Jan 8, 2026

Hey, yes, please squash.

Thanks, I'll approve after a squash.

@AaryanAgrawal96 AaryanAgrawal96 force-pushed the add-rustdoc-js-autolabel branch from 66cd295 to 7668154 Compare January 13, 2026 15:39
@AaryanAgrawal96
Copy link
Contributor Author

AaryanAgrawal96 commented Jan 13, 2026

Done, thanks.

@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Jan 13, 2026

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
............................................       (144/144)

======== tests/rustdoc-gui/notable-trait.goml ========

[ERROR] line 255: expected 0 elements, found 1: for command `assert-count: ("//*[@class='tooltip popover']", 0)`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.NotableStructWithLongName.html#method.create_an_iterator_from_read>

======== tests/rustdoc-gui/search-result-display.goml ========

[WARNING] line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

@fmease
Copy link
Member

fmease commented Jan 13, 2026

CI failure spurious / due to flaky test. See also #151053. Ignoring.

@bors r+ rollup

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 13, 2026

📌 Commit 7668154 has been approved by fmease

It is now in the queue for this repository.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 13, 2026
@GuillaumeGomez
Rollup merge of rust-lang#150587 - add-rustdoc-js-autolabel, r=fmease
bed95e8 
triagebot: add A-rustdoc-js autolabel

Adds an autolabel rule for rustdoc JavaScript/TypeScript files so PRs touching
rustdoc frontend assets and related tests are automatically labeled `A-rustdoc-js`.

Fixes rust-lang#137983
This was referenced Jan 13, 2026
Closed
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 14, 2026
@bors
Auto merge of #151087 - GuillaumeGomez:rollup-vIdiReJ, r=GuillaumeGomez
4931e09 
Rollup of 13 pull requests

Successful merges:

 - #150587 (triagebot: add A-rustdoc-js autolabel)
 - #150677 (Improve std::path::Path::join documentation)
 - #150737 (diagnostics: make implicit Sized bounds explicit in E0277)
 - #150771 (Remove legacy homu `try` and `auto` branch mentions)
 - #150840 (Make `--print=check-cfg` output compatible `--check-cfg` arguments)
 - #150915 (Regression test for type params on eii)
 - #151017 (Port the rustc dump attributes to the attribute parser)
 - #151019 (Make `Type::of` support unsized types)
 - #151031 (Support arrays in type reflection)
 - #151043 (armv7-unknown-linux-uclibceabihf.md: Fix bootstrap.toml syntax)
 - #151052 (ui: add regression test for macro resolution ICE (issue #150711))
 - #151053 (Reduce flakyness for `tests/rustdoc-gui/notable-trait.goml`)
 - #151055 (Emit error instead of delayed bug when meeting mismatch type for const array)

r? @ghost
@rust-bors rust-bors bot merged commit bf31616 into rust-lang:main Jan 14, 2026
30 of 33 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 14, 2026
rust-timer added a commit that referenced this pull request Jan 14, 2026
@rust-timer
Unrolled build for #150587
41c8566 
Rollup merge of #150587 - add-rustdoc-js-autolabel, r=fmease

triagebot: add A-rustdoc-js autolabel

Adds an autolabel rule for rustdoc JavaScript/TypeScript files so PRs touching
rustdoc frontend assets and related tests are automatically labeled `A-rustdoc-js`.

Fixes #137983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmease fmease fmease left review comments

Assignees

@fmease fmease

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

triagebot: Autolabel relevant PRs with A-rustdoc-js

5 participants

@AaryanAgrawal96 @rustbot @fmease @rust-log-analyzer @Mark-Simulacrum