Skip to content

Conversation

@vsriramv
Copy link
Contributor

@vsriramv vsriramv commented Jan 3, 2026

Updated the edit-url-template for the unstable book and the rustc book.

Fixes #150593

The "Suggest an edit" links were pointing to HEAD, which resulted in a 404. Changed these to point to main.

r? @Kobzol

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 3, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 3, 2026

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

Copy link
Member

@hkBst hkBst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and seems to be what @Kobzol already intended as the fix.

View changes since this review

@Kobzol
Copy link
Member

Kobzol commented Jan 3, 2026

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 3, 2026

📌 Commit d79fa3c has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2026
bors added a commit that referenced this pull request Jan 3, 2026
Rollup of 5 pull requests

Successful merges:

 - #150558 (Detect cases where `?` is applied on a type that could be coming from a different crate version than expected)
 - #150570 (Removed confusing diagnostics note for trait required for `?` operator use)
 - #150589 (Remove unneeded `forbid_generic` field from `Res::SelfTyAlias`)
 - #150635 (triagebot: Add a mention for `dec2flt`, `flt2dec`, and `fmt/num.rs`)
 - #150637 (Fix broken edit links in Unstable and rustc books)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 689e74d into rust-lang:main Jan 3, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Jan 3, 2026
Rollup merge of #150637 - vsriramv:fix/edit-url-template, r=Kobzol

Fix broken edit links in Unstable and rustc books

Updated the edit-url-template for the unstable book and the rustc book.

Fixes #150593

The "Suggest an edit" links were pointing to HEAD, which resulted in a 404. Changed these to point to main.

r? `@Kobzol`
@rustbot rustbot added this to the 1.94.0 milestone Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

edit-url-template not working

5 participants