Skip to content

Handle unevaluated ConstKind in in_operand#151260

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
reddevilmidzy:type_const
Jan 22, 2026
Merged

Handle unevaluated ConstKind in in_operand#151260
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
reddevilmidzy:type_const

Conversation

@reddevilmidzy
Copy link
Member

@reddevilmidzy reddevilmidzy commented Jan 17, 2026 •
edited
Loading

fix: #151248

r? BoxyUwU
I can't reproduce #151246 in my local(x86_64-pc-windows-msvc) even before this change. 🤔
create a draft and test it in different environments.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 17, 2026
@Keith-Cancel
Copy link
Contributor

Keith-Cancel commented Jan 17, 2026 •
edited
Loading

I can't reproduce #151246 in my local(x86_64-pc-windows-msvc) even before this change. 🤔 create a draft and test it in different environments.

@reddevilmidzy
I am able to reproduce #151246, I was looking at it because it's an error location I was hitting on things I was working on/messing with.
I am on a Linux system and using the following to invoke rust: rustc test.rs -Clink-dead-code=true

@Keith-Cancel
Copy link
Contributor

Keith-Cancel commented Jan 17, 2026 •
edited
Loading

I did apply the change you have in qualifs.rs still ICEs in the same spot for #151246.

@reddevilmidzy
Copy link
Member Author

reddevilmidzy commented Jan 18, 2026

I did apply the change you have in qualifs.rs still ICEs in the same spot for #151246.

thank you for checking. I thought I could solve them together since the ICE causes seemed similar, but I guess I'll have to look into it again.

@reddevilmidzy
Copy link
Member Author

reddevilmidzy commented Jan 20, 2026

I'm not confident in modifying the code because I can't reproduce it locally, so I won't touch the #151246.

reddevilmidzy
reddevilmidzy commented Jan 21, 2026
View reviewed changes
@reddevilmidzy reddevilmidzy marked this pull request as ready for review January 21, 2026 00:19
@rustbot
Copy link
Collaborator

rustbot commented Jan 21, 2026

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred to constck

cc @fee1-dead

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 21, 2026
@BoxyUwU BoxyUwU mentioned this pull request Jan 21, 2026
Merged
BoxyUwU
BoxyUwU reviewed Jan 21, 2026
View reviewed changes
@BoxyUwU
Copy link
Member

BoxyUwU commented Jan 21, 2026

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2026
@reddevilmidzy
Copy link
Member Author

reddevilmidzy commented Jan 21, 2026

Thank you for the review
@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 21, 2026
@BoxyUwU
Copy link
Member

BoxyUwU commented Jan 22, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 22, 2026

📌 Commit a158e2e has been approved by BoxyUwU

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 22, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151260 - reddevilmidzy:type_const, r=BoxyUwU
ab467ab 
Handle unevaluated ConstKind in in_operand

fix: rust-lang#151248

r? BoxyUwU
~~I can't reproduce rust-lang#151246 in my local(x86_64-pc-windows-msvc) even before this change. 🤔
create a draft and test it in different environments.~~
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 22, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Jan 22, 2026
@bors
Auto merge of #151485 - JonathanBrouwer:rollup-uTKVd4J, r=JonathanBro…
0a1d3fa 
…uwer

Rollup of 8 pull requests

Successful merges:

 - #148206 (Deduplicated float tests and unified in floats/mod.rs)
 - #151042 (fix fallback impl for select_unpredictable intrinsic)
 - #151220 (option: Use Option::map in Option::cloned)
 - #151260 (Handle unevaluated ConstKind in in_operand)
 - #151441 (Fix ICE: Don't try to evaluate type_consts when eagerly collecting items)
 - #151465 (codegen: clarify some variable names around function calls)
 - #151469 (llvm: Tolerate dead_on_return attribute changes)
 - #151476 (Avoid `-> ()` in derived functions.)

r? @ghost
rust-bors bot pushed a commit that referenced this pull request Jan 22, 2026
@bors
Auto merge of #151485 - JonathanBrouwer:rollup-uTKVd4J, r=JonathanBro…
d629c3b 
…uwer

Rollup of 8 pull requests

Successful merges:

 - #148206 (Deduplicated float tests and unified in floats/mod.rs)
 - #151042 (fix fallback impl for select_unpredictable intrinsic)
 - #151220 (option: Use Option::map in Option::cloned)
 - #151260 (Handle unevaluated ConstKind in in_operand)
 - #151441 (Fix ICE: Don't try to evaluate type_consts when eagerly collecting items)
 - #151465 (codegen: clarify some variable names around function calls)
 - #151469 (llvm: Tolerate dead_on_return attribute changes)
 - #151476 (Avoid `-> ()` in derived functions.)

r? @ghost
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 22, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 22, 2026
@bors
Auto merge of #151485 - JonathanBrouwer:rollup-uTKVd4J, r=JonathanBro…
f51b5a1 
…uwer

Rollup of 8 pull requests

Successful merges:

 - #148206 (Deduplicated float tests and unified in floats/mod.rs)
 - #151042 (fix fallback impl for select_unpredictable intrinsic)
 - #151220 (option: Use Option::map in Option::cloned)
 - #151260 (Handle unevaluated ConstKind in in_operand)
 - #151441 (Fix ICE: Don't try to evaluate type_consts when eagerly collecting items)
 - #151465 (codegen: clarify some variable names around function calls)
 - #151469 (llvm: Tolerate dead_on_return attribute changes)
 - #151476 (Avoid `-> ()` in derived functions.)

r? @ghost
rust-bors bot pushed a commit that referenced this pull request Jan 22, 2026
@bors
Auto merge of #151490 - JonathanBrouwer:rollup-ovStnQE, r=JonathanBro…
1ba0be2 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #151001 (rustdoc: render doc(hidden) as a code attribute)
 - #151042 (fix fallback impl for select_unpredictable intrinsic)
 - #151220 (option: Use Option::map in Option::cloned)
 - #151260 (Handle unevaluated ConstKind in in_operand)
 - #151296 (MGCA: Fix incorrect pretty printing of valtree arrays)
 - #151423 (Move assert_matches to planned stable path)
 - #151441 (Fix ICE: Don't try to evaluate type_consts when eagerly collecting items)
 - #151465 (codegen: clarify some variable names around function calls)
 - #151468 (fix `f16` doctest FIXMEs)
 - #151469 (llvm: Tolerate dead_on_return attribute changes)
 - #151476 (Avoid `-> ()` in derived functions.)

r? @ghost
rust-bors bot pushed a commit that referenced this pull request Jan 22, 2026
@bors
Auto merge of #151490 - JonathanBrouwer:rollup-ovStnQE, r=JonathanBro…
608c882 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #151001 (rustdoc: render doc(hidden) as a code attribute)
 - #151042 (fix fallback impl for select_unpredictable intrinsic)
 - #151220 (option: Use Option::map in Option::cloned)
 - #151260 (Handle unevaluated ConstKind in in_operand)
 - #151296 (MGCA: Fix incorrect pretty printing of valtree arrays)
 - #151423 (Move assert_matches to planned stable path)
 - #151441 (Fix ICE: Don't try to evaluate type_consts when eagerly collecting items)
 - #151465 (codegen: clarify some variable names around function calls)
 - #151468 (fix `f16` doctest FIXMEs)
 - #151469 (llvm: Tolerate dead_on_return attribute changes)
 - #151476 (Avoid `-> ()` in derived functions.)

r? @ghost
rust-bors bot pushed a commit that referenced this pull request Jan 22, 2026
@bors
Auto merge of #151490 - JonathanBrouwer:rollup-ovStnQE, r=JonathanBro…
0f14563 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #151001 (rustdoc: render doc(hidden) as a code attribute)
 - #151042 (fix fallback impl for select_unpredictable intrinsic)
 - #151220 (option: Use Option::map in Option::cloned)
 - #151260 (Handle unevaluated ConstKind in in_operand)
 - #151296 (MGCA: Fix incorrect pretty printing of valtree arrays)
 - #151423 (Move assert_matches to planned stable path)
 - #151441 (Fix ICE: Don't try to evaluate type_consts when eagerly collecting items)
 - #151465 (codegen: clarify some variable names around function calls)
 - #151468 (fix `f16` doctest FIXMEs)
 - #151469 (llvm: Tolerate dead_on_return attribute changes)
 - #151476 (Avoid `-> ()` in derived functions.)

r? @ghost
@rust-bors rust-bors bot merged commit 0fc86d8 into rust-lang:main Jan 22, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 22, 2026
rust-timer added a commit that referenced this pull request Jan 22, 2026
@rust-timer
Unrolled build for #151260
9fe00ab 
Rollup merge of #151260 - reddevilmidzy:type_const, r=BoxyUwU

Handle unevaluated ConstKind in in_operand

fix: #151248

r? BoxyUwU
~~I can't reproduce #151246 in my local(x86_64-pc-windows-msvc) even before this change. 🤔
create a draft and test it in different environments.~~
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jan 23, 2026
@bors
Auto merge of #151490 - JonathanBrouwer:rollup-ovStnQE, r=JonathanBro…
3b7687e 
…uwer

Rollup of 11 pull requests

Successful merges:

 - rust-lang/rust#151001 (rustdoc: render doc(hidden) as a code attribute)
 - rust-lang/rust#151042 (fix fallback impl for select_unpredictable intrinsic)
 - rust-lang/rust#151220 (option: Use Option::map in Option::cloned)
 - rust-lang/rust#151260 (Handle unevaluated ConstKind in in_operand)
 - rust-lang/rust#151296 (MGCA: Fix incorrect pretty printing of valtree arrays)
 - rust-lang/rust#151423 (Move assert_matches to planned stable path)
 - rust-lang/rust#151441 (Fix ICE: Don't try to evaluate type_consts when eagerly collecting items)
 - rust-lang/rust#151465 (codegen: clarify some variable names around function calls)
 - rust-lang/rust#151468 (fix `f16` doctest FIXMEs)
 - rust-lang/rust#151469 (llvm: Tolerate dead_on_return attribute changes)
 - rust-lang/rust#151476 (Avoid `-> ()` in derived functions.)

r? @ghost
@reddevilmidzy reddevilmidzy deleted the type_const branch January 23, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BoxyUwU BoxyUwU BoxyUwU left review comments

Assignees

@BoxyUwU BoxyUwU

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

ICE: expected ConstKind::Param or ConstKind::Value here, found UnevaluatedConst

4 participants

@reddevilmidzy @Keith-Cancel @rustbot @BoxyUwU