Fix an ICE on transmute goals with placeholders in param_env#151373
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Jan 21, 2026
Merged
Fix an ICE on transmute goals with placeholders in param_env#151373rust-bors[bot] merged 1 commit intorust-lang:mainfrom
param_env#151373rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Member
|
can u take the issue number out of the test name? I don't think it helps much especially when it's already in the test as a comment. |
Member
Author
Okay, I'll remove it 😅 |
ShoyuVanilla
force-pushed
the
issue-151300
branch
from
9cc9cda to
c3c8eb1
Compare
lcnr
reviewed
Jan 20, 2026
|
|
||
| // A regression test for https://github.com/rust-lang/rust/issues/151300 | ||
|
|
||
| #![feature(transmutability)] |
Contributor
There was a problem hiding this comment.
can you move this to the transmutability folder instead of the general next-solver one?
Member
Author
There was a problem hiding this comment.
Okay, I'll move it once I get home
ShoyuVanilla
force-pushed
the
issue-151300
branch
from
c3c8eb1 to
328893e
Compare
Member
Author
|
@bors r=lcnr rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 20, 2026
Rollup of 7 pull requests Successful merges: - #151216 ([rustdoc] Make popover menus content scrollable on mobile devices) - #151373 (Fix an ICE on transmute goals with placeholders in `param_env`) - #151399 (Generate error delegation when delegation is not resolved) - #151406 (Use version 1.93.0 in `RELEASES.md` instead of 1.93) - #151410 (Fixes for LLVM 22 compatibility) - #151415 (chore: Remove redundant conversion) - #151418 (Avoid pulling in unicode when calling io::Error::kind) r? @ghost
rust-timer
added a commit
that referenced
this pull request
Jan 21, 2026
Rollup merge of #151373 - issue-151300, r=lcnr Fix an ICE on transmute goals with placeholders in `param_env` Fixes #151300 The next solver short-circuits `consider_builtin_transmute_candidate` when the goal contains non-region placeholders, since `rustc_transmute` does not support type parameters. However, this check should likely be refined to apply only to the predicate itself: excess bounds with type params in the param env can cause the goal to be rejected even when its predicate trivially holds. r? types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #151300
The next solver short-circuits
consider_builtin_transmute_candidatewhen the goal contains non-region placeholders, sincerustc_transmutedoes not support type parameters.However, this check should likely be refined to apply only to the predicate itself: excess bounds with type params in the param env can cause the goal to be rejected even when its predicate trivially holds.
r? types