Pass DepNode by reference more places

[Zoxc]

Pass DepNode by reference more places as it would typically need 3 registers.

[Zoxc]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: d3bc563 (d3bc5631eab4139adddf6e9d354540429110d9c0, parent: a293cc4af8b26701c42738381c0c6f9d2ba881e0)

[rust-timer]

Finished benchmarking commit (d3bc563): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.4%, -0.2%]	48
Improvements ✅ (secondary)	-0.2%	[-0.3%, -0.2%]	18
All ❌✅ (primary)	-0.3%	[-0.4%, -0.2%]	48

Max RSS (memory usage)

Results (primary 4.0%, secondary 2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	4.0%	[4.0%, 4.0%]	1
Regressions ❌ (secondary)	2.7%	[2.7%, 2.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	4.0%	[4.0%, 4.0%]	1

Cycles

Results (secondary -1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[3.2%, 3.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.2%	[-5.2%, -5.2%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -0.0%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.0%	[-0.1%, -0.0%]	28
Improvements ✅ (secondary)	-0.0%	[-0.1%, -0.0%]	24
All ❌✅ (primary)	-0.0%	[-0.1%, -0.0%]	28

Bootstrap: 473.657s -> 473.089s (-0.12%)
Artifact size: 397.74 MiB -> 397.71 MiB (-0.01%)

[rustbot]

r? @eholk

rustbot has assigned @eholk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[eholk]

@bors r+

[rust-bors]

📌 Commit 8869b7b has been approved by eholk

It is now in the queue for this repository.

[Zalathar]

Scheduling: Encourage a mixture of rollup and non-rollup PRs.

@bors p=5

[rust-bors]

☀️ Test successful - CI
Approved by: eholk
Duration: 3h 13m 23s
Pushing 271951b to main...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 1e9be1b (parent) -> 271951b (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 271951ba187953d39b1c66b062d83f558aa23856 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. test-various: 6169.0s -> 7407.8s (+20.1%)
2. pr-check-1: 1661.5s -> 1992.7s (+19.9%)
3. aarch64-gnu-debug: 3983.7s -> 4532.4s (+13.8%)
4. pr-check-2: 2250.5s -> 2529.8s (+12.4%)
5. dist-x86_64-apple: 6638.3s -> 5921.8s (-10.8%)
6. x86_64-gnu-gcc: 3602.9s -> 3991.7s (+10.8%)
7. x86_64-gnu-miri: 4442.6s -> 4917.7s (+10.7%)
8. x86_64-gnu-llvm-21-1: 4108.8s -> 4540.1s (+10.5%)
9. dist-aarch64-msvc: 6386.6s -> 5716.8s (-10.5%)
10. armhf-gnu: 4920.5s -> 5422.1s (+10.2%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (271951b): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.4%, -0.2%]	45
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.2%]	17
All ❌✅ (primary)	-0.3%	[-0.4%, -0.2%]	45

Max RSS (memory usage)

Results (primary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.929s -> 474.744s (-0.04%)
Artifact size: 397.85 MiB -> 397.83 MiB (-0.00%)