Fix ICE when parsing frontmatter without newline#151889
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Jan 31, 2026
Merged
Fix ICE when parsing frontmatter without newline#151889rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
Collaborator
This comment has been minimized.
This comment has been minimized.
e478028 to
bf7a2a3
Compare
Member
Author
flaky test |
Collaborator
|
Some changes occurred in GUI tests. |
c9cb678 to
bf7a2a3
Compare
Member
Author
|
seems PR not working? |
Member
|
would be - let last_line_start = real_s.rfind('\n').map_or(0, |i| i + 1);
+ let last_line_start = real_s.rfind('\n').map_or(line_end, |i| i + 1);enough to fix it? |
bf7a2a3 to
dc48704
Compare
Member
Author
yeah, simpler. |
Member
|
r=me with ci green |
Member
|
@bors r+ rollup |
Contributor
rust-timer
added a commit
that referenced
this pull request
Jan 31, 2026
Rollup merge of #151889 - chenyukang:yukang-fix-151882-frontmatter-ice, r=Kivooeo Fix ICE when parsing frontmatter without newline Fixes #151882 we can not add a normal test case for it: - no newline at the end of file, we can bypass this with change test file name with `ignore-tidy` - multiple errors in stderr, this conflicts with the previous bypass, seems we can not add multiple error annotations in one line anyway, I added a `run-make` test for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #151882
we can not add a normal test case for it:
ignore-tidyanyway, I added a
run-maketest for it.