Rollup of 3 pull requests#151921
Closed
JonathanBrouwer wants to merge 7 commits intorust-lang:mainfrom
Closed
Conversation
The new ambiguities are reported when the import's visibility is ambiguous and may depend on the resolution/expansion order.
resolve: Report more visibility-related early resolution ambiguities for imports The new ambiguities are reported when the import's visibility is ambiguous and may depend on the resolution/expansion order. Detailed description: rust-lang#149596 (comment).
…d-allocation-box-ref, r=petrochenkov Skip unused_allocation lint when method takes &Box<Self> Fixes rust-lang#151846
…shorthand-gate, r=JonathanBrouwer Feature-gate `mut ref` patterns in struct pattern field shorthand Tracking issue for `mut_ref` (and other parts of Match Ergonomics 2024): rust-lang#123076 rust-lang#123080 introduced `mut ref`[^1] patterns (for by-reference bindings where the binding itself is mutable), feature-gated behind the `mut_ref` feature, except for in struct pattern shorthand, where the feature gating was missing. Thus, `mut ref` patterns in struct pattern shorthand has been unintentionally stable for ~18 months (since 1.79.0 ([compiler explorer](https://rust.godbolt.org/z/4WTrvhboT))). This PR adds feature-gating for `mut ref` patterns in struct pattern shorthand. Since this is reverting an accidental stabilization, this probably needs a crater run and a T-lang FCP? Some alternative possibilities: * Do nothing (let the inconsistency exist until `feature(mut_ref)` is stabilized) * Document the existing behavior * Do a FCW instead of fully feature-gating * Stabilize `feature(mut_ref)` CC rust-lang#123080 (comment) CC @Nadrieril [^1]: everything in this description also applies analogously to `mut ref mut` patterns.
rustbot
added
S-waiting-on-review
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
bot
added
S-waiting-on-review
Contributor
|
💔 Test for 179473f failed: CI. Failed job:
|
rust-bors
bot
added
S-waiting-on-author
Contributor
|
PR #149596, which is a member of this rollup, was unapproved. |
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
mut refpatterns in struct pattern field shorthand #151102 (Feature-gatemut refpatterns in struct pattern field shorthand)r? @ghost
Create a similar rollup