Use with_capacity in query_key_hash_verify and PlaceholderExpander

[camsteffen]

Addresses the first two items from #137005 (comment).

[rustbot]

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[Kobzol]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 118b4b2 (118b4b2c2fd16034134fc7a7e42dcd4c62b79e28, parent: a60d12cbccfbeaf153f3cecb90454aa696ea4b3b)

[rust-timer]

Finished benchmarking commit (118b4b2): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-3.3%, -0.2%]	162
Improvements ✅ (secondary)	-0.9%	[-3.4%, -0.1%]	163
All ❌✅ (primary)	-0.7%	[-3.3%, -0.2%]	162

Max RSS (memory usage)

Results (primary -1.1%, secondary -3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-1.7%, -0.7%]	6
Improvements ✅ (secondary)	-3.0%	[-5.4%, -1.5%]	5
All ❌✅ (primary)	-1.1%	[-1.7%, -0.7%]	6

Cycles

Results (primary -2.3%, secondary -2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-2.7%	[-4.3%, -1.5%]	19
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.737s -> 472.076s (-0.35%)
Artifact size: 397.70 MiB -> 397.67 MiB (-0.01%)

[BoxyUwU]

@bors r+ rollup=never

very cool

[rust-bors]

📌 Commit 60f5679 has been approved by BoxyUwU

It is now in the queue for this repository.

[JonathanBrouwer]

@bors yield
Yielding to the big rollup that failed in 30 seconds :P Wanna give that one another chance

[rust-bors]

Auto build cancelled. Cancelled workflows:

• https://github.com/rust-lang/rust/actions/runs/21641403453

The next pull request likely to be tested is #152063.

[rust-bors]

☀️ Test successful - CI
Approved by: BoxyUwU
Duration: 3h 7m 4s
Pushing 0c40f5b to main...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 366a1b9 (parent) -> 0c40f5b (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 0c40f5be0c8eb04d206e928c5d8c133a9142143a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. aarch64-gnu-llvm-20-2: 46m 9s -> 57m 50s (+25.3%)
2. i686-gnu-2: 1h 27m -> 1h 44m (+20.1%)
3. x86_64-gnu-llvm-20: 1h 4m -> 1h 17m (+19.9%)
4. pr-check-1: 27m 19s -> 32m 31s (+19.0%)
5. aarch64-apple: 3h 5m -> 2h 33m (-17.3%)
6. x86_64-gnu-llvm-20-1: 1h 7m -> 1h 16m (+13.3%)
7. x86_64-gnu-debug: 1h 53m -> 2h 7m (+12.7%)
8. arm-android: 1h 34m -> 1h 46m (+12.1%)
9. aarch64-msvc-2: 1h 50m -> 1h 37m (-12.0%)
10. aarch64-gnu-debug: 1h 6m -> 1h 14m (+12.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (0c40f5b): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-3.3%, -0.2%]	166
Improvements ✅ (secondary)	-0.9%	[-3.4%, -0.1%]	161
All ❌✅ (primary)	-0.6%	[-3.3%, -0.2%]	166

Max RSS (memory usage)

Results (primary -1.3%, secondary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.3%	[-1.8%, -0.9%]	7
Improvements ✅ (secondary)	-2.2%	[-3.1%, -1.6%]	5
All ❌✅ (primary)	-1.3%	[-1.8%, -0.9%]	7

Cycles

Results (primary -2.5%, secondary -1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.9%	[2.7%, 5.2%]	3
Improvements ✅ (primary)	-2.5%	[-3.1%, -2.0%]	5
Improvements ✅ (secondary)	-2.8%	[-4.1%, -2.0%]	21
All ❌✅ (primary)	-2.5%	[-3.1%, -2.0%]	5

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 472.721s -> 475.191s (0.52%)
Artifact size: 397.76 MiB -> 397.77 MiB (0.00%)