Work around rustfmt giving up on a large expression#151975

Zalathar · 2026-02-02T02:30:14Z

Gives up on chains if any line is too long. rustfmt#3863

In some cases, if rustfmt sees a string literal that is too long for it to comfortably format, it will give up on formatting the entire enclosing expression.

For complex builder expressions, that will prevent auto-formatting for frustratingly large sections of code.

This PR works around a particular occurrence of that phenomenon in compiler/rustc_interface/src/util.rs, by splitting a single error message string across multiple lines. This allows rustfmt to successfully auto-format the entire enclosing expression, which is dozens of lines long.

There should be no change to compiler behaviour.

rustbot · 2026-02-02T02:30:18Z

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

BoxyUwU · 2026-02-02T15:09:54Z

@bors r+ rollup

rust-bors · 2026-02-02T15:09:57Z

📌 Commit 0cbbe56 has been approved by BoxyUwU

It is now in the queue for this repository.

Work around rustfmt giving up on a large expression - rust-lang/rustfmt#3863 --- In some cases, if rustfmt sees a string literal that is too long for it to comfortably format, it will give up on formatting the entire enclosing expression. For complex builder expressions, that will prevent auto-formatting for frustratingly large sections of code. This PR works around a particular occurrence of that phenomenon in `compiler/rustc_interface/src/util.rs`, by splitting a single error message string across multiple lines. This allows rustfmt to successfully auto-format the entire enclosing expression, which is dozens of lines long. There should be no change to compiler behaviour.

…uwer Rollup of 4 pull requests Successful merges: - #151958 (Add codegen test for SLP vectorization) - #151974 (Update documentation for `Result::ok()`) - #151975 (Work around rustfmt giving up on a large expression) - #151999 (attribute parsing: pass recovery mode to Parser.)

Rollup of 11 pull requests Successful merges: - #151378 (Codegen tests for Arm Cortex-R82) - #151936 (Move the `fingerprint_style` special case into `DepKindVTable` creation) - #152018 (Move bigint helper tracking issues) - #151958 (Add codegen test for SLP vectorization) - #151974 (Update documentation for `Result::ok()`) - #151975 (Work around rustfmt giving up on a large expression) - #151990 (Fix missing unused_variables lint when using a match guard) - #151995 (stabilize ptr_as_ref_unchecked) - #151999 (attribute parsing: pass recovery mode to Parser.) - #152009 (Port rustc_preserve_ub_checks to attr parser) - #152022 (rustc-dev-guide subtree update) Failed merges: - #151968 (Remove `HasDepContext` by merging it into `QueryContext`)

Rollup merge of #151975 - Zalathar:interface-fmt, r=BoxyUwU Work around rustfmt giving up on a large expression - rust-lang/rustfmt#3863 --- In some cases, if rustfmt sees a string literal that is too long for it to comfortably format, it will give up on formatting the entire enclosing expression. For complex builder expressions, that will prevent auto-formatting for frustratingly large sections of code. This PR works around a particular occurrence of that phenomenon in `compiler/rustc_interface/src/util.rs`, by splitting a single error message string across multiple lines. This allows rustfmt to successfully auto-format the entire enclosing expression, which is dozens of lines long. There should be no change to compiler behaviour.

Rollup of 11 pull requests Successful merges: - rust-lang/rust#151378 (Codegen tests for Arm Cortex-R82) - rust-lang/rust#151936 (Move the `fingerprint_style` special case into `DepKindVTable` creation) - rust-lang/rust#152018 (Move bigint helper tracking issues) - rust-lang/rust#151958 (Add codegen test for SLP vectorization) - rust-lang/rust#151974 (Update documentation for `Result::ok()`) - rust-lang/rust#151975 (Work around rustfmt giving up on a large expression) - rust-lang/rust#151990 (Fix missing unused_variables lint when using a match guard) - rust-lang/rust#151995 (stabilize ptr_as_ref_unchecked) - rust-lang/rust#151999 (attribute parsing: pass recovery mode to Parser.) - rust-lang/rust#152009 (Port rustc_preserve_ub_checks to attr parser) - rust-lang/rust#152022 (rustc-dev-guide subtree update) Failed merges: - rust-lang/rust#151968 (Remove `HasDepContext` by merging it into `QueryContext`)

Work around rustfmt giving up on a large expression

0cbbe56

rustbot assigned BoxyUwU Feb 2, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 2, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2026

JonathanBrouwer mentioned this pull request Feb 2, 2026

Rollup of 4 pull requests #152002

Closed

jhpratt mentioned this pull request Feb 3, 2026

Rollup of 11 pull requests #152025

Merged

Zalathar mentioned this pull request Feb 3, 2026

Rename collect_active_jobs to several distinct names #151976

Merged

rust-bors bot merged commit 4923aec into rust-lang:main Feb 3, 2026
11 checks passed

rustbot added this to the 1.95.0 milestone Feb 3, 2026

Zalathar deleted the interface-fmt branch February 3, 2026 08:11

github-actions bot mentioned this pull request Feb 10, 2026

Toolchain upgrade to nightly-2026-02-07 flux-rs/flux#1345

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Work around rustfmt giving up on a large expression#151975