Skip to content

Weaken assert_dep_node_not_yet_allocated_in_current_session for multiple threads#152067

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Zoxc:graph-weak-assert
Feb 8, 2026
Merged

Weaken assert_dep_node_not_yet_allocated_in_current_session for multiple threads#152067
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Zoxc:graph-weak-assert

Conversation

@Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Feb 3, 2026

This changes assert_dep_node_not_yet_allocated_in_current_session to not panic if the node is already marked green. Another thread may manage to mark it green if there was uncolored node when we initially tried to mark it green.

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 3, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 3, 2026

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jackh726
Copy link
Member

jackh726 commented Feb 8, 2026

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 8, 2026

📌 Commit 80a4257 has been approved by jackh726

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2026
rust-bors bot pushed a commit that referenced this pull request Feb 8, 2026
Rollup of 5 pull requests

Successful merges:

 - #150443 (Support long diff conflict markers)
 - #151887 (Remove some unnecessary `try`-related type annotations)
 - #152037 (Suppress unused_mut lint if mutation fails due to borrowck error)
 - #152067 (Weaken `assert_dep_node_not_yet_allocated_in_current_session` for multiple threads)
 - #151227 (Document `-Zcache-proc-macros`)
@rust-bors rust-bors bot merged commit 60eaaba into rust-lang:main Feb 8, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 8, 2026
rust-timer added a commit that referenced this pull request Feb 8, 2026
Rollup merge of #152067 - Zoxc:graph-weak-assert, r=jackh726

Weaken `assert_dep_node_not_yet_allocated_in_current_session` for multiple threads

This changes `assert_dep_node_not_yet_allocated_in_current_session` to not panic if the node is already marked green. Another thread may manage to mark it green if there was uncolored node when we initially tried to mark it green.
@Zoxc Zoxc deleted the graph-weak-assert branch February 8, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants