Stabilize const ControlFlow predicates

[nxsaken]

Closes: #148738 (tracking issue)
Related: #140266 (moved the relevant const-unstables to that feature)
r? @dtolnay

[dtolnay]

Thanks!

View changes since this review

[dtolnay]

@bors r+

[rust-bors]

📌 Commit 4b427b2 has been approved by dtolnay

It is now in the queue for this repository.

[rust-bors]

☀️ Test successful - CI
Approved by: dtolnay
Duration: 3h 9m 18s
Pushing 56aaf58 to main...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c58d9f9 (parent) -> 56aaf58 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 56aaf58ec02b6ac974e8364269fbb33a8a806e28 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. dist-aarch64-apple: 2h 37m -> 1h 41m (-35.4%)
2. dist-x86_64-apple: 1h 54m -> 2h 13m (+16.4%)
3. aarch64-apple: 2h 59m -> 2h 30m (-16.4%)
4. pr-check-2: 41m 10s -> 35m 32s (-13.7%)
5. pr-check-1: 31m 31s -> 27m 27s (-12.9%)
6. x86_64-gnu-miri: 1h 21m -> 1h 11m (-12.2%)
7. i686-gnu-2: 1h 40m -> 1h 29m (-10.8%)
8. dist-apple-various: 1h 8m -> 1h 1m (-10.7%)
9. x86_64-msvc-2: 2h 13m -> 2h 26m (+9.8%)
10. dist-aarch64-llvm-mingw: 1h 37m -> 1h 46m (+8.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (56aaf58): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.1%]	3
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 0.6%, secondary 4.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.6%, 0.6%]	1
Regressions ❌ (secondary)	4.6%	[4.6%, 4.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.6%, 0.6%]	1

Cycles

Results (secondary 3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.4%	[2.2%, 4.5%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.659s -> 473.618s (-0.43%)
Artifact size: 398.00 MiB -> 398.00 MiB (0.00%)