Skip to content

Stop having two different alignment constants#152275

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
scottmcm:range-range-inclusive
Feb 9, 2026
Merged

Stop having two different alignment constants#152275
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
scottmcm:range-range-inclusive

Conversation

@scottmcm
Copy link
Member

@scottmcm scottmcm commented Feb 7, 2026

Now that there's a <T as SizedTypeProperties>::ALIGNMENT constant, Alignment::of can use that instead of an inline constant, like how Layout::new uses the constant from SizedTypeProperties.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 7, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 7, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates

@rust-log-analyzer

This comment has been minimized.

@scottmcm scottmcm force-pushed the range-range-inclusive branch from 5482400 to f2e48d9 Compare February 7, 2026 10:00
@rust-log-analyzer

This comment has been minimized.

@scottmcm scottmcm force-pushed the range-range-inclusive branch 2 times, most recently from 7504f22 to db1ae00 Compare February 7, 2026 19:55
@rustbot

This comment has been minimized.

@rust-bors

This comment has been minimized.

@scottmcm scottmcm force-pushed the range-range-inclusive branch from db1ae00 to 8bf3567 Compare February 8, 2026 06:23
@rustbot
Copy link
Collaborator

rustbot commented Feb 8, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Mark-Simulacrum
Copy link
Member

@bors squash

* Stop having two different alignment constants
* Update library/core/src/alloc/global.rs
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 8, 2026

🔨 2 commits were squashed into 4a979d5.

@rust-bors rust-bors bot force-pushed the range-range-inclusive branch from 8774bdb to 4a979d5 Compare February 8, 2026 19:54
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 8, 2026

📌 Commit 4a979d5 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2026
rust-bors bot pushed a commit that referenced this pull request Feb 8, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #151869 (add test for codegen of SIMD vector from array repeat)
 - #152077 (bootstrap: always propagate `CARGO_TARGET_{host}_LINKER`)
 - #126100 (Reword the caveats on `array::map`)
 - #152275 (Stop having two different alignment constants)
 - #152325 (Remove more adhoc groups that correspond to teams)
@rust-bors rust-bors bot merged commit 9f778b4 into rust-lang:main Feb 9, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 9, 2026
rust-timer added a commit that referenced this pull request Feb 9, 2026
Rollup merge of #152275 - scottmcm:range-range-inclusive, r=Mark-Simulacrum

Stop having two different alignment constants

Now that there's a `<T as SizedTypeProperties>::ALIGNMENT` constant, `Alignment::of` can use that instead of an inline constant, like how `Layout::new` uses the constant from `SizedTypeProperties`.
@scottmcm scottmcm deleted the range-range-inclusive branch February 9, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants