Skip to content

[beta] Revert destabilise target-spec-json#152721

Merged
rust-bors[bot] merged 1 commit intorust-lang:betafrom
ehuss:beta-revert-target-spec
Feb 18, 2026
Merged

[beta] Revert destabilise target-spec-json#152721
rust-bors[bot] merged 1 commit intorust-lang:betafrom
ehuss:beta-revert-target-spec

Conversation

@ehuss
Copy link
Contributor

@ehuss ehuss commented Feb 16, 2026

This reverts #150151 in order to deal with #151729 where the destabilization caused a problem with building rustc itself with JSON target specs. There's a fix at #152677, but we would prefer to not backport that, and instead give ourselves more time to work out the kinks. Also, the destabilization was incomplete, and the rest of the changes are in 1.95 (#151534 and rust-lang/cargo#16557), so it would be nice to keep all the changes together in one release.

This reverts commit a89683d, reversing changes made to 2f1bd3f.

This reverts rust-lang#150151 in order to
deal with rust-lang#151729 where the
destabilization caused a problem with building rustc itself with JSON
target specs. There's a fix at
rust-lang#152677, but we would prefer to
not backport that, and instead give ourselves more time to work out the
kinks. Also, the destabilization was incomplete, and the rest of the
changes are in 1.95 (rust-lang#151534 and
rust-lang/cargo#16557), so it would be nice to
keep all the changes together in one release.

This reverts commit a89683d, reversing
changes made to 2f1bd3f.
@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 16, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 16, 2026

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 68 candidates
  • Random selection from 14 candidates

@jackh726
Copy link
Member

r=me with CI green

@ehuss
Copy link
Contributor Author

ehuss commented Feb 17, 2026

@bors r=jackh726 rollup=never

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 17, 2026

📌 Commit 6de57ea has been approved by jackh726

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2026
@Zalathar
Copy link
Member

There are several other rollup=never PRs in the queue, so I'll give this one a gentle beta boost.

@bors p=1

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Feb 17, 2026
[beta] Revert destabilise target-spec-json

This reverts #150151 in order to deal with #151729 where the destabilization caused a problem with building rustc itself with JSON target specs. There's a fix at #152677, but we would prefer to not backport that, and instead give ourselves more time to work out the kinks. Also, the destabilization was incomplete, and the rest of the changes are in 1.95 (#151534 and rust-lang/cargo#16557), so it would be nice to keep all the changes together in one release.

This reverts commit a89683d, reversing changes made to 2f1bd3f.
@rust-bors rust-bors bot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 18, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 18, 2026

💥 Test timed out after 21600s

@rust-bors rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 18, 2026
@ehuss
Copy link
Contributor Author

ehuss commented Feb 18, 2026

@bors retry

dist-x86_64-solaris timed out

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2026
@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Feb 18, 2026
[beta] Revert destabilise target-spec-json

This reverts #150151 in order to deal with #151729 where the destabilization caused a problem with building rustc itself with JSON target specs. There's a fix at #152677, but we would prefer to not backport that, and instead give ourselves more time to work out the kinks. Also, the destabilization was incomplete, and the rest of the changes are in 1.95 (#151534 and rust-lang/cargo#16557), so it would be nice to keep all the changes together in one release.

This reverts commit a89683d, reversing changes made to 2f1bd3f.
@Zalathar
Copy link
Member

At 4 hours elapsed, the dist-arm-linux-musl job is alive but proceeding very slowly.

LLVM is at [2917/3789] source files built, so at this degraded pace the job seems unlikely to finish within the next 2 hours.

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Feb 18, 2026

At 5h50m elapsed it is at 3598/3789.
l'll save us the last 10 minutes of waiting
@bors cancel

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 18, 2026

Auto build cancelled. Cancelled workflows:

The next pull request likely to be tested is #152785.

@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added the merged-by-bors This PR was explicitly merged by bors. label Feb 18, 2026
@rust-bors rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 18, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 18, 2026

☀️ Test successful - CI
Approved by: jackh726
Duration: 3h 16m 7s
Pushing 172dc09 to beta...

@rust-bors rust-bors bot merged commit 172dc09 into rust-lang:beta Feb 18, 2026
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs merged-by-bors This PR was explicitly merged by bors. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments