Skip to content

Miri: recursive validity: also recurse into Boxes#152756

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
RalfJung:miri-recursive-box
Feb 18, 2026
Merged

Miri: recursive validity: also recurse into Boxes#152756
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
RalfJung:miri-recursive-box

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented Feb 17, 2026

Now that #97270 is fixed, the recursive validity mode for Miri can recuse into Boxes without exploding everywhere.

@rustbot
Copy link
Collaborator

rustbot commented Feb 17, 2026

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to the CTFE machinery

cc @oli-obk, @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 17, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 17, 2026

r? @jdonszelmann

rustbot has assigned @jdonszelmann.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, mir
  • compiler, mir expanded to 68 candidates
  • Random selection from 13 candidates

@Kivooeo
Copy link
Member

Kivooeo commented Feb 17, 2026

r? me

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 17, 2026

📌 Commit f542160 has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 17, 2026
@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 17, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 18, 2026
@jhpratt
Rollup merge of rust-lang#152756 - RalfJung:miri-recursive-box, r=Kiv…
7a54bb3 
…ooeo

Miri: recursive validity: also recurse into Boxes

Now that rust-lang#97270 is fixed, the recursive validity mode for Miri can recuse into Boxes without exploding everywhere.
@jhpratt jhpratt mentioned this pull request Feb 18, 2026
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 18, 2026
@jhpratt
Rollup merge of rust-lang#152756 - RalfJung:miri-recursive-box, r=Kiv…
f0bad67 
…ooeo

Miri: recursive validity: also recurse into Boxes

Now that rust-lang#97270 is fixed, the recursive validity mode for Miri can recuse into Boxes without exploding everywhere.
@jhpratt jhpratt mentioned this pull request Feb 18, 2026
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 18, 2026
@jhpratt
Rollup merge of rust-lang#152756 - RalfJung:miri-recursive-box, r=Kiv…
c49cbd0 
…ooeo

Miri: recursive validity: also recurse into Boxes

Now that rust-lang#97270 is fixed, the recursive validity mode for Miri can recuse into Boxes without exploding everywhere.
@jhpratt jhpratt mentioned this pull request Feb 18, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 18, 2026
@bors
Auto merge of #152782 - jhpratt:rollup-cDolUYW, r=jhpratt
94e88b5 
Rollup of 19 pull requests

Successful merges:

 - #145399 (Unify wording of resolve error)
 - #150473 (tail calls: fix copying non-scalar arguments to callee)
 - #152637 (Add a note about elided lifetime)
 - #152657 (std: move `exit` out of PAL)
 - #152729 (compiler: Don't mark `SingleUseConsts` MIR pass as "required for soundness")
 - #152753 (remove the explicit error for old `rental` versions)
 - #152758 (Remove ShallowInitBox.)
 - #151530 (Fix invalid `mut T` suggestion for `&mut T` in missing lifetime error)
 - #152179 (Add documentation note about signed overflow direction)
 - #152474 (Implement opt-bisect-limit for MIR)
 - #152509 (tests/ui/test-attrs: add annotations for reference rules)
 - #152672 (std: use libc version of `_NSGetArgc`/`_NSGetArgv`)
 - #152711 (resolve: Disable an assert that no longer holds)
 - #152732 (add regression test for 147958)
 - #152745 (Fix ICE in `suggest_param_env_shadowing` with incompatible args)
 - #152749 (make `rustc_allow_const_fn_unstable` an actual `rustc_attrs` attribute)
 - #152756 (Miri: recursive validity: also recurse into Boxes)
 - #152770 (carryless_mul: mention the base)
 - #152778 (Update tracking issue number for final_associated_functions)
@Zalathar Zalathar mentioned this pull request Feb 18, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Feb 18, 2026
@bors
Auto merge of #152785 - Zalathar:rollup-UGtEsqh, r=Zalathar
c043085 
Rollup of 20 pull requests

Successful merges:

 - #145399 (Unify wording of resolve error)
 - #150473 (tail calls: fix copying non-scalar arguments to callee)
 - #152637 (Add a note about elided lifetime)
 - #152729 (compiler: Don't mark `SingleUseConsts` MIR pass as "required for soundness")
 - #152751 (Rename dep node "fingerprints" to distinguish key and value hashes)
 - #152753 (remove the explicit error for old `rental` versions)
 - #152758 (Remove ShallowInitBox.)
 - #151530 (Fix invalid `mut T` suggestion for `&mut T` in missing lifetime error)
 - #152179 (Add documentation note about signed overflow direction)
 - #152474 (Implement opt-bisect-limit for MIR)
 - #152509 (tests/ui/test-attrs: add annotations for reference rules)
 - #152672 (std: use libc version of `_NSGetArgc`/`_NSGetArgv`)
 - #152711 (resolve: Disable an assert that no longer holds)
 - #152725 (Rework explanation of CLI lint level flags)
 - #152732 (add regression test for 147958)
 - #152745 (Fix ICE in `suggest_param_env_shadowing` with incompatible args)
 - #152749 (make `rustc_allow_const_fn_unstable` an actual `rustc_attrs` attribute)
 - #152756 (Miri: recursive validity: also recurse into Boxes)
 - #152770 (carryless_mul: mention the base)
 - #152778 (Update tracking issue number for final_associated_functions)
Skgland
Skgland reviewed Feb 18, 2026
View reviewed changes
compiler/rustc_const_eval/src/interpret/validity.rs
// FIXME: we do *not* check behind boxes, since creating a new box first creates it uninitialized
// and then puts the value in there, so briefly we have a box with uninit contents.
// FIXME: should we also skip `UnsafeCell` behind shared references? Currently that is not
// FIXME: should we also `UnsafeCell` behind shared references? Currently that is not
Copy link
Contributor

@Skgland Skgland Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the wrong word got removed when updating the comment?

Suggested change
// FIXME: should we also `UnsafeCell` behind shared references? Currently that is not
// FIXME: should we skip `UnsafeCell` behind shared references? Currently that is not

Copy link
Member Author

@RalfJung RalfJung Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks! Too late for this PR but I made a new one.

@rust-bors rust-bors bot merged commit 123611f into rust-lang:main Feb 18, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Feb 18, 2026
@rust-timer
Unrolled build for #152756
484da61 
Rollup merge of #152756 - RalfJung:miri-recursive-box, r=Kivooeo

Miri: recursive validity: also recurse into Boxes

Now that #97270 is fixed, the recursive validity mode for Miri can recuse into Boxes without exploding everywhere.
@RalfJung RalfJung deleted the miri-recursive-box branch February 18, 2026 17:21
@RalfJung RalfJung mentioned this pull request Feb 18, 2026
Open
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 18, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152806 - RalfJung:interpret-typo, r=Kivooeo
d56ef16 
interpret: fix comment typo

Pointed out in rust-lang#152756 (review) after that PR already had been rolled up.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 18, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152806 - RalfJung:interpret-typo, r=Kivooeo
689301f 
interpret: fix comment typo

Pointed out in rust-lang#152756 (review) after that PR already had been rolled up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Skgland Skgland Skgland left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Kivooeo Kivooeo

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RalfJung @rustbot @Kivooeo @Skgland @jdonszelmann

Comments