Skip to content

Comments

Skip the use_existential_projection_new_instead field in the Debug impl#152813

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
makai410:debug-impl
Feb 21, 2026
Merged

Skip the use_existential_projection_new_instead field in the Debug impl#152813
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
makai410:debug-impl

Conversation

@makai410
Copy link
Member

@makai410 makai410 commented Feb 18, 2026 •
edited
Loading

Resolves: #152807 .

Simply slap a #derive_where[skip(Debug)] on that field.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 18, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 18, 2026

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, types
  • compiler, types expanded to 68 candidates
  • Random selection from 15 candidates

@makai410
Copy link
Member Author

makai410 commented Feb 18, 2026

r? @lcnr

@rustbot rustbot assigned lcnr and unassigned chenyukang Feb 18, 2026
lqd
lqd reviewed Feb 18, 2026
View reviewed changes
compiler/rustc_type_ir/src/ty_kind.rs
pub def_id: I::DefId,

/// This field exists to prevent the creation of `AliasTy` without using [`AliasTy::new_from_args`].
#[derive_where(skip(Debug))]
Copy link
Member

@lqd lqd Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be kept, to avoid having to update a manual Debug impl whenever this struct changes, and this directive for derive_where to skip this field in the derived Debug impl should be used for the ExistentialProjection::use_existential_projection_new_instead field instead.

Copy link
Member Author

@makai410 makai410 Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure that the skip attribute is only valid for traits derive_where is controlling. It doesn't compile if I keep this...

Copy link
Member

@lqd lqd Feb 19, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it controls the derive, which has to be present for the skip to work. So you should keep both.

@rustbot author

Copy link
Member Author

@makai410 makai410 Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

lqd
lqd reviewed Feb 18, 2026
View reviewed changes
compiler/rustc_type_ir/src/predicate.rs
pub def_id: I::DefId,

/// This field exists to prevent the creation of `AliasTerm` without using [`AliasTerm::new_from_args`].
#[derive_where(skip(Debug))]
Copy link
Member

@lqd lqd Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, of course

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) label Feb 19, 2026
@lcnr
Copy link
Contributor

lcnr commented Feb 19, 2026

r? lqd

@rustbot rustbot assigned lqd and unassigned lcnr Feb 19, 2026
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 19, 2026
@makai410 makai410 changed the title impl Debug for ExistentialProjection, AliasTy and AliasTerm Skip the use_existential_projection_new_instead field in the Debug impl Feb 20, 2026
@lqd
Copy link
Member

lqd commented Feb 20, 2026

Thanks! @bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 20, 2026

📌 Commit 279b8cd has been approved by lqd

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 20, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 20, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Feb 21, 2026
@bors
Auto merge of #152924 - JonathanBrouwer:rollup-vnwkCh0, r=JonathanBro…
1c00e98 
…uwer

Rollup of 9 pull requests

Successful merges:

 - #146832 (Not linting irrefutable_let_patterns on let chains)
 - #146972 (Support importing path-segment keyword with renaming)
 - #152241 (For panic=unwind on Wasm targets, define __cpp_exception tag)
 - #152527 (Remove -Zemit-thin-lto flag)
 - #152769 (Do not cancel try builds after first job failure)
 - #152907 (Add tests for delegation generics)
 - #152455 (Remove the translation `-Z` options and the `Translator` type. )
 - #152813 (Skip the `use_existential_projection_new_instead` field in the `Debug` impl)
 - #152912 (Expose Span for all DefIds in rustc_public)
@rust-bors rust-bors bot merged commit 47e2fec into rust-lang:main Feb 21, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 21, 2026
rust-timer added a commit that referenced this pull request Feb 21, 2026
@rust-timer
Unrolled build for #152813
220bc23 
Rollup merge of #152813 - makai410:debug-impl, r=lqd

Skip the `use_existential_projection_new_instead` field in the `Debug` impl

Resolves: #152807 .

Simply slap a `#derive_where[skip(Debug)]` on that field.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Feb 22, 2026
@bors
Auto merge of #152924 - JonathanBrouwer:rollup-vnwkCh0, r=JonathanBro…
1df0436 
…uwer

Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#146832 (Not linting irrefutable_let_patterns on let chains)
 - rust-lang/rust#146972 (Support importing path-segment keyword with renaming)
 - rust-lang/rust#152241 (For panic=unwind on Wasm targets, define __cpp_exception tag)
 - rust-lang/rust#152527 (Remove -Zemit-thin-lto flag)
 - rust-lang/rust#152769 (Do not cancel try builds after first job failure)
 - rust-lang/rust#152907 (Add tests for delegation generics)
 - rust-lang/rust#152455 (Remove the translation `-Z` options and the `Translator` type. )
 - rust-lang/rust#152813 (Skip the `use_existential_projection_new_instead` field in the `Debug` impl)
 - rust-lang/rust#152912 (Expose Span for all DefIds in rustc_public)
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Feb 23, 2026
@bors
Auto merge of #152924 - JonathanBrouwer:rollup-vnwkCh0, r=JonathanBro…
ec1b20b 
…uwer

Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#146832 (Not linting irrefutable_let_patterns on let chains)
 - rust-lang/rust#146972 (Support importing path-segment keyword with renaming)
 - rust-lang/rust#152241 (For panic=unwind on Wasm targets, define __cpp_exception tag)
 - rust-lang/rust#152527 (Remove -Zemit-thin-lto flag)
 - rust-lang/rust#152769 (Do not cancel try builds after first job failure)
 - rust-lang/rust#152907 (Add tests for delegation generics)
 - rust-lang/rust#152455 (Remove the translation `-Z` options and the `Translator` type. )
 - rust-lang/rust#152813 (Skip the `use_existential_projection_new_instead` field in the `Debug` impl)
 - rust-lang/rust#152912 (Expose Span for all DefIds in rustc_public)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lqd lqd lqd left review comments

Assignees

@lqd lqd

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

ignore the use_existential_projection_new_instead field in the Debug impl

6 participants

@makai410 @rustbot @rust-log-analyzer @lcnr @lqd @chenyukang