Fix various distribution build targets to package all target bins#15928
Merged
bors merged 3 commits intorust-lang:masterfrom Jul 23, 2014
Merged
Fix various distribution build targets to package all target bins#15928bors merged 3 commits intorust-lang:masterfrom
bors merged 3 commits intorust-lang:masterfrom
Conversation
This reverts commit 87334fb. Conflicts: mk/install.mk
This preserves the current behavior of `make dist` where we only distribute bins for the host architecture. The bots need this.
Member
|
Just to confirm, has a smoke test been done to ensure that |
Contributor
Author
|
Yes. |
bors
added a commit
that referenced
this pull request
Jul 23, 2014
The first commit reverts a similar fix that only solves the `make install` case. This adds the `--enable-dist-host-only` flag to configure to preserve the old behavior, which the nightly bots rely on. The bots will need to be updated soon after this lands (or they will ~double in size). Closes #15711
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 31, 2025
- Make the diagnostic message actually desribe the problem - Make the suggestion verbose, because we lint multiline exprs changelog: [`match_as_ref`]: improve diagnostics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit reverts a similar fix that only solves the
make installcase. This adds the--enable-dist-host-onlyflag to configure to preserve the old behavior, which the nightly bots rely on. The bots will need to be updated soon after this lands (or they will ~double in size).Closes #15711