Add fmt::Show trait implementation to posix and windows Path's#17534
Add fmt::Show trait implementation to posix and windows Path's#17534wickerwaka wants to merge 1 commit intorust-lang:masterfrom
Conversation
|
@vks not if I want to use #[deriving(Show)] on a struct that contains a Path. Doesn't it seem reasonable that Path would implement show? Its a pretty common thing people want to do. |
|
I meant: Couldn't your implementation of |
|
cc @kballard |
|
@vks ah yes, good point |
|
See the discussion thread here about some of the tradeoffs. |
|
This has been proposed multiple times before. It's always been considered too risky to have The proper solution to |
|
At this time the |
…eykril fix: Skip match exhaustiveness checking if pattern type contains errors Should fix rust-lang/rust-analyzer#17509, checking when errors are involved is generally a bad idea as the algorithm doesn't really expect error types in the first place I believe
fix: Panic in debug profile for tuple deconstruct with arity mismatch Fixes rust-lang#17585, which doesn't affect daily use cases but quite annoying in development of r-a itself like writing tests. This PR applies similar approach as in rust-lang#17534, skipping match usefulness check for patterns containing errors
fix: Panic in debug profile for tuple deconstruct with arity mismatch Fixes rust-lang#17585, which doesn't affect daily use cases but quite annoying in development of r-a itself like writing tests. This PR applies similar approach as in rust-lang#17534, skipping match usefulness check for patterns containing errors
Implement the Show trait for both Path implementations.