Dlist examples#21126
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gankro (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
src/libcollections/dlist.rs
Outdated
There was a problem hiding this comment.
We've been leaving off the 'rust' in these examples. It defaults to rust, but it's nice to have when the code blocks are by themselves, ie, in the longform docs. But since this is embedded inside of a Rust comment, Github doesn't highlihght them anyway, so it's just noise.
There was a problem hiding this comment.
So three backticks, without "rust" after them is the preferred example syntax for the future? I just borrowed from the other examples in the file.
|
This looks great! Just two small nits. After that, and a squash, r=me |
Dlist examples Reviewed-by: steveklabnik
Dlist examples Reviewed-by: steveklabnik
Dlist examples Reviewed-by: steveklabnik
Just some documentation test examples for the DList collection.
fix: fix parameter info with missing arguments
5 participants
Just some documentation test examples for the DList collection.