Skip to content

Comments

Add tests for a few issues.#42724

Merged
bors merged 1 commit intorust-lang:masterfrom
Mark-Simulacrum:tests
Jun 24, 2017
Merged

Add tests for a few issues.#42724
bors merged 1 commit intorust-lang:masterfrom
Mark-Simulacrum:tests

Conversation

@Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Jun 17, 2017 •
edited
Loading

Fixes #41998
Fixes #38381
Fixes #37515
Fixes #37510
Fixes #37366
Fixes #37323
Fixes #37051
Fixes #36839
Fixes #35570
Fixes #34373
Fixes #34222

Certainly not all of the E-needstest issues right now, but I started to get bored.

@rust-highfive
Copy link
Contributor

rust-highfive commented Jun 17, 2017

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 17, 2017
tirr-c
tirr-c reviewed Jun 18, 2017
View reviewed changes
src/test/compile-fail/issue-39553.rs Outdated
Copy link
Contributor

@tirr-c tirr-c Jun 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue says that the ICE occurs when the lifetime elision is valid. When we add an argument here to make the elision valid(for example, v: &usize), we get an ICE. At the issue it was &self.

Copy link
Member Author

@Mark-Simulacrum Mark-Simulacrum Jun 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. I will remove this test case tomorrow then and unmark the issue as E-needstest.

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 18, 2017
Merged
@alexcrichton
Copy link
Member

alexcrichton commented Jun 22, 2017

@bors: r+

@bors
Copy link
Collaborator

bors commented Jun 22, 2017

📌 Commit 622e8c0 has been approved by alexcrichton

@alexcrichton alexcrichton assigned alexcrichton and unassigned brson Jun 22, 2017
@alexcrichton alexcrichton added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2017
@Mark-Simulacrum
Copy link
Member Author

Mark-Simulacrum commented Jun 22, 2017

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 22, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42724 - Mark-Simulacrum:tests, r=alexcrichton
abba6e8 
Add tests for a few issues.

Fixes rust-lang#41998
Fixes rust-lang#38381
Fixes rust-lang#37515
Fixes rust-lang#37510
Fixes rust-lang#37508
Fixes rust-lang#37366
Fixes rust-lang#37323
Fixes rust-lang#37051
Fixes rust-lang#36839
Fixes rust-lang#35570
Fixes rust-lang#34373
Fixes rust-lang#34222

Certainly not all of the E-needstest issues right now, but I started to get bored.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 22, 2017
Closed
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 23, 2017
Closed
@bors
Copy link
Collaborator

bors commented Jun 23, 2017

⌛ Testing commit 622e8c0 with merge e087d609c1a847c04ecf01ce032cf3a2463ab9d0...

@bors
Copy link
Collaborator

bors commented Jun 23, 2017

💔 Test failed - status-travis

@Mark-Simulacrum
Copy link
Member Author

Mark-Simulacrum commented Jun 23, 2017

Ignored emscripten.

@bors r=alexcrichton

@bors
Copy link
Collaborator

bors commented Jun 23, 2017

📌 Commit 9d3d4fb has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Jun 23, 2017

⌛ Testing commit 9d3d4fb4642fb5d424a4e4bd7570bb989ac3edf7 with merge c5484529461f708137f2d8c6cf67cd7ac64fd224...

@bors
Copy link
Collaborator

bors commented Jun 23, 2017

💔 Test failed - status-appveyor

@Mark-Simulacrum
Copy link
Member Author

Mark-Simulacrum commented Jun 23, 2017

Removed the test for #37508 since the failure was weird and I can't reproduce. I'll leave it for a later PR.

@bors retry

@Mark-Simulacrum
Copy link
Member Author

Mark-Simulacrum commented Jun 23, 2017

err

@bors r=alexcrichton

@bors
Copy link
Collaborator

bors commented Jun 23, 2017

📌 Commit 2346169 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Jun 23, 2017

⌛ Testing commit 2346169 with merge 6350316f22d5c18012f57448ac66fa390b45037d...

@bors
Copy link
Collaborator

bors commented Jun 23, 2017

💔 Test failed - status-travis

@Mark-Simulacrum
Copy link
Member Author

Mark-Simulacrum commented Jun 23, 2017

@bors retry

os x timed out

@brson
Copy link
Contributor

brson commented Jun 23, 2017

So beautiful 😂

@bors
Copy link
Collaborator

bors commented Jun 23, 2017

⌛ Testing commit 2346169 with merge 33a2208ebf913d6927fe650278843f9497013975...

@bors bors mentioned this pull request Jun 23, 2017
Merged
@bors
Copy link
Collaborator

bors commented Jun 24, 2017

💔 Test failed - status-travis

@Mark-Simulacrum
Copy link
Member Author

Mark-Simulacrum commented Jun 24, 2017

How hard is it to just add some regression tests, really?

@bors retry
osx timeout

@bors
Copy link
Collaborator

bors commented Jun 24, 2017

⌛ Testing commit 2346169 with merge b0081b3...

bors added a commit that referenced this pull request Jun 24, 2017
@bors
Auto merge of #42724 - Mark-Simulacrum:tests, r=alexcrichton
b0081b3 
Add tests for a few issues.

Fixes #41998
Fixes #38381
Fixes #37515
Fixes #37510
Fixes #37366
Fixes #37323
Fixes #37051
Fixes #36839
Fixes #35570
Fixes #34373
Fixes #34222

Certainly not all of the E-needstest issues right now, but I started to get bored.
@bors
Copy link
Collaborator

bors commented Jun 24, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing b0081b3 to master...

@bors bors merged commit 2346169 into rust-lang:master Jun 24, 2017
@steveklabnik steveklabnik mentioned this pull request Apr 1, 2019
Closed
@Mark-Simulacrum Mark-Simulacrum deleted the tests branch June 8, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tirr-c tirr-c tirr-c left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@alexcrichton alexcrichton

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Mark-Simulacrum @rust-highfive @alexcrichton @bors @brson @tirr-c